From patchwork Tue Oct 6 14:58:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 7335471 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1BDD99F1B9 for ; Tue, 6 Oct 2015 14:58:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 493222064E for ; Tue, 6 Oct 2015 14:58:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65D672071A for ; Tue, 6 Oct 2015 14:58:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752759AbbJFO6r (ORCPT ); Tue, 6 Oct 2015 10:58:47 -0400 Received: from mail-ig0-f176.google.com ([209.85.213.176]:34890 "EHLO mail-ig0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbbJFO6p (ORCPT ); Tue, 6 Oct 2015 10:58:45 -0400 Received: by igbkq10 with SMTP id kq10so86505560igb.0; Tue, 06 Oct 2015 07:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:from:to:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=ObJ/S+FKmIItFzZ7gczLOtc3WvTwCvBNqMpVOUCNuhw=; b=VjO/6VbKbmfYswmZoZ/hYW+YcDMeOhdEux9Iaz0Nou1GGBT1CmxzE1+OjhYblm3nyW g+L2hrbMnRILeYGYcqonVnKz+Vejuzji4lW1NmKIMqnIa/AxSjXlS8VcND8f/2+Bgfof 5ioDxJxBJEul+DWdk/iZcnrInlmsQuC+l/NbW7JzDE5o4MqzpBJl/1sDeFgEtjNs5jb4 y9jMsVg0Lwg568JlZORjhBg5wai2DIUgr2IvGzcIDGGJnK2NoQrYI8wBMNmLUMPJjMOp 2az9O4pOuHLD2z5Kt0xjMupbR3qfybImEQdA0MyHzH7Tx3/xoEWJX1U4VLJ/V7BJgb9i DIEw== X-Received: by 10.50.41.104 with SMTP id e8mr10466460igl.64.1444143524181; Tue, 06 Oct 2015 07:58:44 -0700 (PDT) Received: from manet.1015granger.net ([2604:8800:100:81fc:82ee:73ff:fe43:d64f]) by smtp.gmail.com with ESMTPSA id b10sm6937605igb.9.2015.10.06.07.58.43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Oct 2015 07:58:43 -0700 (PDT) Subject: [PATCH v2 01/16] xprtrdma: Enable swap-on-NFS/RDMA From: Chuck Lever To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org Date: Tue, 06 Oct 2015 10:58:43 -0400 Message-ID: <20151006145842.11788.90380.stgit@manet.1015granger.net> In-Reply-To: <20151006142430.11788.42604.stgit@manet.1015granger.net> References: <20151006142430.11788.42604.stgit@manet.1015granger.net> User-Agent: StGit/0.17.1-3-g7d0f MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP After adding a swapfile on an NFS/RDMA mount and removing the normal swap partition, I was able to push the NFS client well into swap without any issue. I forgot to swapoff the NFS file before rebooting. This pinned the NFS mount and the IB core and provider, causing shutdown to hang. I think this is expected and safe behavior. Probably shutdown scripts should "swapoff -a" before unmounting any filesystems. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/transport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c index 41e452b..e9e5ed7 100644 --- a/net/sunrpc/xprtrdma/transport.c +++ b/net/sunrpc/xprtrdma/transport.c @@ -676,7 +676,7 @@ static void xprt_rdma_print_stats(struct rpc_xprt *xprt, struct seq_file *seq) static int xprt_rdma_enable_swap(struct rpc_xprt *xprt) { - return -EINVAL; + return 0; } static void