| Message ID | 20160318054159.GE2111@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 03/17/16 22:41, Dan Carpenter wrote: > The first argument of WARN_ON() is a condition, so it means the warning > message here will just be the name without the ->qp_num information. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c > index 1d13090..0bd3cb2 100644 > --- a/drivers/infiniband/ulp/srpt/ib_srpt.c > +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c > @@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct ib_cq *cq, struct ib_wc *wc) > if (srpt_set_ch_state(ch, CH_DISCONNECTED)) > schedule_work(&ch->release_work); > else > - WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num); > + WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num); > } > } Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 3/18/2016 9:17 PM, Bart Van Assche wrote: > On 03/17/16 22:41, Dan Carpenter wrote: >> The first argument of WARN_ON() is a condition, so it means the warning >> message here will just be the name without the ->qp_num information. >> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> >> >> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c >> b/drivers/infiniband/ulp/srpt/ib_srpt.c >> index 1d13090..0bd3cb2 100644 >> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c >> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c >> @@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct >> ib_cq *cq, struct ib_wc *wc) >> if (srpt_set_ch_state(ch, CH_DISCONNECTED)) >> schedule_work(&ch->release_work); >> else >> - WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num); >> + WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num); >> } >> } > > Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com> Thanks, applied.
diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c index 1d13090..0bd3cb2 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct ib_cq *cq, struct ib_wc *wc) if (srpt_set_ch_state(ch, CH_DISCONNECTED)) schedule_work(&ch->release_work); else - WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num); + WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num); } }
The first argument of WARN_ON() is a condition, so it means the warning message here will just be the name without the ->qp_num information. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html