From patchwork Wed May 4 14:53:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever III X-Patchwork-Id: 9015421 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EAE2ABF440 for ; Wed, 4 May 2016 14:53:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 196D0203A1 for ; Wed, 4 May 2016 14:53:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BF4F203AA for ; Wed, 4 May 2016 14:53:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751161AbcEDOxR (ORCPT ); Wed, 4 May 2016 10:53:17 -0400 Received: from mail-ig0-f173.google.com ([209.85.213.173]:34958 "EHLO mail-ig0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751202AbcEDOxQ (ORCPT ); Wed, 4 May 2016 10:53:16 -0400 Received: by mail-ig0-f173.google.com with SMTP id bi2so149995250igb.0; Wed, 04 May 2016 07:53:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:from:to:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=rx06KLwc7g4HrMozbnS3L0CfU19D3C0HjTbox8Pk51k=; b=u6V7II3gQqMQAfH/9V/Pwr0EctPy6uouEG0ijGjJevP59R48jQ/KLZPBklY6N4BV/o axCMrprkjQ1imZ4uNO94vY3HIY9tQ8M5zoEvnnFwl8U6e0LE6MTpYtgsI8LaSQfhEr+R fUCyPVorAjstutagjIJbzwC/vgMB/rJbK0O23cckmkpMGFjBFD7mOHRLnHMe9O9R0zpq 5ReCp3i5PFPxYuVUmmmzGwLwocLi5NMro+9hsAj5p7M1cw7+KAhHavX8ZqRf0Cv/qhpC 0ZCte+51TdTFTs3UxCIKnvLBMZkfVh2GmjMXz/GXUJLL7PVsCDfLYrmram4bT7VMdwOJ jxxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:from:to:cc:date:message-id :in-reply-to:references:user-agent:mime-version :content-transfer-encoding; bh=rx06KLwc7g4HrMozbnS3L0CfU19D3C0HjTbox8Pk51k=; b=iMXhdT5H0Nvs/ROIjQ8SJHluyoED981pbucKGtKuADePBixAR6h08ikZYKDvhh3yqW jhUr/0oGLlGNJvuvUTTL7sG+bW9svIJeN1yEC059SIOFr/v2gv3M4mUHd6ViOJZIcD+H 8R+BuUKigMd3D2Yh2E7Q7Xhe1yAFxircSUAateIKcuBlNUnRd/RfW3QK12OGxbeF9yUQ J4LXRNtV5tF4wMxmudH1epaXbXoK2aCxyXXlkVFGd8rPxSH5SHw6fl4AkDZbqsKy98FI 8M64haITtJetB29c6ljgq64wKu+Ypd1e6ujz6pC5pgzxmObBjnJe9pfEDsCxZ9kMrGWl hGyQ== X-Gm-Message-State: AOPr4FWBZW25uNEydjPUiT9vS0k3mvUCZtltcD1Wtz5gSA1f8pxywC9+ck3tHSWLl0u8jA== X-Received: by 10.50.60.132 with SMTP id h4mr31205451igr.78.1462373595246; Wed, 04 May 2016 07:53:15 -0700 (PDT) Received: from klimt.1015granger.net ([2604:8800:100:81fc:ec4:7aff:fe6c:6aa0]) by smtp.gmail.com with ESMTPSA id 70sm1536895ioz.16.2016.05.04.07.53.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 May 2016 07:53:14 -0700 (PDT) Subject: [PATCH v2 4/9] svcrdma: Remove superfluous line from rdma_read_chunks() From: Chuck Lever To: bfields@fieldses.org Cc: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org Date: Wed, 04 May 2016 10:53:14 -0400 Message-ID: <20160504145314.6602.32998.stgit@klimt.1015granger.net> In-Reply-To: <20160504144730.6602.89073.stgit@klimt.1015granger.net> References: <20160504144730.6602.89073.stgit@klimt.1015granger.net> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Clean up: svc_rdma_get_read_chunk() already returns a pointer to the Read list. No need to set "ch" again to the value it already contains. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c index 234be9d..12e7899 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c +++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c @@ -447,10 +447,8 @@ static int rdma_read_chunks(struct svcxprt_rdma *xprt, head->arg.len = rqstp->rq_arg.len; head->arg.buflen = rqstp->rq_arg.buflen; - ch = (struct rpcrdma_read_chunk *)&rmsgp->rm_body.rm_chunks[0]; - position = be32_to_cpu(ch->rc_position); - /* RDMA_NOMSG: RDMA READ data should land just after RDMA RECV data */ + position = be32_to_cpu(ch->rc_position); if (position == 0) { head->arg.pages = &head->pages[0]; page_offset = head->byte_len;