| Message ID | 20170107063042.GD26959@elgon.mountain (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Sat, Jan 07, 2017 at 09:30:42AM +0300, Dan Carpenter wrote: > The debug printk was indented more than it should have been and we > can remove an unnecessary line break. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c > index 98923a8cf86d..b9dc2c540946 100644 > --- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c > +++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c > @@ -4498,9 +4498,9 @@ void i40iw_sc_vsi_init(struct i40iw_sc_vsi *vsi, struct i40iw_vsi_init_info *inf > i40iw_fill_qos_list(info->params->qs_handle_list); > > for (i = 0; i < I40IW_MAX_USER_PRIORITY; i++) { > - vsi->qos[i].qs_handle = > - info->params->qs_handle_list[i]; > - i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, vsi->qos[i].qs_handle); > + vsi->qos[i].qs_handle = info->params->qs_handle_list[i]; > + i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, > + vsi->qos[i].qs_handle); Nice catch :) FWIW: Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> > spin_lock_init(&vsi->qos[i].lock); > INIT_LIST_HEAD(&vsi->qos[i].qplist); > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Jan 07, 2017 at 09:30:42AM +0300, Dan Carpenter wrote: > The debug printk was indented more than it should have been and we > can remove an unnecessary line break. > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c > index 98923a8cf86d..b9dc2c540946 100644 > --- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c > +++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c > @@ -4498,9 +4498,9 @@ void i40iw_sc_vsi_init(struct i40iw_sc_vsi *vsi, struct i40iw_vsi_init_info *inf > i40iw_fill_qos_list(info->params->qs_handle_list); > > for (i = 0; i < I40IW_MAX_USER_PRIORITY; i++) { > - vsi->qos[i].qs_handle = > - info->params->qs_handle_list[i]; > - i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, vsi->qos[i].qs_handle); > + vsi->qos[i].qs_handle = info->params->qs_handle_list[i]; It appears there is a tab char after the =. Rather than a space. > + i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, > + vsi->qos[i].qs_handle); > spin_lock_init(&vsi->qos[i].lock); > INIT_LIST_HEAD(&vsi->qos[i].qplist); > } -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c index 98923a8cf86d..b9dc2c540946 100644 --- a/drivers/infiniband/hw/i40iw/i40iw_ctrl.c +++ b/drivers/infiniband/hw/i40iw/i40iw_ctrl.c @@ -4498,9 +4498,9 @@ void i40iw_sc_vsi_init(struct i40iw_sc_vsi *vsi, struct i40iw_vsi_init_info *inf i40iw_fill_qos_list(info->params->qs_handle_list); for (i = 0; i < I40IW_MAX_USER_PRIORITY; i++) { - vsi->qos[i].qs_handle = - info->params->qs_handle_list[i]; - i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, vsi->qos[i].qs_handle); + vsi->qos[i].qs_handle = info->params->qs_handle_list[i]; + i40iw_debug(vsi->dev, I40IW_DEBUG_DCB, "qset[%d]: %d\n", i, + vsi->qos[i].qs_handle); spin_lock_init(&vsi->qos[i].lock); INIT_LIST_HEAD(&vsi->qos[i].qplist); }
The debug printk was indented more than it should have been and we can remove an unnecessary line break. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html