From patchwork Mon Jun 26 05:05:08 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 9808615 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2D96460329 for ; Mon, 26 Jun 2017 05:05:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 402012807B for ; Mon, 26 Jun 2017 05:05:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 34C3228402; Mon, 26 Jun 2017 05:05:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C3E8F2807B for ; Mon, 26 Jun 2017 05:05:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750832AbdFZFFS (ORCPT ); Mon, 26 Jun 2017 01:05:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:55880 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbdFZFFS (ORCPT ); Mon, 26 Jun 2017 01:05:18 -0400 Received: from localhost (unknown [213.57.247.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9885C22BCE; Mon, 26 Jun 2017 05:05:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9885C22BCE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=leon@kernel.org From: Leon Romanovsky To: Doug Ledford Cc: linux-rdma@vger.kernel.org, Chuck Lever Subject: [PATCH rdma-next] RDMA/rw: Remove force_mr module parameter Date: Mon, 26 Jun 2017 08:05:08 +0300 Message-Id: <20170626050508.14723-1-leonro@mellanox.com> X-Mailer: git-send-email 2.13.1 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The force_mr module parameter wasn't exposed to the users from the beginning with the commit a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API"). Because this variable is for very rare debug while doing bringup of new ULP and/or converting old ULP to new R/W api. There is no need to expose that parameter to regular users. Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/rw.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) -- 2.13.1 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/infiniband/core/rw.c b/drivers/infiniband/core/rw.c index dbfd854c32c9..5037ebde62c5 100644 --- a/drivers/infiniband/core/rw.c +++ b/drivers/infiniband/core/rw.c @@ -22,9 +22,14 @@ enum { RDMA_RW_SIG_MR, }; +/* + * This parameter is useful for new ULP bringup + * and/or conversion to this R/W API. + * + * Setting it to "true" will allow to mimic with IB devices, + * the slow memory registration of iWARP devices. + */ static bool rdma_rw_force_mr; -module_param_named(force_mr, rdma_rw_force_mr, bool, 0); -MODULE_PARM_DESC(force_mr, "Force usage of MRs for RDMA READ/WRITE operations"); /* * Check if the device might use memory registration. This is currently only @@ -503,7 +508,7 @@ struct ib_send_wr *rdma_rw_ctx_wrs(struct rdma_rw_ctx *ctx, struct ib_qp *qp, rdma_rw_update_lkey(&ctx->sig->data, true); if (ctx->sig->prot.mr) rdma_rw_update_lkey(&ctx->sig->prot, true); - + ctx->sig->sig_mr->need_inval = true; ib_update_fast_reg_key(ctx->sig->sig_mr, ib_inc_rkey(ctx->sig->sig_mr->lkey));