From patchwork Mon Jun 26 18:33:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chien Tung X-Patchwork-Id: 9810291 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 37A35603F2 for ; Mon, 26 Jun 2017 18:34:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 54C8F283F2 for ; Mon, 26 Jun 2017 18:33:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 47B892842A; Mon, 26 Jun 2017 18:33:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BF0F6283F2 for ; Mon, 26 Jun 2017 18:33:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751388AbdFZSde (ORCPT ); Mon, 26 Jun 2017 14:33:34 -0400 Received: from mga02.intel.com ([134.134.136.20]:30082 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbdFZSde (ORCPT ); Mon, 26 Jun 2017 14:33:34 -0400 Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jun 2017 11:33:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,396,1493708400"; d="scan'208";a="117641167" Received: from ctung-mobl3.amr.corp.intel.com (HELO ctung-mobl3) ([10.122.40.69]) by orsmga005.jf.intel.com with SMTP; 26 Jun 2017 11:33:31 -0700 Received: by ctung-mobl3 (sSMTP sendmail emulation); Mon, 26 Jun 2017 13:33:30 -0500 Date: Mon, 26 Jun 2017 13:33:29 -0500 From: Chien Tin Tung To: Leon Romanovsky Cc: Doug Ledford , "linux-rdma@vger.kernel.org" , Bart Van Assche , Steve Wise Subject: Re: [PATCH rdma-next V2 1/5] RDMA/netlink: Remove netlink clients infrastructure Message-ID: <20170626183329.GA11716@ctung-MOBL3.amr.corp.intel.com> References: <20170613085927.2908-1-leon@kernel.org> <20170613085927.2908-2-leon@kernel.org> <20170626175505.GA2904@ctung-MOBL3.amr.corp.intel.com> <20170626181324.GE1248@mtr-leonro.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20170626181324.GE1248@mtr-leonro.local> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Jun 26, 2017 at 09:13:24PM +0300, Leon Romanovsky wrote: > On Mon, Jun 26, 2017 at 12:55:05PM -0500, Chien Tin Tung wrote: > > On Tue, Jun 13, 2017 at 03:59:23AM -0500, Leon Romanovsky wrote: > > > From: Leon Romanovsky > > > > > > RDMA netlink has complicated infrastructure to add and remove netlink > > > clients to NETLINK_RDMA family. This complicates the code and not in > > > use because not many clients are available (3 clients) and most of them > > > (2 clients) are statically compiled together with netlink.c. > > > > > > The following patch refactors RDMA netlink and opens door for the future > > > patches which will be able to get rid of a lot of dead iwcm* code. > > > > > > Signed-off-by: Leon Romanovsky > > > Reviewed-by: Chien Tin Tung > > > --- > > > drivers/infiniband/core/cma.c | 6 +- > > > drivers/infiniband/core/device.c | 41 +++------ > > > drivers/infiniband/core/iwcm.c | 10 +-- > > > drivers/infiniband/core/netlink.c | 185 ++++++++++++++++++-------------------- > > > include/rdma/rdma_netlink.h | 17 ++-- > > > 5 files changed, 110 insertions(+), 149 deletions(-) > > > > > diff --git a/include/rdma/rdma_netlink.h b/include/rdma/rdma_netlink.h > > > index 585266144329..6735dcf5d2a3 100644 > > > --- a/include/rdma/rdma_netlink.h > > > +++ b/include/rdma/rdma_netlink.h > > > @@ -10,27 +10,22 @@ struct ibnl_client_cbs { > > > struct module *module; > > > }; > > > > > > -int ibnl_init(void); > > > -void ibnl_cleanup(void); > > > +int rdma_nl_init(void); > > > +void rdma_nl_exit(void); > > > > This hunk is in direct conflict with 233c1955 which you removed > > ibnl_init and ibnl_cleanup. Are you putting back the init and > > exit or do you want to leave them out? > > We have different git hashes and I don't know about which commit you are > referring. There is only one true upstream, go look at Linus' git. > > This commit simply renames exit/init functions in general header file. > The init/exit is still needed, because it is called from device.c. > > The git log doesn't show me anything suspicious too. > ➜ linux-rdma git:(topic/rdma-netlink-v1) git log -p include/rdma/rdma_netlink.h Your git and branch is out of sync. This is the relevant part of the patch. commit 233c1955835bd8649003be9bb3d8e79788b08be1 Author: Leon Romanovsky Date: Sun May 14 15:49:57 2017 +0300 RDMA/netlink: Reduce exposure of RDMA netlink functions RDMA netlink is part of ib_core, hence ibnl_chk_listeners(), ibnl_init() and ibnl_cleanup() don't need to be published in public header file. Let's remove EXPORT_SYMBOL from ibnl_chk_listeners() and move all these functions to private header file. CC: Yuval Shaia Signed-off-by: Leon Romanovsky Reviewed-by: Yuval Shaia Signed-off-by: Doug Ledford --- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/rdma/rdma_netlink.h b/include/rdma/rdma_netlink.h index 5852661..348c102 100644 --- a/include/rdma/rdma_netlink.h +++ b/include/rdma/rdma_netlink.h @@ -10,9 +10,6 @@ struct ibnl_client_cbs { struct module *module; }; -int ibnl_init(void); -void ibnl_cleanup(void); - Chien