diff mbox

[v1] IB/rxe: Remove unneeded check

Message ID 20170721192050.3724-1-yuval.shaia@oracle.com (mailing list archive)
State Accepted
Headers show

Commit Message

Yuval Shaia July 21, 2017, 7:20 p.m. UTC
Port validation is performed in ib_core, no need to duplicate it here.

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
v0 -> v1:
	* Restore one line that was removed by mistake
---
 drivers/infiniband/sw/rxe/rxe_av.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Leon Romanovsky July 23, 2017, 1:07 p.m. UTC | #1
On Fri, Jul 21, 2017 at 10:20:50PM +0300, Yuval Shaia wrote:
> Port validation is performed in ib_core, no need to duplicate it here.
>
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> ---
> v0 -> v1:
> 	* Restore one line that was removed by mistake
> ---
>  drivers/infiniband/sw/rxe/rxe_av.c | 5 -----
>  1 file changed, 5 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Doug Ledford Aug. 18, 2017, 4:10 p.m. UTC | #2
On Sun, 2017-07-23 at 16:07 +0300, Leon Romanovsky wrote:
> On Fri, Jul 21, 2017 at 10:20:50PM +0300, Yuval Shaia wrote:
> > Port validation is performed in ib_core, no need to duplicate it
> > here.
> > 
> > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> > ---
> > v0 -> v1:
> > 	* Restore one line that was removed by mistake
> > ---
> >  drivers/infiniband/sw/rxe/rxe_av.c | 5 -----
> >  1 file changed, 5 deletions(-)
> > 
> 
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

Thanks, applied.
diff mbox

Patch

diff --git a/drivers/infiniband/sw/rxe/rxe_av.c b/drivers/infiniband/sw/rxe/rxe_av.c
index f8172eb993cc..1cc9e2e1365d 100644
--- a/drivers/infiniband/sw/rxe/rxe_av.c
+++ b/drivers/infiniband/sw/rxe/rxe_av.c
@@ -38,11 +38,6 @@  int rxe_av_chk_attr(struct rxe_dev *rxe, struct rdma_ah_attr *attr)
 {
 	struct rxe_port *port;
 
-	if (rdma_ah_get_port_num(attr) != 1) {
-		pr_info("invalid port_num = %d\n", rdma_ah_get_port_num(attr));
-		return -EINVAL;
-	}
-
 	port = &rxe->port;
 
 	if (rdma_ah_get_ah_flags(attr) & IB_AH_GRH) {