From patchwork Tue Aug 15 17:29:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 9902313 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 86BA7602C9 for ; Tue, 15 Aug 2017 17:29:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6F2CB287E5 for ; Tue, 15 Aug 2017 17:29:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 63E78287F2; Tue, 15 Aug 2017 17:29:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0B57C288B4 for ; Tue, 15 Aug 2017 17:29:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753630AbdHOR3c (ORCPT ); Tue, 15 Aug 2017 13:29:32 -0400 Received: from mail-pg0-f44.google.com ([74.125.83.44]:35256 "EHLO mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753568AbdHOR33 (ORCPT ); Tue, 15 Aug 2017 13:29:29 -0400 Received: by mail-pg0-f44.google.com with SMTP id v189so9486198pgd.2 for ; Tue, 15 Aug 2017 10:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FoeLOwnMVvcfs0LTXSg9LC3stf7RfM7Pw6vplQmxLG4=; b=zDShbox8GMisKu4gvGygs3zCGn5rNHOfiMVpBOzBqO0tiDdwyPPOmIUpo4V8cOOqu6 02CroMrw1jzYGgr4byAA1xsV+yp8sHzTuLB51NjfyY+qFW/LJLSQ0raksR4R99RmG5rT 4zM3lxLB1/19WNT8Yqguwz4DiGsACZ6A+Cl1AeSd4s/dq33uegCTIWtv009aDvEojK5R OkDkwShNZOiKG5qJbgLG7ad11yM1PGSE71UvLOs0bdW3ePFDliTZzlCBk7oV5hIKzEnr HO+jVAZv+VRCRIgGBRD/41hJNk22Qm562vQhLKaHl0eInncVFzqhMlX/VKz8kXWat1fh yWnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=FoeLOwnMVvcfs0LTXSg9LC3stf7RfM7Pw6vplQmxLG4=; b=h9LUsUb3h0scXto55h94r8z5pHTwtcLHNMOnGuFhWZbI/fORTDp8EoHMlaOp17SWz6 1ARb9C5TxYDQruJl8l9lDF1CYUKsU6Ems1caZZ/17+wP0IpY0c8tVryfYhNnT2kVKRhm gptZOg7cNsSAr3W6IwnxFIboNN0guyVXYf3E3xXVUlOxEwmC5o2zM3bL53+7eSITof+e Jz0I/Y6TK+woPr7evZmGyM1oOlf2JsOem6KFswvgk2+iVKdEnrMqXrwzTVuem7zyHxuN dFSbUDIdu36t/EWWBt0A5K5WVUqF84chs78GtMHGgk78LhLm/B05eLXJR82jrShJs4dx 7Qjg== X-Gm-Message-State: AHYfb5hsZ4QJ3LQTHie+L1SamSEidJq2bnTsH8Iu1aBcPm4SQBz7V1c3 ORskrmzQeKS4B6od X-Received: by 10.84.231.2 with SMTP id f2mr32858605plk.253.1502818169477; Tue, 15 Aug 2017 10:29:29 -0700 (PDT) Received: from xeon-e3.lan (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id n1sm20180696pfj.46.2017.08.15.10.29.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Aug 2017 10:29:28 -0700 (PDT) From: Stephen Hemminger X-Google-Original-From: Stephen Hemminger To: mlindner@marvell.com, stephen@networkplumber.org, mst@redhat.com, jasowang@redhat.com Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, virtualization@lists.linux-foundation.org, Stephen Hemminger Subject: [PATCH net-next 1/4] tun/tap: use paren's with sizeof Date: Tue, 15 Aug 2017 10:29:16 -0700 Message-Id: <20170815172919.26153-2-sthemmin@microsoft.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170815172919.26153-1-sthemmin@microsoft.com> References: <20170815172919.26153-1-sthemmin@microsoft.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Although sizeof is an operator in C. The kernel coding style convention is to always use it like a function and add parenthesis. Signed-off-by: Stephen Hemminger --- drivers/net/tap.c | 2 +- drivers/net/tun.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/tap.c b/drivers/net/tap.c index 0d039411e64c..21b71ae947fd 100644 --- a/drivers/net/tap.c +++ b/drivers/net/tap.c @@ -1215,7 +1215,7 @@ int tap_queue_resize(struct tap_dev *tap) int n = tap->numqueues; int ret, i = 0; - arrays = kmalloc(sizeof *arrays * n, GFP_KERNEL); + arrays = kmalloc_array(n, sizeof(*arrays), GFP_KERNEL); if (!arrays) return -ENOMEM; diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 5892284eb8d0..f5017121cd57 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -2737,7 +2737,7 @@ static int tun_queue_resize(struct tun_struct *tun) int n = tun->numqueues + tun->numdisabled; int ret, i; - arrays = kmalloc(sizeof *arrays * n, GFP_KERNEL); + arrays = kmalloc_array(n, sizeof(*arrays), GFP_KERNEL); if (!arrays) return -ENOMEM;