diff mbox

[rdma-next] RDMA/hns: remove redundant assignment to variable j

Message ID 20170929135227.8343-1-colin.king@canonical.com (mailing list archive)
State Accepted
Headers show

Commit Message

Colin King Sept. 29, 2017, 1:52 p.m. UTC 
From: Colin Ian King <colin.king@canonical.com>

Variable j is being assigned to loop_j and then later being
assigned to a new value in for loops. The first initialization
is therefore redundant and can be removed.

Cleans up clang warning:
warning: Value stored to 'j' is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/infiniband/hw/hns/hns_roce_mr.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Doug Ledford Sept. 29, 2017, 3:27 p.m. UTC | #1 
On Fri, 2017-09-29 at 14:52 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Variable j is being assigned to loop_j and then later being
> assigned to a new value in for loops. The first initialization
> is therefore redundant and can be removed.
> 
> Cleans up clang warning:
> warning: Value stored to 'j' is never read
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Thanks, applied.
diff mbox

Patch

diff --git a/drivers/infiniband/hw/hns/hns_roce_mr.c b/drivers/infiniband/hw/hns/hns_roce_mr.c
index 7e6ce76b32df..452136d98ad5 100644
--- a/drivers/infiniband/hw/hns/hns_roce_mr.c
+++ b/drivers/infiniband/hw/hns/hns_roce_mr.c
@@ -272,7 +272,6 @@  static void hns_roce_loop_free(struct hns_roce_dev *hr_dev,
 	mhop_num = hr_dev->caps.pbl_hop_num;
 
 	i = loop_i;
-	j = loop_j;
 	if (mhop_num == 3 && err_loop_index == 2) {
 		for (; i >= 0; i--) {
 			dma_free_coherent(dev, pbl_bt_sz, mr->pbl_bt_l1[i],