| Message ID | 20180201100148.GA8959@mwanda (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
On Thu, Feb 01, 2018 at 01:01:48PM +0300, Dan Carpenter wrote: > We should return -ENOMEM if the allocation fails. The current code > accidentally returns success. > > Fixes: bf3c5a93c523 ("RDMA/nldev: Provide global resource utilization") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > Thanks Dan, Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
On Thu, Feb 01, 2018 at 01:01:48PM +0300, Dan Carpenter wrote: > We should return -ENOMEM if the allocation fails. The current code > accidentally returns success. > > Fixes: bf3c5a93c523 ("RDMA/nldev: Provide global resource utilization") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > Reviewed-by: Leon Romanovsky <leonro@mellanox.com> Applied to for-next, thanks Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c index fa8655e3b3ed..5326a684555f 100644 --- a/drivers/infiniband/core/nldev.c +++ b/drivers/infiniband/core/nldev.c @@ -499,8 +499,10 @@ static int nldev_res_get_doit(struct sk_buff *skb, struct nlmsghdr *nlh, return -EINVAL; msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); - if (!msg) + if (!msg) { + ret = -ENOMEM; goto err; + } nlh = nlmsg_put(msg, NETLINK_CB(skb).portid, nlh->nlmsg_seq, RDMA_NL_GET_TYPE(RDMA_NL_NLDEV, RDMA_NLDEV_CMD_RES_GET),
We should return -ENOMEM if the allocation fails. The current code accidentally returns success. Fixes: bf3c5a93c523 ("RDMA/nldev: Provide global resource utilization") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html