From patchwork Mon Mar 5 17:58:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10259429 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 818266016D for ; Mon, 5 Mar 2018 17:58:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7274428B68 for ; Mon, 5 Mar 2018 17:58:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 66E8828BB0; Mon, 5 Mar 2018 17:58:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3582628B68 for ; Mon, 5 Mar 2018 17:58:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752507AbeCER6o (ORCPT ); Mon, 5 Mar 2018 12:58:44 -0500 Received: from esa3.hgst.iphmx.com ([216.71.153.141]:55432 "EHLO esa3.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752480AbeCER6l (ORCPT ); Mon, 5 Mar 2018 12:58:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1520272722; x=1551808722; h=from:to:cc:subject:date:message-id; bh=lG7EhI8CEFkjG2avEUJ45ROnQPF3SaP3xORVEbZuXz8=; b=S4pooj9d5hGNAwIabN+VNFZYmiTwY7atkK0LNjEfGfEEuyrtchwndI7L 1OG08B9fJgyvnr+MfB0pvb0b5BT/G54D/sj6nrGh6ArWmB104f+2pzBLR UrHN6p6iOS7t0ITOho4Ihio3J6iLZ/muB8gxPhfoH+Qx8dAxOyiS19ym6 Ooiscp194aPPDru9V/zrUkZDb0gxxyBbBIYPf1HAl9hII7yYUlL0tDVGX ukSq0lCo0Myv/EcPXn3YRvo2rf32VqLFCiZKSVbN4gKg8w7OxtVCtIzkp QNsR1bguruqOHH/RCCVGBGY9SLHGUOz1CFQrilgOVwuxfPMtb/TrkppzF g==; X-IronPort-AV: E=Sophos;i="5.47,427,1515427200"; d="scan'208";a="73490409" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 06 Mar 2018 01:58:34 +0800 Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP; 05 Mar 2018 09:51:50 -0800 Received: from thinkpad-bart.sdcorp.global.sandisk.com (HELO thinkpad-bart.int.fusionio.com) ([10.11.171.236]) by uls-op-cesaip01.wdc.com with ESMTP; 05 Mar 2018 09:58:33 -0800 From: Bart Van Assche To: Jason Gunthorpe Cc: Doug Ledford , linux-rdma@vger.kernel.org, Bart Van Assche , Mike Marciniszyn , Dennis Dalessandro Subject: [PATCH] IB/hfi1: Add a missing rcu_read_unlock() Date: Mon, 5 Mar 2018 09:58:33 -0800 Message-Id: <20180305175833.7271-1-bart.vanassche@wdc.com> X-Mailer: git-send-email 2.16.2 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch avoids that sparse reports the following: drivers/infiniband/hw/hfi1/driver.c:251:13: warning: context imbalance in 'rcv_hdrerr' - different lock contexts for basic block Signed-off-by: Bart Van Assche Cc: Mike Marciniszyn Cc: Dennis Dalessandro --- drivers/infiniband/hw/hfi1/driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/hfi1/driver.c b/drivers/infiniband/hw/hfi1/driver.c index addc68e83606..46d1475b2154 100644 --- a/drivers/infiniband/hw/hfi1/driver.c +++ b/drivers/infiniband/hw/hfi1/driver.c @@ -390,6 +390,7 @@ static void rcv_hdrerr(struct hfi1_ctxtdata *rcd, struct hfi1_pportdata *ppd, svc_type = IB_CC_SVCTYPE_UC; break; default: + rcu_read_unlock(); goto drop; }