From patchwork Thu Mar 15 21:14:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 10285791 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C4498602C2 for ; Thu, 15 Mar 2018 21:14:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BDFB928C4E for ; Thu, 15 Mar 2018 21:14:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B080728C53; Thu, 15 Mar 2018 21:14:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F54028C4E for ; Thu, 15 Mar 2018 21:14:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751975AbeCOVOJ (ORCPT ); Thu, 15 Mar 2018 17:14:09 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36090 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751714AbeCOVOI (ORCPT ); Thu, 15 Mar 2018 17:14:08 -0400 Received: by mail-wm0-f65.google.com with SMTP id n3so227035wmd.1 for ; Thu, 15 Mar 2018 14:14:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SaLZV2UZThQ4idqqCnAx6TdGkHnE2OpqU14Oqy8ZhBY=; b=Mr4AZYs/PAF6dcfJlYHKeH+gKEzwxWlJpN2gOLPvjrfrxYdRZT18tVwrzgZm44NE+q FNRg87uxurmQG5Wn4MKk6hKwIbZGVmr4sH87crtLRFb8hmXTws12JxdfF3+RjaB6dImI SgGFMtKUGsJ1ms42hVgK8TZemNZLU+iy0Q1X+7lPwQxkyVkI9H26IY+DLriJs3jm4tAE p+ybUfI98s3aYEI/4rI6Pwha+TXbpDfaif7AWUxqRQskzhvgWtgOP9Kk39BJL9fA5tac 5cjelAfiMD3NHtwNcZ9ztNEgLyaGsgtBntsG0UGSLUHs39Vxr+Q1Lnr9SOFJOavHdMZj N+PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SaLZV2UZThQ4idqqCnAx6TdGkHnE2OpqU14Oqy8ZhBY=; b=aamI1AWjpWCxI/dirhM/+hlcswrBLd++u0qO0ry0uXGueULtgUMpXxPeLBMyxZ+pSC l0WQjmP/yw3VDalOPuVrOUo3WuL/GLJn6pSX+EIvhkDOkIXaXmSqTJFKB1ZQJows+K4j ielXahKX0ERYuDoaZnGn0bHbHm1/XC+KMRv8TJhTztKR/j0gxlmaWneGvI+r24WXAPgB hRP3oGcyTvblpR+RqSmSu1VBDcUw5aEAWonoHR7FVWxNV5vVxS1FVzZhkl6hFub5Hl9g 3FZQyeNDWdjz2Z8q6ayg1rosFfvcyX1pMQ/RCuwFyfkg6RtI4SMXV6jcGjZfSEx8J4AV m8TA== X-Gm-Message-State: AElRT7E6/3x/l3kF/kro+P9C7JUp6W5GroMyNPa3U4lAs+yhaTZaKnMf PocYT0Zvekb5YxlBPuEElmXzUg== X-Google-Smtp-Source: AG47ELuWnbff5dJUK64Bh0ju4ZduYYueEjsyj8E63ENhLp32HYZkTWQODKiBGE/rNR3DFwZihntMvw== X-Received: by 10.28.63.23 with SMTP id m23mr6333710wma.69.1521148446999; Thu, 15 Mar 2018 14:14:06 -0700 (PDT) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id x23sm1830291wmc.37.2018.03.15.14.14.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Mar 2018 14:14:05 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.86_2) (envelope-from ) id 1ewaCH-0007U1-RD; Thu, 15 Mar 2018 15:14:01 -0600 Date: Thu, 15 Mar 2018 15:14:01 -0600 From: Jason Gunthorpe To: Leon Romanovsky Cc: Doug Ledford , Leon Romanovsky , RDMA mailing list , Daniel Jurgens , Mark Bloch , Parav Pandit Subject: Re: [PATCH rdma-next v1 06/13] IB/core: Remove rdma_resolve_ip_route() as exported symbol Message-ID: <20180315211401.GA28731@ziepe.ca> References: <20180313140623.21693-1-leon@kernel.org> <20180313140623.21693-7-leon@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180313140623.21693-7-leon@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Mar 13, 2018 at 04:06:16PM +0200, Leon Romanovsky wrote: > From: Parav Pandit > > rdma_resolve_ip_route() is used only by ib_core module. Therefore it is > removed as exported symbol. > > Reviewed-by: Daniel Jurgens > Signed-off-by: Parav Pandit > Signed-off-by: Leon Romanovsky > drivers/infiniband/core/addr.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c > index a5b4cf030c11..d5f552780fac 100644 > +++ b/drivers/infiniband/core/addr.c > @@ -716,7 +716,6 @@ int rdma_resolve_ip_route(struct sockaddr *src_addr, > > return addr_resolve(src_in, dst_addr, addr, false, 0); > } > -EXPORT_SYMBOL(rdma_resolve_ip_route); > > void rdma_addr_cancel(struct rdma_dev_addr *addr) > { Since the export is gone the function prototype should be in core_priv.h. I added these hunks to the patch: --- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/infiniband/core/core_priv.h b/drivers/infiniband/core/core_priv.h index 0f8d1f321e8157..479418c6143085 100644 --- a/drivers/infiniband/core/core_priv.h +++ b/drivers/infiniband/core/core_priv.h @@ -338,4 +338,10 @@ int rdma_addr_find_l2_eth_by_grh(const union ib_gid *sgid, const union ib_gid *dgid, u8 *dmac, const struct net_device *ndev, int *hoplimit); + +struct rdma_dev_addr; +int rdma_resolve_ip_route(struct sockaddr *src_addr, + const struct sockaddr *dst_addr, + struct rdma_dev_addr *addr); + #endif /* _CORE_PRIV_H */ diff --git a/include/rdma/ib_addr.h b/include/rdma/ib_addr.h index bba6f5dd9ed1d9..e8860a46754a4e 100644 --- a/include/rdma/ib_addr.h +++ b/include/rdma/ib_addr.h @@ -119,10 +119,6 @@ int rdma_resolve_ip(struct rdma_addr_client *client, struct rdma_dev_addr *addr, void *context), void *context); -int rdma_resolve_ip_route(struct sockaddr *src_addr, - const struct sockaddr *dst_addr, - struct rdma_dev_addr *addr); - void rdma_addr_cancel(struct rdma_dev_addr *addr); void rdma_copy_addr(struct rdma_dev_addr *dev_addr,