From patchwork Wed Mar 28 22:43:54 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 10314275 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B891660353 for ; Wed, 28 Mar 2018 22:44:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A413529A35 for ; Wed, 28 Mar 2018 22:44:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 98D672A034; Wed, 28 Mar 2018 22:44:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1E16D29A35 for ; Wed, 28 Mar 2018 22:44:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753921AbeC1WoG (ORCPT ); Wed, 28 Mar 2018 18:44:06 -0400 Received: from mail-he1eur01on0075.outbound.protection.outlook.com ([104.47.0.75]:25792 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753423AbeC1WoE (ORCPT ); Wed, 28 Mar 2018 18:44:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+S8INnbQ2Wzy7xMAmPWRier/2NLVb/aiXiZFKeu9zx4=; b=ECy99q2eqdzVhERkjEK/kKrVTmvXtWJ7LJAEX9o26c0QbpWzPiOG6XaAia2Uy23M9w9lDza5N4GufEzza6hvrdpTlACaRc4YBZKCc1fiVx6VcQxnO60ytOhnaNfFoJ8rGmmMXaQVLlTf9GTmAK26Chi6lGSWBw9i4k5HHjsmpxE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=jgg@mellanox.com; Received: from mlx.ziepe.ca (174.3.196.123) by AM0PR05MB4452.eurprd05.prod.outlook.com (2603:10a6:208:5a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.609.10; Wed, 28 Mar 2018 22:44:01 +0000 Received: from jgg by mlx.ziepe.ca with local (Exim 4.86_2) (envelope-from ) id 1f1JnO-0004E7-JK; Wed, 28 Mar 2018 16:43:54 -0600 Date: Wed, 28 Mar 2018 16:43:54 -0600 From: Jason Gunthorpe To: Steve Wise Cc: dledford@redhat.com, leon@kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH v1 rdma-next 2/2] RDMA/CMA: Add rdma_port_space to UAPI Message-ID: <20180328224354.GK17002@mellanox.com> References: <20180327180929.8D1572BB7D@smtp.opengridcomputing.com> <20180328164435.GD17002@mellanox.com> <3947c07d-5c7e-9e2f-647d-aa516fb9414f@opengridcomputing.com> <822d0404-1f1d-e516-c5c8-bb2f6ea95275@opengridcomputing.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <822d0404-1f1d-e516-c5c8-bb2f6ea95275@opengridcomputing.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [174.3.196.123] X-ClientProxiedBy: PR2P264CA0002.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::14) To AM0PR05MB4452.eurprd05.prod.outlook.com (2603:10a6:208:5a::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 25e4d075-a15b-47ee-068a-08d594fd66b2 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM0PR05MB4452; X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4452; 3:uIKtMEku3Uyio3UJqwgg3zSR4BrDRsa/wXEOfZtdBzvkrKbkD2vx10jDRBl0QZMTl9QlbnBUbPlYIe/TULJsZIH7yuVbunH7lzN/UpYDKGnYswRkUxeGWiIFUQbU0ymY9Bg0rS9HhsS1PWU8BHp6ChxpNiumI6JBA/LOb4m/Ts/3aFd+kUTcm4FVjqrWIAw1JCqFElIaYmNbRorqi6dkQ6S9BOtLh/TBDny8RhsX2V7F0MYUGsEfOuotZLY3uNVm; 25:YC4w8i5lxeAKsjNFgmLXuOtYXJciHfaMPKzxJNkvs7tgjiOit5EQ8N98S5uA2NlWCgJA9A1GczQfKQ7O5KTWnB7vK37CRYe7oxgp8AqEomoGbrS/smexsFm3Ba24+AtGHmfo1BbjmtPUZlFma/7J2ckcd5Oyg2mEU9RqB1rxiqSMwRI2B0kAfggrtFRbOz4bUD6hIKCfdzt8xGVvmOoBOXHd+Ks+8eyvC1ETrVznwa5z61yBuNN9QiKQZBnnjTPNimOnt3t4V89fnOYgY5GBgvNoYec/jt+peaYSZCXsWOVJHl1E+9+7EPTgZzxiHZVyF77k2zG+Sc60C/0EKPgisw==; 31:6aAgNOof4a7eyjBMXe9Dtz68MyZqn7QU41NAtDdvOrEnqN9yS+gxG3Wftc5fYCQ7/RWzmyLjOsSQesLWCaCdhmHXC+sXFyTCui9xmSnACHYEyLdFnx4jWVOJxb0ndh9rLOuUuJL3fbsj2zcQVn3hDA5iiWRFTS3hLB2eouFbcFeCJxCeBrmnNW6fdjKmWiGpxDC9dVDvI0wekS5TovRv7h3BDHDptVFA1Epn0p74rA8= X-MS-TrafficTypeDiagnostic: AM0PR05MB4452: X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4452; 20:ccQJDj2mPsrvcTzIDwDhDKXAQJ/Q7z51cHdfuf+HY3Ip27uwVST1yzAwH1fExC3LNeFqeqm1uPO3ymM0IK4uornVaYq8yx1MUWIHz0KH0gZ311j/TYI2yowis2y9iHqjPNrndTMhmKaO2USNYF+XcJVN+UAkiFJSbvJ/NKk7yvxf8B201vXHAPTVW5uYMjH4UEio9y7qX+qDL2JESxfNPPkCtPFCkVDve0iur/huJpJKHdtdvSvPPMkgtys/RtHhVJjME/JYZbSajk8g5V43Lt4IAdJBAvBYE+RvyLEs3EnxBgHCqrBF8XtgsMP7aVSt8uqSOXyff+QHdHmeidgYsHJSQW7bHaJ9eunPNEpIGKDSJyse/GnSEaXkx4c4YhHF5lmunXmYzeb7lOZUvBANGa7PMrxy/0ViMzFXCfLzO3VD+qS6kxBVvgJNsGfbnjI8t79in9wRD+/qi9Vt60pH7FPfJa0Yi+0eEE9Ue3uPVNWP2e/te/t/YKf5NwgDpqEn; 4:pcvq4fHTeuZ9j4KqgxZbh9R+UxcHO0yRrRuRsg0+IQeNFcK1NVXGsjdAbo+cZHsLsmHPe48EigzdYw7DmQm2VEOJxYx790P9r3iGfOINOcLjPtp1zpFisxUO/ZkRC8nMRAr4J1gQ86wZs1DXw5vvYCjrPjsQRu6wPZAHKscPtw/j56ayAa7yfUkiq2Ju/c9T2eoMTLW4pj/ugd+j+XpujnSIoa13ophoSF+HTLumX/xmrBL9AcOfryuXOb2aHEjs355UXgygx+wCdrI2DHqnPQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501327)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM0PR05MB4452; BCL:0; PCL:0; RULEID:; SRVR:AM0PR05MB4452; X-Forefront-PRVS: 06259BA5A2 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(39380400002)(346002)(396003)(366004)(189003)(199004)(1076002)(97736004)(93886005)(59450400001)(186003)(23726003)(68736007)(83796002)(33656002)(9786002)(2906002)(305945005)(26005)(6916009)(7736002)(50466002)(486005)(86362001)(486005)(2616005)(105586002)(46656002)(53546011)(66066001)(47776003)(229853002)(386003)(316002)(11346002)(446003)(53936002)(8936002)(52116002)(6246003)(76176011)(57986006)(36756003)(6116002)(81166006)(122856001)(16586007)(81156014)(3846002)(4326008)(9746002)(69596002)(8676002)(58126008)(476003)(106356001)(478600001)(5660300001)(18370500001)(24400500001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4452; H:mlx.ziepe.ca; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM0PR05MB4452; 23:nmVHEBtHlBZZHn4+BqK3F1mKEas32ZGmFCJg6u1Iy?= =?us-ascii?Q?KMQ0ZJ9jR/9gk29GA4V6RGuOVDM+xaj59+/nblDmWwuRxAMW7UqybC0M5Eq8?= =?us-ascii?Q?STtAmRetJu02OM8aD8+gvZVeGCXGKZTf3V8QezJveTBMpGY9/Cw5onZs5a2z?= =?us-ascii?Q?V/usI8IsLC88YNZBJ/+DTCc0fEC6pkevK7c5cDq0S/+2fAYZUtgoyJVir8YK?= =?us-ascii?Q?CkG8/ioEnbo/IknXIL6Do2tCiSeNFAHaAnmW+yAozT4fGCOEWKg6GiTh8tdw?= =?us-ascii?Q?vtVYqGa6yNlFvuEM+GEku0/841ILtwof3xxQeZWfBMOaotJ9eMRaM0MEvTDl?= =?us-ascii?Q?f+O+GvQGkzTp3YrDNxYlVTOAM26SFkfecBv6yksCb8Lr7r0Wgmxfb5TxXgTa?= =?us-ascii?Q?a/p+W0z8bYy3w5axFwGs9e3rw3DW7es/W15JbOO9ftvYY0W+0ARcXEIOoNu0?= =?us-ascii?Q?810kd9EO6MBC2xk4ea/DkKW4gbHmp/1OMGd8PoILyJZKSp1HDerjR/xi6qVH?= =?us-ascii?Q?p3rftUEIbGpAyEJISIvsUHSsNEZIHf2tfJu4QHuTwaF9Ya6As+aEZVLMAOWS?= =?us-ascii?Q?taVq7m/27uu5Frpd0qdOrXIwRKxBT/hJRq2V0iHfUcY7yzGqKPYggZyYZUSo?= =?us-ascii?Q?5sNEWO4h1mNca2NRQYW+ZjeGUjbw0xQcHnDlMhysk/3jQ4XHfHBu/9PWx+os?= =?us-ascii?Q?2jYYAx98OJtzezGr4DbWWSF6l3XMaBFCt0K/ifGMA1KfftMPCoFsayl+d4kP?= =?us-ascii?Q?H2lt19VOmNqXl+aMaKmkx+Ui1x0/nbYLudDliPNvimRP5YYMpCkAUH6rRMeL?= =?us-ascii?Q?nF6zgY6Bux2XpyjehOej2X5EZS5/uhoNqzYu8q+x6CKBE5D31qDcQUihrDJO?= =?us-ascii?Q?hUoNVFN7v2GiOYKaeLg2sUS8N1ljw5xV6bmmBvpzCgrCoVM3Ux8AQtHoj/7z?= =?us-ascii?Q?5QZhpBczzC2NNpM7W+vxWCNxwpBt9qAd+PLpc/aBk7k/0dWCg1S/oQYbUfom?= =?us-ascii?Q?OF5wJWrYzPnqn7TVpECI++guOe3iAdx4ibR9afNlBeudq7+R7G+ImyDl1EK6?= =?us-ascii?Q?6rFr9g+yJ1gotiKJTpuMARS0yAwntKZxQafnRXgdPpUMAFnEmnBkhFI8UFLp?= =?us-ascii?Q?xw7GDLe1ttqScrEBGvh6p+6eph2XnZOlC2GRhi5HBoFlUMgXo7bHqXsEPxl5?= =?us-ascii?Q?g8uvG/PJVIqpTCEPcaJI9wLHon6FTUolk1iuQc6nOY+UP+gvQcCAKxz4tk5k?= =?us-ascii?Q?w5p+GArH7MjTEPbZzBAzR9a/jC/GeTxgrR8pe0BUmlTyjZOXnGf3xWQCP6aS?= =?us-ascii?Q?70oEqGmXwK6USCxlZY7QZfhtdUw7m0Eduf1K9IS8cfpk8U8bbckK+wjf0kre?= =?us-ascii?Q?V3nbfqHNFycEfWkcNtl4vpbblf7QW1VMW6VEkmAOuZxt1l5mDMAon750za1h?= =?us-ascii?Q?NE53kAoow=3D=3D?= X-Microsoft-Antispam-Message-Info: 5drl8o1kY4Zh6vLxpiok696L5wmSborkm08UEPGZPaV8o4i2NSnDkSgpH6EswpLGHj5xx/Yx0nwaDzASn/as0jSyB+BIjAXwseG8X3zgbWzJrgdn6MjH5FOVIm5r8drqN6JEQmCxgBGqDUF6H3pI6qMDZx+xqMlDH6R/Ja3W7GPy3Moz4wYvqTgpkaGoCFq6 X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4452; 6:i+V5nrPuqRHznZMhav51p78j+5ebTB0k9In1h+pwj3bYv2Ue2sko2CbEbRF5lSFNEpySFiZ6ZsPuQzecJ3QOgwep5oWeZzjiqFD7PvY+j8SeqcE7l01E4KGYubbiRFTXycdQmrE0CyeqfOgLHQmtkJXd3Pq3wnBpWSWnHI+tyKmCp1aYDKrbzpC23l6HGkNQ4PUUZlDAXhcpeNocKO1vDh8JigY5z+AC9AVVNYSBVOH81M64MHfr3UR+Wxc90bQXlzGmNN2/AcNhZ2Ntvgl6Viy2XL5PxGVlWddjgMm94NfiVJJRBjskwgTsTA0jYacKuMuVmgLp9rA7InwS+tkrTawgqnDQ8NRPXWKjlk3JbpstufnWRg47o4H8rV+PKdCncRlHkFdpWz9R64LRTGOPcnp3S2rAWpYdON9cJ9q3+zKhnIIbyYz/dVuY2Cgw9GM8Idn6vUWFzP7gcMkB3NPy3w==; 5:kMhY3swFfBSyZSUjJBQwV4LykOSdNTNPW15ayq2qolfQ4kneqvD5ldLEIWnje18HapOOcuLdVl69k/hlTfT0ZcKJrNJyyZWvfMm1PpKpXKBlN1IGsaJycvURiIYjY+AbeSKmOwKnNNNq4S5XfW1ZlTwLRxAzFQi0KBO4x0rFA2I=; 24:ZbuRfq43SBEVSs23mIWOBISYLsV9TtFPIdQWrZVwpoj9u4OGmj1ydE9UJOFX3opyWMo9zbuZ/P3riIBv9kfCcRc73mOUB/Ss0abIIkGhMHE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4452; 7:Q0M7D5DajoPSHRpCE6J+N8MWyaBppr4G+28UZUnwQH03eR14AQX3CXl0+C774ufbp+1WWkQ7w50g6DcForuaEmyt7vw8o18NpeDGQbfrFfi7iU8bIt7D6VVWyufE8b2VIsAt36zaCqOrqc3TYpE1hoYvFgjQRDI+m6Einb0R2Kegg2o+sDGSe2c/pm7+Jghsd1tTNvCPOocx4TyL3qjgKj8W1BYXFEV5GHyAujlDFWWyBhhnxNs8BgkscVqMDMto X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2018 22:44:01.1654 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 25e4d075-a15b-47ee-068a-08d594fd66b2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4452 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, Mar 28, 2018 at 12:58:36PM -0500, Steve Wise wrote: > > > On 3/28/2018 11:57 AM, Steve Wise wrote: > > > > On 3/28/2018 11:44 AM, Jason Gunthorpe wrote: > >> On Wed, Mar 28, 2018 at 10:40:56AM -0500, Steve Wise wrote: > >>> Doug/Jason, > >>> > >>> Seems like I got the authdates screwed up again. These show up in > >>> reverse order in patchwork. Would you like a respin? > >> I can manage.. > >> > >>> These two will enable me to finalize the associated rdma tool submission. > >> I can't find a user API user of this though? Is netlink introducing > >> the first user? I'm confused. I thought umca used this > >> someplace. Maybe I just can't find it today. > > Hrm... you're right. I don't see any code using rdma_ucm_create_id. I > > do see ucma_abi_create_id from rdma_cma_abi.h used in > > librdmacm:rdma_create_id2() called by rdma_create_id() . And > > ucma_abi_create_id has a ps field. So perhaps the correct header file > > is rdma_cma_abi.h? But I don't see that file in the kernel at all. > > > > /me confused. > > The kernel side, in ucma.c, is using struct rdma_ucm_create_id to parse > the u->k RDMA_USER_CM_CMD_CREATE_ID command. So its UAPI header is > include/uapi/rdma/rdma_user_cm.h. The user side is using struct > ucma_abi_create_id from rdma-core/librdmacm/rdma_cma_abi.h. > > Jason, how should I proceed? I grabbed the patch but revised it so someone else might be able to figure this out.. And all the changes to rename to rdma_ucm_port_space Jason --- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/include/uapi/rdma/rdma_user_cm.h +++ b/include/uapi/rdma/rdma_user_cm.h @@ -70,6 +70,14 @@ enum { RDMA_USER_CM_CMD_JOIN_MCAST }; +/* See IBTA Annex A11, servies ID bytes 4 & 5 */ +enum rdma_ucm_port_space { + RDMA_PS_IPOIB = 0x0002, + RDMA_PS_IB = 0x013F, + RDMA_PS_TCP = 0x0106, + RDMA_PS_UDP = 0x0111, +}; + /* * command ABI structures. */ @@ -82,7 +90,7 @@ struct rdma_ucm_cmd_hdr { struct rdma_ucm_create_id { __aligned_u64 uid; __aligned_u64 response; - __u16 ps; + __u16 ps; /* use enum rdma_port_space */ __u8 qp_type; __u8 reserved[5]; };