diff mbox

IB/core: Remove redundant return

Message ID 20180510063243.5706-1-yuval.shaia@oracle.com (mailing list archive)
State Accepted
Delegated to: Jason Gunthorpe
Headers show

Commit Message

Yuval Shaia May 10, 2018, 6:32 a.m. UTC
"return" statement at the end of void function is redundant, removing
it.

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
 drivers/infiniband/core/umem.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Zhu Yanjun May 10, 2018, 6:56 a.m. UTC | #1
On 2018/5/10 14:32, Yuval Shaia wrote:
> "return" statement at the end of void function is redundant, removing
> it.
>
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>

Reviewed-by: Zhu Yanjun <yanjun.zhu@oracle.com>

> ---
>   drivers/infiniband/core/umem.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c
> index 9a4e899d94b3..b3cdc099d32a 100644
> --- a/drivers/infiniband/core/umem.c
> +++ b/drivers/infiniband/core/umem.c
> @@ -64,8 +64,6 @@ static void __ib_umem_release(struct ib_device *dev, struct ib_umem *umem, int d
>   	}
>   
>   	sg_free_table(&umem->sg_head);
> -	return;
> -
>   }
>   
>   /**

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Qing Huang May 10, 2018, 6:16 p.m. UTC | #2
Sounds good to me.

Reviewed-by: Qing Huang <qing.huang@oracle.com>


On 5/9/2018 11:32 PM, Yuval Shaia wrote:
> "return" statement at the end of void function is redundant, removing
> it.
>
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> ---
>   drivers/infiniband/core/umem.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c
> index 9a4e899d94b3..b3cdc099d32a 100644
> --- a/drivers/infiniband/core/umem.c
> +++ b/drivers/infiniband/core/umem.c
> @@ -64,8 +64,6 @@ static void __ib_umem_release(struct ib_device *dev, struct ib_umem *umem, int d
>   	}
>   
>   	sg_free_table(&umem->sg_head);
> -	return;
> -
>   }
>   
>   /**

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jason Gunthorpe May 15, 2018, 11:15 p.m. UTC | #3
On Thu, May 10, 2018 at 09:32:43AM +0300, Yuval Shaia wrote:
> "return" statement at the end of void function is redundant, removing
> it.
> 
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> Reviewed-by: Zhu Yanjun <yanjun.zhu@oracle.com>
> Reviewed-by: Qing Huang <qing.huang@oracle.com>
> ---
>  drivers/infiniband/core/umem.c | 2 --
>  1 file changed, 2 deletions(-)

Applied to for-next, thanks

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c
index 9a4e899d94b3..b3cdc099d32a 100644
--- a/drivers/infiniband/core/umem.c
+++ b/drivers/infiniband/core/umem.c
@@ -64,8 +64,6 @@  static void __ib_umem_release(struct ib_device *dev, struct ib_umem *umem, int d
 	}
 
 	sg_free_table(&umem->sg_head);
-	return;
-
 }
 
 /**