From patchwork Wed Jul 11 17:55:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 10520261 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8E18A6028E for ; Wed, 11 Jul 2018 17:56:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 81E3D296D5 for ; Wed, 11 Jul 2018 17:56:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 75BAB296E1; Wed, 11 Jul 2018 17:56:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1DA6B2972C for ; Wed, 11 Jul 2018 17:56:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726450AbeGKSB0 (ORCPT ); Wed, 11 Jul 2018 14:01:26 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:52292 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389054AbeGKSB0 (ORCPT ); Wed, 11 Jul 2018 14:01:26 -0400 Received: by mail-wm0-f68.google.com with SMTP id w16-v6so3208242wmc.2 for ; Wed, 11 Jul 2018 10:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=smVf7gMh+xzQH6EDHI8Pyb/Bac2UY7LHUZjgg74h7YY=; b=CF/LEAqtiemqOmRCSfRmYO3mzyUTWq6/I0Jzoq0mEyCXafkVg9CLJzjXBMpLd5fp5x BHylVipn8ODJGREgJKUMkfue/e8Cdi/Q2qIhvBshtyZn0+Ztvga+eiJiUo+0VwpiXo+0 QzXnzCFq68Ivu4uYnURbUdJLzYHOsj7GSUmbPPRlrE+QuqaBuZontz0SMhjs2YS4Nqjn hmZh4EGnzI9PJP7nIn+HM1ml3yCLe3Zpeh5F2f/jKqWBdaxayr8DIaNW3SsQ28dmfUiU aJzYZhyvq32pjKE3OOujhAmiDWkYos1042rViNDY65humy3fVGqrYHifx8V632YaDvNf 2Tjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=smVf7gMh+xzQH6EDHI8Pyb/Bac2UY7LHUZjgg74h7YY=; b=q+Eo0Nq1YENUWR+2bvWeIr8z3G+4nIok2MVJV37V9upvjdfyiqVmIPG8xqW6Xkg6wB /oF963yNXTQoUjuhKgCPVdobYMVWUnWjTcYHvxr6LRvwyDapbt61qzLox4ALpfshybhU sSFFgNlKmUHvCsL7WFRCn2FYhvhgX0Me7/VZQfzOPiBcpANDLVa/MuIM/CpfKAZGCU6b aZ+hkcOmZTyRDCYzKRyIbeHRSeVe6pX4mC2QMNkum00FwqTe328dnMGzPzgBmhSpgbhl kWu1fQGeI6BsWVSMyq5kJozeThaPmQmO449Ruo/EPJ+u/qUh0zfLP6omQUhk/iUdAWDU W6bA== X-Gm-Message-State: AOUpUlGC+zvn6/L2nMuNd4dEWi/YjEDIrSAg8bvAEjbCs4hOiiq/bswo z/1yNKBa8buB44zHilFacx8= X-Google-Smtp-Source: AAOMgpc2ryU4UvZ0KqbFGKyM+dE5hZsjQ6h2zAVj5ksysSTprGMX1InC8Ck82Qu5ZHSRaNnFtE0YFg== X-Received: by 2002:a1c:6a0b:: with SMTP id f11-v6mr10110335wmc.107.1531331758347; Wed, 11 Jul 2018 10:55:58 -0700 (PDT) Received: from localhost.localdomain (bzq-109-67-23-64.red.bezeqint.net. [109.67.23.64]) by smtp.gmail.com with ESMTPSA id p1-v6sm3592284wrp.63.2018.07.11.10.55.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Jul 2018 10:55:57 -0700 (PDT) From: Kamal Heib To: Doug Ledford , Jason Gunthorpe Cc: linux-rdma@vger.kernel.org, Kamal Heib Subject: [PATCH rdma-next] RDMA/ocrdma: Remove ocrdma_modify_ah() Date: Wed, 11 Jul 2018 20:55:40 +0300 Message-Id: <20180711175540.12725-1-kamalheib1@gmail.com> X-Mailer: git-send-email 2.14.4 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The rdma core is taking care of return the right error code when modify_ah() callback isn't supported by the driver provider. Fixes: fe2caefcdf58 ('RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter') Signed-off-by: Kamal Heib --- drivers/infiniband/hw/ocrdma/ocrdma_ah.c | 6 ------ drivers/infiniband/hw/ocrdma/ocrdma_ah.h | 1 - drivers/infiniband/hw/ocrdma/ocrdma_main.c | 1 - 3 files changed, 8 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_ah.c b/drivers/infiniband/hw/ocrdma/ocrdma_ah.c index 8cc9459a9f9b..58188fe5aed2 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_ah.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_ah.c @@ -254,12 +254,6 @@ int ocrdma_query_ah(struct ib_ah *ibah, struct rdma_ah_attr *attr) return 0; } -int ocrdma_modify_ah(struct ib_ah *ibah, struct rdma_ah_attr *attr) -{ - /* modify_ah is unsupported */ - return -ENOSYS; -} - int ocrdma_process_mad(struct ib_device *ibdev, int process_mad_flags, u8 port_num, diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_ah.h b/drivers/infiniband/hw/ocrdma/ocrdma_ah.h index 1a65c47945aa..c0c32c9b80ae 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_ah.h +++ b/drivers/infiniband/hw/ocrdma/ocrdma_ah.h @@ -55,7 +55,6 @@ struct ib_ah *ocrdma_create_ah(struct ib_pd *pd, struct rdma_ah_attr *ah_attr, struct ib_udata *udata); int ocrdma_destroy_ah(struct ib_ah *ah); int ocrdma_query_ah(struct ib_ah *ah, struct rdma_ah_attr *ah_attr); -int ocrdma_modify_ah(struct ib_ah *ah, struct rdma_ah_attr *ah_attr); int ocrdma_process_mad(struct ib_device *, int process_mad_flags, diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_main.c b/drivers/infiniband/hw/ocrdma/ocrdma_main.c index 5962c0ed9847..7832ee3e0c84 100644 --- a/drivers/infiniband/hw/ocrdma/ocrdma_main.c +++ b/drivers/infiniband/hw/ocrdma/ocrdma_main.c @@ -176,7 +176,6 @@ static int ocrdma_register_device(struct ocrdma_dev *dev) dev->ibdev.create_ah = ocrdma_create_ah; dev->ibdev.destroy_ah = ocrdma_destroy_ah; dev->ibdev.query_ah = ocrdma_query_ah; - dev->ibdev.modify_ah = ocrdma_modify_ah; dev->ibdev.poll_cq = ocrdma_poll_cq; dev->ibdev.post_send = ocrdma_post_send;