From patchwork Wed Jul 18 21:05:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamal Heib X-Patchwork-Id: 10533269 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 22364600D0 for ; Wed, 18 Jul 2018 21:05:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 122AA29A7A for ; Wed, 18 Jul 2018 21:05:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 05BD429AF9; Wed, 18 Jul 2018 21:05:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A1CF629A7A for ; Wed, 18 Jul 2018 21:05:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726923AbeGRVp3 (ORCPT ); Wed, 18 Jul 2018 17:45:29 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:38374 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726821AbeGRVp3 (ORCPT ); Wed, 18 Jul 2018 17:45:29 -0400 Received: by mail-wm0-f67.google.com with SMTP id 69-v6so4189239wmf.3 for ; Wed, 18 Jul 2018 14:05:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=hHT7dLDsI+tJcxNnDDJL9/6RfUfkC+X9td68OJFg2i4=; b=gA+V/k81iD0WdKh8zWwf1YnkKMvBSsTfgTzDjae8MFvX41AeN0/zMZzqdmcjtvH0TS wc515grL0tyBDnmyEbBGTC7v3q7Wh1pwkrXnhhmr7L036J+H7wqJemrEYpdnsh4S3/Tk 0CLVEpYgIH1csGjFZZp1XQgLulbEURixSYnHwWWqy30hfUj6lR9EbYV2hAsYkHDIlNno HigNmM4tcB2F7ijExwRSNw0+9HGHahylSJhxzewWMYAjZjH7KG5y3JgRftLVzj30zD43 eJe6sDnwjD0Hqn0fqu/8dDr4gSGDM7UWnzosT+3XGa7wRmGL9y82NCIDRSM+lV4RZoTt e3QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=hHT7dLDsI+tJcxNnDDJL9/6RfUfkC+X9td68OJFg2i4=; b=AOb+UlceSJaij90uLWJ6zmF/2qkgGlliY3EoErHHq7Opz2WwK0LFP0DhUkiCQBbyS8 tdv78ego2TE+tDY2jAlCIjxWuX1SCqZoSp2OoypDXsvCwcnki1pgnktrIurwScIpay5q 4F/tIU0twFMRMzKZUrON6c2kSltS4c0pTMJyXxBehNfY1RG1BUAez9l7IE70ZCxdFDc8 BpXb8iHw/Q7qRVdZqlr7z71XxD1VGg1xmUSe3a+FvdZ/sYMIh23ETUHpkbsut5UIIvFs zQScVatrjoHdZj+Q/7lFpDaZMK8QsCEEQpkkclE5J/Ak60uujrTPwxwv3CIjr96O3EFw 62EQ== X-Gm-Message-State: AOUpUlHwQSDlQNekObbfsowca1IxJLqfidm9j13XYYpOPDXZYGfDpYii BarETiE6Wjr2MaVclRZMVBU= X-Google-Smtp-Source: AAOMgpdEQMwTl4vL2x9zqUJ/DtU9YAu9cJc7eCL7ULjH2V77VcYpN6BzyS48kVvfyhmVrRuy3I/TeQ== X-Received: by 2002:a1c:ea53:: with SMTP id i80-v6mr2732055wmh.113.1531947946822; Wed, 18 Jul 2018 14:05:46 -0700 (PDT) Received: from localhost.localdomain (bzq-109-67-23-64.red.bezeqint.net. [109.67.23.64]) by smtp.gmail.com with ESMTPSA id x7-v6sm6473086wrr.95.2018.07.18.14.05.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Jul 2018 14:05:46 -0700 (PDT) From: Kamal Heib To: Leon Romanovsky , Doug Ledford , Jason Gunthorpe Cc: linux-rdma@vger.kernel.org, Kamal Heib Subject: [PATCH for-next] RDMA/mlx5: Remove set but not used variables Date: Thu, 19 Jul 2018 00:05:32 +0300 Message-Id: <20180718210532.14625-1-kamalheib1@gmail.com> X-Mailer: git-send-email 2.14.4 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove "uctx" and "pa" variables that were set but not used. Fixes: a8b92ca1b0e5 ("IB/mlx5: Introduce DEVX") Fixes: 8f0622873358 ("RDMA/mlx5: Remove debug prints of VMA pointers") Signed-off-by: Kamal Heib Acked-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/devx.c | 2 -- drivers/infiniband/hw/mlx5/main.c | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/devx.c b/drivers/infiniband/hw/mlx5/devx.c index 60ac1fbe940e..7f9d73b03421 100644 --- a/drivers/infiniband/hw/mlx5/devx.c +++ b/drivers/infiniband/hw/mlx5/devx.c @@ -50,11 +50,9 @@ int mlx5_ib_devx_create(struct mlx5_ib_dev *dev, struct mlx5_ib_ucontext *contex u32 in[MLX5_ST_SZ_DW(create_uctx_in)] = {0}; u32 out[MLX5_ST_SZ_DW(general_obj_out_cmd_hdr)] = {0}; u64 general_obj_types; - void *uctx; void *hdr; int err; - uctx = MLX5_ADDR_OF(create_uctx_in, in, uctx); hdr = MLX5_ADDR_OF(create_uctx_in, in, hdr); general_obj_types = MLX5_CAP_GEN_64(dev->mdev, general_obj_types); diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c index b7f94bc3811a..d4d894e9f942 100644 --- a/drivers/infiniband/hw/mlx5/main.c +++ b/drivers/infiniband/hw/mlx5/main.c @@ -2041,7 +2041,7 @@ static int uar_mmap(struct mlx5_ib_dev *dev, enum mlx5_ib_mmap_cmd cmd, struct mlx5_bfreg_info *bfregi = &context->bfregi; int err; unsigned long idx; - phys_addr_t pfn, pa; + phys_addr_t pfn; pgprot_t prot; u32 bfreg_dyn_idx = 0; u32 uar_index; @@ -2132,8 +2132,6 @@ static int uar_mmap(struct mlx5_ib_dev *dev, enum mlx5_ib_mmap_cmd cmd, goto err; } - pa = pfn << PAGE_SHIFT; - err = mlx5_ib_set_vma_data(vma, context); if (err) goto err;