From patchwork Tue Aug 28 01:48:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honggang LI X-Patchwork-Id: 10577749 X-Patchwork-Delegate: hal@mellanox.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 019F21390 for ; Tue, 28 Aug 2018 01:49:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E734F299F1 for ; Tue, 28 Aug 2018 01:49:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DB8FC29A20; Tue, 28 Aug 2018 01:49:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 84C58299F1 for ; Tue, 28 Aug 2018 01:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726610AbeH1FiS (ORCPT ); Tue, 28 Aug 2018 01:38:18 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40284 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725724AbeH1FiS (ORCPT ); Tue, 28 Aug 2018 01:38:18 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D323220E19; Tue, 28 Aug 2018 01:49:03 +0000 (UTC) Received: from lhg.nay.redhat.com (unknown [10.66.129.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F6E82166B41; Tue, 28 Aug 2018 01:49:01 +0000 (UTC) From: Honggang LI To: hal@dev.mellanox.co.il Cc: linux-rdma@vger.kernel.org, Honggang Li Subject: [PATCH 4/5] osmtest.c: osmtest_parse_port fix resource leak in error path Date: Tue, 28 Aug 2018 09:48:33 +0800 Message-Id: <20180828014834.3046-4-honli@redhat.com> In-Reply-To: <20180828014834.3046-3-honli@redhat.com> References: <20180828014834.3046-1-honli@redhat.com> <20180828014834.3046-2-honli@redhat.com> <20180828014834.3046-3-honli@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 28 Aug 2018 01:49:03 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Tue, 28 Aug 2018 01:49:03 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'honli@redhat.com' RCPT:'' Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Honggang Li Issue was found by Coverity. Error: RESOURCE_LEAK (CWE-772): [#def12] opensm-3.3.20/osmtest/osmtest.c:6588: alloc_fn: Storage is returned from allocation function "port_new". opensm-3.3.20/osmtest/include/osmtest_subnet.h:173:2: alloc_fn: Storage is returned from allocation function "malloc". opensm-3.3.20/osmtest/include/osmtest_subnet.h:173:2: var_assign: Assigning: "p_obj" = "malloc(216UL)". opensm-3.3.20/osmtest/include/osmtest_subnet.h:175:3: noescape: Resource "p_obj" is not freed or pointed-to in function "memset". [Note: The source code implementation of the function has been overridden by a builtin model.] opensm-3.3.20/osmtest/include/osmtest_subnet.h:176:2: return_alloc: Returning allocated memory "p_obj". opensm-3.3.20/osmtest/osmtest.c:6588: var_assign: Assigning: "p_port" = storage returned from "port_new()". opensm-3.3.20/osmtest/osmtest.c:6977: leaked_storage: Variable "p_port" going out of scope leaks the storage it points to. |# 6975| Exit: |# 6976| OSM_LOG_EXIT(&p_osmt->log); |# 6977|-> return (status); |# 6978| } |# 6979| Signed-off-by: Honggang Li --- osmtest/osmtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/osmtest/osmtest.c b/osmtest/osmtest.c index 812563c1..e6f91a81 100644 --- a/osmtest/osmtest.c +++ b/osmtest/osmtest.c @@ -6599,6 +6599,7 @@ osmtest_parse_port(IN osmtest_t * const p_osmt, OSM_LOG(&p_osmt->log, OSM_LOG_ERROR, "ERR 0123: " "Unexpected end of file\n"); status = IB_ERROR; + port_delete(p_port); goto Exit; }