From patchwork Thu Sep 20 16:39:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 10608195 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D9F31174F for ; Thu, 20 Sep 2018 16:39:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C99B62E141 for ; Thu, 20 Sep 2018 16:39:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BE6412E14C; Thu, 20 Sep 2018 16:39:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 696812E143 for ; Thu, 20 Sep 2018 16:39:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731454AbeITWXp (ORCPT ); Thu, 20 Sep 2018 18:23:45 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:35145 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730949AbeITWXo (ORCPT ); Thu, 20 Sep 2018 18:23:44 -0400 Received: by mail-io1-f66.google.com with SMTP id w11-v6so8141851iob.2 for ; Thu, 20 Sep 2018 09:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zCZL9tmRKE3SJW7DsF/OmdXpCERXgu7407n6nFNtgpk=; b=ASkxwGNdPC5HT8CsTgXlUAm0B09jp1gBCzacMWWpf+chrSg56cwl3PPYP6C25wjR7m 9mJ6mUvjI+iOI8Zoybt2keZenshPHlUMcVvwLxOxdBNrCd7dVouO0/GA+Yr97pzEIiRe IIv2fa7iyPC6JxysuWrhStrbzqddnv1bsdP+hzE0G+O4v/P9MDYAmPRkAjkBPQ/YyFKy MWELtbAvGZmSu27xN0mUvwU4p6aLAQIkSABtP8fxVxAYr422HCJCHa2cKXVPtTw6LJ1h NmiUUHP7FiayVT+i+cBfpKKcrK4xV6puwJvm2aQADiXZjuWZxLwv/0a6bKAtmIP9CcfP FxaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zCZL9tmRKE3SJW7DsF/OmdXpCERXgu7407n6nFNtgpk=; b=F478qgG299tmaE6eyqbrM6jzZLIeKusaq0hc9SyNY8RTSzU+1r1mOnm5pzU+HZpGo9 xqlT4bBVizhihl+iyLd73vhC5ul1Un0RT5BkJ73zf56rSXQfzfWx/rEi+vHec0VJmjYy 648Y310+iTORto6kGf6f2qeWKECEAx32M6VY6jFNpt6KIAR6e5AFx4a0lMIxfZl/l0c0 ZYVu3nUFfR0sYw04lE2mafkHEu/jYQ1IUU6fDM/M0sIuQZTRNEk3PUFwsL6VY2tQSc8l FoxObMwliiUzjH5p5fjdcLcnP/Dlb4Bj8ixSIrTeN416zamLKUIZ/COu/XK8noMaZ+Id 6l6Q== X-Gm-Message-State: APzg51CbGF23y04cum9bFIf6sBSx+vH2NsHPhrH2MnIOD7/8zQYlxTCw 0UGXILrbTaja6Lg3gpt8J7u0fca/Gb4= X-Google-Smtp-Source: ANB0VdZM8jn/BFGu55XA1n90AJOY+XHxcLvwFCFso74y9Hq+sXLk3CmWeQCwy5Yw7FvFQVyouvhK7g== X-Received: by 2002:a5e:d612:: with SMTP id w18-v6mr32224939iom.54.1537461564507; Thu, 20 Sep 2018 09:39:24 -0700 (PDT) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id a11-v6sm1015800ita.21.2018.09.20.09.39.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Sep 2018 09:39:22 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1g31z2-0001AX-QU; Thu, 20 Sep 2018 10:39:16 -0600 From: Jason Gunthorpe To: linux-rdma@vger.kernel.org Cc: Jason Gunthorpe Subject: [PATCH rdma-core 5/8] pkg-config: Move Libs.private to after Libs Date: Thu, 20 Sep 2018 10:39:07 -0600 Message-Id: <20180920163910.4403-6-jgg@ziepe.ca> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20180920163910.4403-1-jgg@ziepe.ca> References: <20180920163910.4403-1-jgg@ziepe.ca> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jason Gunthorpe Apparently definitions are ordered in pkg-config, and the linker requires libraries to be sorted dependent-last. Otherwise static linking fails because pthread is before ibverbs in the linker line. Fixes: df5fe3c2fa9d ("Generate and install pkgconfig files for libs") Signed-off-by: Jason Gunthorpe --- buildlib/template.pc.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/buildlib/template.pc.in b/buildlib/template.pc.in index 99a798464abd03..618840c8cfd555 100644 --- a/buildlib/template.pc.in +++ b/buildlib/template.pc.in @@ -7,7 +7,7 @@ Name: lib@PC_LIB_NAME@ Description: RDMA Core Userspace Library URL: https://github.com/linux-rdma/rdma-core Version: @PC_VERSION@ -Libs.private: @PC_LIB_PRIVATE@ Libs: -L${libdir} -l@PC_LIB_NAME@ @PC_RPATH@ +Libs.private: @PC_LIB_PRIVATE@ Requires.private: @PC_REQUIRES_PRIVATE@ Cflags: -I${includedir}