From patchwork Tue Dec 11 23:36:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagi Grimberg X-Patchwork-Id: 10725289 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AD1471869 for ; Tue, 11 Dec 2018 23:37:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D85F2B4A4 for ; Tue, 11 Dec 2018 23:37:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 918782B61A; Tue, 11 Dec 2018 23:37:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 466C22B56E for ; Tue, 11 Dec 2018 23:37:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726230AbeLKXhB (ORCPT ); Tue, 11 Dec 2018 18:37:01 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:37382 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbeLKXhB (ORCPT ); Tue, 11 Dec 2018 18:37:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=QDX1HDPRZDcH1UGedTfNRuSknUh2xNTsqrVUS3lY3bs=; b=NYXgIPF8Gipwgq5PYBDLQeOGc 3lLkXe72BRMbzhmKjUh3tuDeaHbLze7SDceG7Bm2dESCvAmQ0u8LRBoTaHenDfP7g3K5sS/EQLuYg J7CdTG09yltoOMJ+grh7qyVb30Fm0ruokVT3j/XoAbQb2aE4TjDBwFFhS4sh1ssZwoBGp/N5XahvA F42iLMup+GE0j2cdq3wIYng8A1BhmQnURaR4AcGxPqmm1P9VJrQf0UytTA+V4+UyOjeWbOcImOiJy 4h85qDJdeCG1rRrdiac+Jl3GrcD6ODr9DhjAIBgjB/MyoO5URm7ZToR2Ka4OVAhtlNpaTqttK4pVU oT8p2hWfQ==; Received: from [2600:1700:65a0:78e0:514:7862:1503:8e4d] (helo=sagi-Latitude-E7470.lbits) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gWraE-0003uQ-67; Tue, 11 Dec 2018 23:36:58 +0000 From: Sagi Grimberg To: linux-nvme@lists.infradead.org Cc: linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, Christoph Hellwig , Keith Busch Subject: [PATCH RFC 4/4] nvme-multipath: disable polling for underlying namespace request queue Date: Tue, 11 Dec 2018 15:36:51 -0800 Message-Id: <20181211233652.9705-5-sagi@grimberg.me> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181211233652.9705-1-sagi@grimberg.me> References: <20181211233652.9705-1-sagi@grimberg.me> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since the multipath device does not support polling (yet) we cannot pass requests to the polling queue map as those will not generate interrupt so we cannot reap the completion. Signed-off-by: Sagi Grimberg --- drivers/nvme/host/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index f90576862736..511d399a6002 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -1547,6 +1547,8 @@ static void __nvme_revalidate_disk(struct gendisk *disk, struct nvme_id_ns *id) if (ns->head->disk) { nvme_update_disk_info(ns->head->disk, ns, id); blk_queue_stack_limits(ns->head->disk->queue, ns->queue); + /* XXX: multipath device does not support polling for now... */ + blk_queue_flag_clear(QUEUE_FLAG_POLL, ns->queue); } #endif }