From patchwork Thu Dec 13 06:38:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagi Grimberg X-Patchwork-Id: 10728099 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5538D1759 for ; Thu, 13 Dec 2018 06:38:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 422C82A192 for ; Thu, 13 Dec 2018 06:38:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 367432A508; Thu, 13 Dec 2018 06:38:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D4C862A192 for ; Thu, 13 Dec 2018 06:38:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726945AbeLMGiX (ORCPT ); Thu, 13 Dec 2018 01:38:23 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:35082 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726654AbeLMGiX (ORCPT ); Thu, 13 Dec 2018 01:38:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=K3HtS4PLgyfnrP333MfqkULqBfPg0tDDpqVmKCEk4XI=; b=EXQHoE1y214RSbhauP/KRYc/l n5e18ExxQ++wegVkXH2PS504gyn7Fa8OEkW1y3hYqLJls7OdRrVUcbaqVG8RGrfedk777STn3KvwB KawnVqmSNtCltL2I0qA1/6UvG82ZBZsJtucYk/k59IKV+CQxwSHtps1UANFrzFLolxsGZKhNgm3Wp 8M3P7hmHYjkYSrKjsW+e/P00j3MY7L6oTt1P2nkFAJyc/+lBx3kA/Gg+KZ17dzXvOwBoaJGmtjUZP LunYYio5/nWPJZWCz+9w0wStiBsBorlMLyHMlO1U2DTpSqY6fZ9wTdrFo+zEobc/6KNRKLnvDp9+k PSTlKbTTA==; Received: from [2601:647:4800:973f:7888:b13c:bff:87b0] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gXKdZ-0006LR-Tj; Thu, 13 Dec 2018 06:38:21 +0000 From: Sagi Grimberg To: linux-nvme@lists.infradead.org Cc: linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, Christoph Hellwig , Keith Busch , Jens Axboe Subject: [PATCH v2 6/6] nvme-multipath: disable polling for underlying namespace request queue Date: Wed, 12 Dec 2018 22:38:18 -0800 Message-Id: <20181213063819.13614-7-sagi@grimberg.me> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181213063819.13614-1-sagi@grimberg.me> References: <20181213063819.13614-1-sagi@grimberg.me> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since the multipath device does not support polling (yet) we cannot pass requests to the polling queue map as those will not generate interrupt so we cannot reap the completion. Signed-off-by: Sagi Grimberg Signed-off-by: Christoph Hellwig Signed-off-by: Steve Wise --- drivers/nvme/host/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index eb1c10b0eaf0..5a6c29ee669c 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -1550,6 +1550,8 @@ static void __nvme_revalidate_disk(struct gendisk *disk, struct nvme_id_ns *id) if (ns->head->disk) { nvme_update_disk_info(ns->head->disk, ns, id); blk_queue_stack_limits(ns->head->disk->queue, ns->queue); + /* multipath device does not support polling */ + blk_queue_flag_clear(QUEUE_FLAG_POLL, ns->queue); } #endif }