From patchwork Wed Jan 2 13:13:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honggang LI X-Patchwork-Id: 10746361 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D392B91E for ; Wed, 2 Jan 2019 13:14:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C3D1928857 for ; Wed, 2 Jan 2019 13:14:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B53A72884B; Wed, 2 Jan 2019 13:14:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4768E2884B for ; Wed, 2 Jan 2019 13:14:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729923AbfABNO4 (ORCPT ); Wed, 2 Jan 2019 08:14:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60210 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729901AbfABNO4 (ORCPT ); Wed, 2 Jan 2019 08:14:56 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B3952C0669D2; Wed, 2 Jan 2019 13:14:55 +0000 (UTC) Received: from localhost (ovpn-12-97.pek2.redhat.com [10.72.12.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E37221001F4A; Wed, 2 Jan 2019 13:14:54 +0000 (UTC) From: Honggang Li To: hal@dev.mellanox.co.il Cc: linux-rdma@vger.kernel.org, Honggang Li Subject: [ibsim patch 20/23] ibsim.spec.in: Improve the spec file as Fedora package guide requires Date: Wed, 2 Jan 2019 21:13:15 +0800 Message-Id: <20190102131318.5765-20-honli@redhat.com> In-Reply-To: <20190102131318.5765-1-honli@redhat.com> References: <20190102131318.5765-1-honli@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 02 Jan 2019 13:14:55 +0000 (UTC) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP - Delete the 'Group' tag as it is outdated. - Delete the 'BuildRoot' tag as it is unnecessary. - Update the 'Source' and 'Url' tag as ibsim now hosted in github. - The 'description' section is too long. Each line should less than 80 characters. - Delete the environment variables in 'build' section, as they use the default values. - Simplify the 'install' section. - The 'clean' section is unnecessary. - The default 'defattr' tag is unnecessary. - ibsim should own the umad2sim directory too. - Move 'COPYING' file into the license tag. Signed-off-by: Honggang Li --- ibsim.spec.in | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/ibsim.spec.in b/ibsim.spec.in index 424b2e01ed60..d1936a300d86 100644 --- a/ibsim.spec.in +++ b/ibsim.spec.in @@ -7,14 +7,13 @@ Name: ibsim Version: @VERSION@ Release: %rel%{?dist} License: GPLv2 or BSD -Group: System Environment/Libraries -BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) -Source: http://www.openfabrics.org/downloads/management/@TARBALL@ -Url: http://openfabrics.org/ +Source: https://github.com/linux-rdma/ibsim/archive/@TARBALL@ +Url: https://github.com/linux-rdma/ibsim BuildRequires: libibmad-devel, libibumad-devel, gcc %description -ibsim provides simulation of infiniband fabric for using with OFA OpenSM, diagnostic and management tools. +ibsim provides simulation of infiniband fabric for using with +OFA OpenSM, diagnostic and management tools. %prep %setup -q @@ -22,20 +21,15 @@ ibsim provides simulation of infiniband fabric for using with OFA OpenSM, diagno %build export CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}" export LDFLAGS="${LDFLAGS:-${RPM_OPT_FLAGS}}" -make prefix=%_prefix libpath=%_libdir binpath=%_bindir %{?_smp_mflags} +make %{?_smp_mflags} %install -export CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}" -export LDFLAGS="${LDFLAGS:-${RPM_OPT_FLAGS}}" make DESTDIR=${RPM_BUILD_ROOT} prefix=%_prefix libpath=%_libdir binpath=%_bindir install -%clean -rm -rf $RPM_BUILD_ROOT - %files -%defattr(-,root,root) -%{_libdir}/umad2sim/libumad2sim*.so* +%{_libdir}/umad2sim/ %{_bindir}/ibsim -%doc README COPYING TODO net-examples scripts +%doc README TODO net-examples scripts +%license COPYING %changelog