From patchwork Sat Jan 12 02:35:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 10760877 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6257614E5 for ; Sat, 12 Jan 2019 02:35:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5383F2A136 for ; Sat, 12 Jan 2019 02:35:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 47D632A13B; Sat, 12 Jan 2019 02:35:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E82182A136 for ; Sat, 12 Jan 2019 02:35:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726543AbfALCfT (ORCPT ); Fri, 11 Jan 2019 21:35:19 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:35872 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726528AbfALCfT (ORCPT ); Fri, 11 Jan 2019 21:35:19 -0500 Received: by mail-pf1-f194.google.com with SMTP id b85so7797348pfc.3 for ; Fri, 11 Jan 2019 18:35:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CwxpL4Kac8nLfVP3A7AzR/+Vb+e+6c7YmdP8C2iYzaI=; b=d0m+MmR9jCQbmDpqECLWESoWqnTEUtVFbRmKG69UYoWgK0dpJJE9dLcaWdVKvnnw1S 0OD/XQvpqeidDhxUWOojh+sWs8FXPHaIZ7sDPbov8r8BtUqSaXeatv8Erat+CXZtogxw VBMnkVXvyexlnIsO3dD/d6UI5U8B5YfuD7vYF6nJVucNPAgaMcgnlki/j0WvoGABk4j+ 126EXruqPo5VoxDMu8pEmYi44oTs1+pECptu8G1qhREUPY0nBD2SofZKv0ZkqfXUB0bu 0/3vxr501JfBdFgOg6b9e6BL2RySFvN3ISVF3c4FVxdzsAX+fhF8ZJX3JchHVqSG8U7W 9X7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CwxpL4Kac8nLfVP3A7AzR/+Vb+e+6c7YmdP8C2iYzaI=; b=kFCxDrkVz24AwOuwL/hLpMwHjSV/WFtntv1NwVaiEuhPDljoi4Jp040LToM2rVYJXn hzbuLF8wL5jFmLE3Fe+LySiFGv4GkBddUYmS7Ol46ZIExuSRKoqGrLXpVQ2HJF/Vusek Gvh3bPSasVF7MN51JZv0RpyGhd99X2mbcNA847jkekDY7Z3GBdd+2ZXTnAMuGedY9H/O agqdDdAjWeI6gVp848J/F/fWz1YfmRzibQLP42hSdvT0QNH9QdFiqLb44H4ERHfLSIc4 kUF9uNK+pZDcp5S/SGLdhmm/eqqOFMZ09Fnqchi318sJMvL/q5d+XTyvspjD+NsynRyY 75mg== X-Gm-Message-State: AJcUukdVJ4Zx+HYQfQ9hyh2j8CrS9rbDUVioHwGWlOptPLuaeKKrWf+f hlBO5nQ86jGpMsezuhdLvmlSLaqGzXE= X-Google-Smtp-Source: ALg8bN7EjTFfVftSLf2yvqeOTQ4c57v2VRtCXQRwgX948Qu12pzrmo9d6qxPcxBbuC3BmriHjyIP1Q== X-Received: by 2002:a62:b511:: with SMTP id y17mr17061719pfe.199.1547260518322; Fri, 11 Jan 2019 18:35:18 -0800 (PST) Received: from ziepe.ca (S010614cc2056d97f.ed.shawcable.net. [174.3.196.123]) by smtp.gmail.com with ESMTPSA id e9sm102547056pff.5.2019.01.11.18.35.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Jan 2019 18:35:17 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1gi98m-0006Ps-J8; Fri, 11 Jan 2019 19:35:16 -0700 From: Jason Gunthorpe To: linux-rdma@vger.kernel.org, Selvin Xavier , Devesh Sharma , Somnath Kotur Cc: Jason Gunthorpe Subject: [PATCH 1/2] RDMA/bnxt_re: Fix lifetimes in bnxt_re_task Date: Fri, 11 Jan 2019 19:35:09 -0700 Message-Id: <20190112023510.24568-2-jgg@ziepe.ca> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190112023510.24568-1-jgg@ziepe.ca> References: <20190112023510.24568-1-jgg@ziepe.ca> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jason Gunthorpe A work queue cannot just rely on the ib_device not being freed, it must hold a kref on the memory so that the BNXT_RE_FLAG_IBDEV_REGISTERED check works. Also, every single work queue call has an allocated memory, and the kfree of this memory was missed sometimes. Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver") Signed-off-by: Jason Gunthorpe --- drivers/infiniband/hw/bnxt_re/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/bnxt_re/main.c b/drivers/infiniband/hw/bnxt_re/main.c index e7a997f2a5374a..94843979a11b6e 100644 --- a/drivers/infiniband/hw/bnxt_re/main.c +++ b/drivers/infiniband/hw/bnxt_re/main.c @@ -1483,7 +1483,7 @@ static void bnxt_re_task(struct work_struct *work) if (re_work->event != NETDEV_REGISTER && !test_bit(BNXT_RE_FLAG_IBDEV_REGISTERED, &rdev->flags)) - return; + goto exit; switch (re_work->event) { case NETDEV_REGISTER: @@ -1518,6 +1518,7 @@ static void bnxt_re_task(struct work_struct *work) smp_mb__before_atomic(); atomic_dec(&rdev->sched_count); exit: + put_device(&rdev->ibdev.dev); kfree(re_work); } @@ -1594,6 +1595,7 @@ static int bnxt_re_netdev_event(struct notifier_block *notifier, /* Allocate for the deferred task */ re_work = kzalloc(sizeof(*re_work), GFP_ATOMIC); if (re_work) { + get_device(&rdev->ibdev.dev); re_work->rdev = rdev; re_work->event = event; re_work->vlan_dev = (real_dev == netdev ?