From patchwork Sat Jan 12 02:42:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 10760883 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5F04414E5 for ; Sat, 12 Jan 2019 02:42:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4F21629ECC for ; Sat, 12 Jan 2019 02:42:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 40E4B29ED6; Sat, 12 Jan 2019 02:42:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D7BAE29ECC for ; Sat, 12 Jan 2019 02:42:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726488AbfALCmz (ORCPT ); Fri, 11 Jan 2019 21:42:55 -0500 Received: from mail-eopbgr00053.outbound.protection.outlook.com ([40.107.0.53]:2273 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726460AbfALCmz (ORCPT ); Fri, 11 Jan 2019 21:42:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hg800X4K9FSnLw/Ol3Ci5Yt7RHlO8rJJXwZC3P7MuJ8=; b=dFxOZSTmVmVveG/rgVCh1vT9DbklpQ9SBoKKliyRZoLpkUnzDkhDY/c4wWkVpykcTaoAtmUzj3QRkGolUVCb56j/ZP9tr27rexONYMjgms3Bgz9alhgxWinbSC8KkmSayxTg+rEvyAu8N/BpADkGyo5mlgxqQPcT2+azNIeeI68= Received: from HE1PR05MB4601.eurprd05.prod.outlook.com (20.176.163.138) by HE1PR05MB4553.eurprd05.prod.outlook.com (20.176.163.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.13; Sat, 12 Jan 2019 02:42:43 +0000 Received: from HE1PR05MB4601.eurprd05.prod.outlook.com ([fe80::75a0:a89d:1227:7ed3]) by HE1PR05MB4601.eurprd05.prod.outlook.com ([fe80::75a0:a89d:1227:7ed3%5]) with mapi id 15.20.1516.019; Sat, 12 Jan 2019 02:42:43 +0000 From: Jason Gunthorpe To: "linux-rdma@vger.kernel.org" Subject: [PATCH] RDMA/device: Use __ib_device_get_by_name() in ib_device_rename() Thread-Topic: [PATCH] RDMA/device: Use __ib_device_get_by_name() in ib_device_rename() Thread-Index: AQHUqiB9aDVIM31n0EO3SvKMdZe1Gw== Date: Sat, 12 Jan 2019 02:42:42 +0000 Message-ID: <20190112024232.GA25078@ziepe.ca> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MWHPR21CA0029.namprd21.prod.outlook.com (2603:10b6:300:129::15) To HE1PR05MB4601.eurprd05.prod.outlook.com (2603:10a6:7:99::10) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jgg@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [174.3.196.123] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;HE1PR05MB4553;6:Dlh0zGweCot3IbDdnrp8juSlwtxaw5/aud7GVAS27PodtZ4DLYPgMx/6jJNaQtt/sfwIPL1Q2LxLvOdCw+LE7NIzNlxnjcB0h0gv1PiWjDwysKgAKeQyZ2nNJ/XiKGOlZPjX7LQg5c+f3Avft9E73TIcP7pVoJya1hklUKDdvRF0I8yZXSTQDXI9Kai9ND/eQzTM+ntpzLPgR6wz4ULPncjCosLc7Iz9bFHjqUn1IMWKUe/12fAc4ISLRQH9T7DpUCjOeG+QcESLyx/KP7UqGrow+vL0C7i12GGIE6BysIumkFztb98a6rBTTOwcyS8GLtSfmoO9Kbu3U1RmDWdkpRTTsycH7GMgpw+RzbnfRd+wuSkTfj0bPdPeScWSB466qZ659MDgeA/za+83rDkEB1hoT3E8jns4PQkhP7HBOGpipCw36TNOhBrY2o09DOScXDSbiifBqv+jpbPDz7308w==;5:qf/HXwUm+rW1yFlFp/5/9QnuFdgp1Lt/hhs5o7kJ0rLDYT4jjk7kprv8/bj8o4ThG66oQVyllO1tW5BimQiBk8OhpeF3fzaCzJsXmhIkW3EXqTbHiv2Kj/h7KOA2WQ6r4OT7c+NawKiMdfB8KjE2W5eDaQaQ+Z33GFBIYcdwlrax9Jt1+yM2yenl8sbqvM6bseokTd/IytW3UYFI4lvLig==;7:tAZ+0a1tU2RJLxyg2rtpTP5VjRGzZJENKxN9vfiLzSY8uQ7YbLFxPs2zFmklJPs7iolPQP3nQwPpJvfOhbmgZgfxMwAKxKuz2t985DRRD5BEbOVIvPH7NXrgJg7khXfIq3CZXvr0xwmdpm8GEycQGg== x-ms-office365-filtering-correlation-id: c1633f8c-03ad-4344-39ba-08d678379f69 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:HE1PR05MB4553; x-ms-traffictypediagnostic: HE1PR05MB4553: x-microsoft-antispam-prvs: x-forefront-prvs: 0915875B28 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(136003)(376002)(396003)(39860400002)(346002)(199004)(189003)(2906002)(26005)(5640700003)(478600001)(99286004)(14454004)(5660300001)(52116002)(6486002)(186003)(102836004)(256004)(14444005)(53936002)(476003)(66066001)(3846002)(36756003)(71200400001)(25786009)(6116002)(486006)(71190400001)(86362001)(386003)(6506007)(97736004)(305945005)(6512007)(9686003)(1076003)(106356001)(2501003)(2351001)(68736007)(7736002)(33896004)(8676002)(81156014)(33656002)(81166006)(6436002)(8936002)(6916009)(105586002)(316002);DIR:OUT;SFP:1101;SCL:1;SRVR:HE1PR05MB4553;H:HE1PR05MB4601.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: nJt2JI13LQGBNP0Kc+coc5FZTug8Yp+PeMjzFaTYM7TMazOYGbYfOagNjMQPCHlvZ+/skkkfDTkpRDNRRq0Lbe9uBe7LEkuYXEv7m4sBVMEKtHgZ1MhK0X45bOrTQF0Pncb3kKepHqUbqkVveCUpIYjILThQaNpv/y2Gvr1YGkwMZzn1MnbUUD6fIsFllp8pCWJ5ULnjg/eKEbw9giJXRKyfFhCiPPAho7O7/OtOd/4qoWg4UVVxU/gRPJ2h1NhEqGQtc/nYV03saJ17yrsbUm6TXgJU9scMKy8C/lF6t0sz8RkDktSbXEWSDYOZs4i4gsO4bqK5g2dhyRUfaFO8nOgqJJXfByk+WGMM9gqs5lxxvRSZJNXctt6UbMEEDoWcwDa0uSQJKxNIL6tqFyc51VSmV6a4bmEiEgvLZfkjj2E= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1633f8c-03ad-4344-39ba-08d678379f69 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2019 02:42:41.2501 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR05MB4553 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP No reason to open code this loop. Signed-off-by: Jason Gunthorpe Reviewed-by: Steve Wise --- drivers/infiniband/core/device.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c index d42befb9fdb47a..5bb60371739a24 100644 --- a/drivers/infiniband/core/device.c +++ b/drivers/infiniband/core/device.c @@ -217,18 +217,15 @@ EXPORT_SYMBOL(ib_device_get_by_name); int ib_device_rename(struct ib_device *ibdev, const char *name) { - struct ib_device *device; int ret = 0; if (!strcmp(name, dev_name(&ibdev->dev))) return ret; mutex_lock(&device_mutex); - list_for_each_entry(device, &device_list, core_list) { - if (!strcmp(name, dev_name(&device->dev))) { - ret = -EEXIST; - goto out; - } + if (__ib_device_get_by_name(name)) { + ret = -EEXIST; + goto out; } ret = device_rename(&ibdev->dev, name);