From patchwork Sun Feb 24 13:06:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Noa Osherovich X-Patchwork-Id: 10827925 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5B4501575 for ; Sun, 24 Feb 2019 13:08:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3BB512B4FE for ; Sun, 24 Feb 2019 13:08:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2909F2B50B; Sun, 24 Feb 2019 13:08:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C8C462846C for ; Sun, 24 Feb 2019 13:08:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728085AbfBXNIs (ORCPT ); Sun, 24 Feb 2019 08:08:48 -0500 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:50435 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726865AbfBXNIs (ORCPT ); Sun, 24 Feb 2019 08:08:48 -0500 Received: from Internal Mail-Server by MTLPINE1 (envelope-from noaos@mellanox.com) with ESMTPS (AES256-SHA encrypted); 24 Feb 2019 15:06:48 +0200 Received: from reg-l-vrt-059-009.mtl.labs.mlnx (reg-l-vrt-059-009.mtl.labs.mlnx [10.135.59.9]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x1OD6mfV026210; Sun, 24 Feb 2019 15:06:48 +0200 From: Noa Osherovich To: leonro@mellanox.com, jgg@mellanox.com, dledford@redhat.com Cc: linux-rdma@vger.kernel.org, Noa Osherovich Subject: [PATCH rdma-core 01/19] pyverbs: Rename Gid class Date: Sun, 24 Feb 2019 15:06:20 +0200 Message-Id: <20190224130638.31848-2-noaos@mellanox.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190224130638.31848-1-noaos@mellanox.com> References: <20190224130638.31848-1-noaos@mellanox.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Pyverbs will be using an all-capital class names conventions for acronyms, fix Gid to match that convention. This means breaking pyverbs' API, but since it's not used yet and currently offers very little functionality, it shouldn't make a difference. Signed-off-by: Noa Osherovich --- pyverbs/addr.pxd | 2 +- pyverbs/addr.pyx | 2 +- pyverbs/device.pyx | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pyverbs/addr.pxd b/pyverbs/addr.pxd index 39039379d517..313cd68fb0d2 100644 --- a/pyverbs/addr.pxd +++ b/pyverbs/addr.pxd @@ -5,5 +5,5 @@ from .base cimport PyverbsObject from pyverbs cimport libibverbs as v -cdef class Gid(PyverbsObject): +cdef class GID(PyverbsObject): cdef v.ibv_gid gid diff --git a/pyverbs/addr.pyx b/pyverbs/addr.pyx index 986521b90e82..0f171e83ea21 100644 --- a/pyverbs/addr.pyx +++ b/pyverbs/addr.pyx @@ -9,7 +9,7 @@ cdef extern from 'endian.h': unsigned long be64toh(unsigned long host_64bits) -cdef class Gid(PyverbsObject): +cdef class GID(PyverbsObject): """ GID class represents ibv_gid. It enables user to query for GIDs values. """ diff --git a/pyverbs/device.pyx b/pyverbs/device.pyx index a50bd2349445..3fad6af41ecc 100644 --- a/pyverbs/device.pyx +++ b/pyverbs/device.pyx @@ -10,7 +10,7 @@ from .pyverbs_error import PyverbsRDMAError from .pyverbs_error import PyverbsUserError from pyverbs.base import PyverbsRDMAErrno cimport pyverbs.libibverbs as v -from pyverbs.addr cimport Gid +from pyverbs.addr cimport GID cdef extern from 'errno.h': int errno @@ -134,7 +134,7 @@ cdef class Context(PyverbsObject): return dev_attr def query_gid(self, unsigned int port_num, int index): - gid = Gid() + gid = GID() rc = v.ibv_query_gid(self.context, port_num, index, &gid.gid) if rc != 0: raise PyverbsRDMAError('Failed to query gid {idx} of port {port}'.