diff mbox series

[for-next,4/4] IB/hfi1: Remove WARN_ON when freeing expected receive groups

Message ID 20190318165855.25749.90438.stgit@scvm10.sc.intel.com (mailing list archive)
State Mainlined
Commit 8da0f0f26f80612efadc23beb72d5b66a498a386
Delegated to: Jason Gunthorpe
Headers show
Series IB/hfi1: Minor code improvements | expand

Commit Message

Dennis Dalessandro March 18, 2019, 4:59 p.m. UTC 
From: Kaike Wan <kaike.wan@intel.com>

When PSM user receive context is freed, the expected receive groups
allocated by the receive context will also been freed. However, if
there are still TID entries in use, the receive groups
rcd->tid_full_list or rcd->tid_used_list will not be empty, and thus
triggering the WARN_ONs in the function hfi1_free_ctxt_rcv_groups().
Even if the two lists may not be empty, the hfi1 driver will free all
TID entries and receive groups associated with the receive context
to prevent any resource leakage. Since a clean user application exit
is not controlled by the hfi1 driver, this patch will remove the
WARN_ONs in hfi1_free_ctxt_rcv_groups().

Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Kaike Wan <kaike.wan@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
---
 drivers/infiniband/hw/hfi1/exp_rcv.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/hfi1/exp_rcv.c b/drivers/infiniband/hw/hfi1/exp_rcv.c
index 1be49a0..e9d5cc8 100644
--- a/drivers/infiniband/hw/hfi1/exp_rcv.c
+++ b/drivers/infiniband/hw/hfi1/exp_rcv.c
@@ -112,9 +112,6 @@  int hfi1_alloc_ctxt_rcv_groups(struct hfi1_ctxtdata *rcd)
  */
 void hfi1_free_ctxt_rcv_groups(struct hfi1_ctxtdata *rcd)
 {
-	WARN_ON(!EXP_TID_SET_EMPTY(rcd->tid_full_list));
-	WARN_ON(!EXP_TID_SET_EMPTY(rcd->tid_used_list));
-
 	kfree(rcd->groups);
 	rcd->groups = NULL;
 	hfi1_exp_tid_group_init(rcd);