| Message ID | 20190320135047.23184-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [-next] RDMA/hns: Make hns_roce_cmq_send static | expand |
On Wed, Mar 20, 2019 at 09:50:47PM +0800, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fix sparse warning: > > drivers/infiniband/hw/hns/hns_roce_hw_v2.c:1089:5: > warning: symbol 'hns_roce_cmq_send' was not declared. Should it be static? > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks for your patch, but such fix was already submitted. https://patchwork.kernel.org/patch/10859135/ Thanks
On 2019/3/20 23:28, Leon Romanovsky wrote: > On Wed, Mar 20, 2019 at 09:50:47PM +0800, Yue Haibing wrote: >> From: YueHaibing <yuehaibing@huawei.com> >> >> Fix sparse warning: >> >> drivers/infiniband/hw/hns/hns_roce_hw_v2.c:1089:5: >> warning: symbol 'hns_roce_cmq_send' was not declared. Should it be static? >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > Thanks for your patch, but such fix was already submitted. > https://patchwork.kernel.org/patch/10859135/ Good to know this, Thanks! > > Thanks >
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c index 1c54390..b13436e 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c @@ -1086,7 +1086,7 @@ static int __hns_roce_cmq_send(struct hns_roce_dev *hr_dev, return ret; } -int hns_roce_cmq_send(struct hns_roce_dev *hr_dev, +static int hns_roce_cmq_send(struct hns_roce_dev *hr_dev, struct hns_roce_cmq_desc *desc, int num) { int retval;