diff mbox series

RDMA/vmw_pvrdma: Skip zeroing device attrs

Message ID 20190320141418.8087-1-yuval.shaia@oracle.com (mailing list archive)
State Mainlined
Commit 6a1096611cc57ac7307a3121b5df12b07c01a2c6
Delegated to: Jason Gunthorpe
Headers show
Series RDMA/vmw_pvrdma: Skip zeroing device attrs | expand

Commit Message

Yuval Shaia March 20, 2019, 2:14 p.m. UTC
Caller already clears props before calling query_device.

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
 drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Adit Ranadive March 20, 2019, 9:56 p.m. UTC | #1
On 3/20/19 7:14 AM, Yuval Shaia wrote:
> Caller already clears props before calling query_device.
> 
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> ---
>  drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c | 2 --
>  1 file changed, 2 deletions(-)
> 

Thanks!
Acked-by: Adit Ranadive <aditr@vmware.com>

> diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
> index f44220f72e05..b8e43b2380cc 100644
> --- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
> +++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
> @@ -70,8 +70,6 @@ int pvrdma_query_device(struct ib_device *ibdev,
>  	if (uhw->inlen || uhw->outlen)
>  		return -EINVAL;
>  
> -	memset(props, 0, sizeof(*props));
> -
>  	props->fw_ver = dev->dsr->caps.fw_ver;
>  	props->sys_image_guid = dev->dsr->caps.sys_image_guid;
>  	props->max_mr_size = dev->dsr->caps.max_mr_size;
>
Jason Gunthorpe March 27, 2019, 6:48 p.m. UTC | #2
On Wed, Mar 20, 2019 at 04:14:18PM +0200, Yuval Shaia wrote:
> Caller already clears props before calling query_device.
> 
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> Acked-by: Adit Ranadive <aditr@vmware.com>
> ---
>  drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c | 2 --
>  1 file changed, 2 deletions(-)

Applied to for-next 

Thanks,
Jason
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
index f44220f72e05..b8e43b2380cc 100644
--- a/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
+++ b/drivers/infiniband/hw/vmw_pvrdma/pvrdma_verbs.c
@@ -70,8 +70,6 @@  int pvrdma_query_device(struct ib_device *ibdev,
 	if (uhw->inlen || uhw->outlen)
 		return -EINVAL;
 
-	memset(props, 0, sizeof(*props));
-
 	props->fw_ver = dev->dsr->caps.fw_ver;
 	props->sys_image_guid = dev->dsr->caps.sys_image_guid;
 	props->max_mr_size = dev->dsr->caps.max_mr_size;