From patchwork Tue Apr 9 13:11:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 10891253 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EBF6F1669 for ; Tue, 9 Apr 2019 13:11:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D8DB7288EF for ; Tue, 9 Apr 2019 13:11:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D6FF8288B3; Tue, 9 Apr 2019 13:11:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 861C328924 for ; Tue, 9 Apr 2019 13:11:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726112AbfDINLp (ORCPT ); Tue, 9 Apr 2019 09:11:45 -0400 Received: from mail-qt1-f180.google.com ([209.85.160.180]:36453 "EHLO mail-qt1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726531AbfDINLo (ORCPT ); Tue, 9 Apr 2019 09:11:44 -0400 Received: by mail-qt1-f180.google.com with SMTP id s15so11263069qtn.3 for ; Tue, 09 Apr 2019 06:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cx7hO1viKgnplMRopBHjKibSLsTfRgNI1P1dXSTHwZU=; b=FOBD1gScREvWqlNwSieDKobSGid43BvFsmDwYp3XtaZncF/Knwa1WG+pyOhG9psjzu N7T0gT7GipPgdjy0LVU5bW2yr7dGwU6yArT+cDAu1QgbRK9cy6ejJmcdEn/mzuFPJAeW NpRX5EeOvummqMCrRlnKXdgnIPhmUoOigxD13n8mEkKNvRBw2nHr5hqjjjqFf98Y4qwr 1LsSJh6Qo0dWdb1fCmucNv/ZauKMwS2VnOdA6XMFVNAYsZU0yzOFlYj342z8M7FSF0UE MI1rDpbW1j3jlugUNBIu4HYlSg8uU7V02A4iwhwynv9GPHpi38eFFJZv5FymVyaJ4Hdu Nq+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cx7hO1viKgnplMRopBHjKibSLsTfRgNI1P1dXSTHwZU=; b=FT/NjPzIN+DiM/+8D3+2NDzHWNCP0/ARQnmDNw+bSrYgZkN1kPxQSWV9fzKE4ahubW NqM8zxaiX14SFP+g0HXG7/vMW+K6LZ7bPeLrUdVaLwT7Szj4pFXIcLS+NA5S71LoDY5P Ey+jXKaB3NvL7d6319cvtwchDfmlZI/mHbxkM9OZVJ0jL5pBFtOuskQ7vdzQR2dfXXR/ W8uCZO6zFHgZMHoOTVT2pzYoQiCI0isEYUBiO1QszFyLip71mKZEycidyHtvTAtA6fXj n3Lp7s+VbsQ7L7wADDjvqSzm7AiNA+KsJ6HRJr8JnCUcPAe+2FCH1v/cxaGuOURUBQL7 q6jQ== X-Gm-Message-State: APjAAAU0NokmJlcLvJO4QZ/CAUg8ixJaZJLo7FuBTtUFpEPHZaVfigG2 YHwNumM++E+5gQVA6Nhoe9cmBBJWMBk= X-Google-Smtp-Source: APXvYqzKar0U6wouQXtRH1QDleAg7Rv5JmV5bNrCRBXCYdd7Wmnhqc4wtsy8k/xbJTiiKdr1iyw3vQ== X-Received: by 2002:a0c:8b4a:: with SMTP id d10mr28746380qvc.29.1554815502322; Tue, 09 Apr 2019 06:11:42 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-49-251.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.49.251]) by smtp.gmail.com with ESMTPSA id g15sm22265056qta.31.2019.04.09.06.11.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 06:11:37 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hDqXI-0004FB-62; Tue, 09 Apr 2019 10:11:36 -0300 From: Jason Gunthorpe To: linux-rdma@vger.kernel.org Cc: Jason Gunthorpe Subject: [PATCH ibdiags 14/16] ibdiags: Add missing endian conversions on constants Date: Tue, 9 Apr 2019 10:11:31 -0300 Message-Id: <20190409131133.16140-15-jgg@ziepe.ca> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190409131133.16140-1-jgg@ziepe.ca> References: <20190409131133.16140-1-jgg@ziepe.ca> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jason Gunthorpe These constants are all the same in both endians so this is no functional change. Found by sparse. Signed-off-by: Jason Gunthorpe --- src/ibsendtrap.c | 2 +- src/smpdump.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ibsendtrap.c b/src/ibsendtrap.c index 8a3a3e6fd0449d..98d2b8b6c880dc 100644 --- a/src/ibsendtrap.c +++ b/src/ibsendtrap.c @@ -127,7 +127,7 @@ static void build_trap256_local(ib_mad_notice_attr_t * n, ib_portid_t * port) n->g_or_v.generic.trap_num = htobe16(256); n->issuer_lid = htobe16((uint16_t) port->lid); n->data_details.ntc_256.lid = n->issuer_lid; - n->data_details.ntc_256.dr_slid = 0xffff; + n->data_details.ntc_256.dr_slid = htobe16(0xffff); n->data_details.ntc_256.method = 1; n->data_details.ntc_256.attr_id = htobe16(0x15); n->data_details.ntc_256.attr_mod = htobe32(0x12); diff --git a/src/smpdump.c b/src/smpdump.c index cdd783600b602b..039eca03418016 100644 --- a/src/smpdump.c +++ b/src/smpdump.c @@ -93,8 +93,8 @@ static void drsmp_get_init(void *umad, DRPath * path, int attr, int mod) smp->attr_id = htons(attr); smp->attr_mod = htonl(mod); smp->tid = htobe64(drmad_tid++); - smp->dr_slid = 0xffff; - smp->dr_dlid = 0xffff; + smp->dr_slid = htobe16(0xffff); + smp->dr_dlid = htobe16(0xffff); umad_set_addr(umad, 0xffff, 0, 0, 0);