From patchwork Tue Apr 9 13:11:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 10891241 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 794E01669 for ; Tue, 9 Apr 2019 13:11:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 64402288FA for ; Tue, 9 Apr 2019 13:11:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 624CD2890B; Tue, 9 Apr 2019 13:11:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D07BC2890E for ; Tue, 9 Apr 2019 13:11:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727297AbfDINLl (ORCPT ); Tue, 9 Apr 2019 09:11:41 -0400 Received: from mail-qk1-f174.google.com ([209.85.222.174]:46552 "EHLO mail-qk1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727273AbfDINLl (ORCPT ); Tue, 9 Apr 2019 09:11:41 -0400 Received: by mail-qk1-f174.google.com with SMTP id s81so10116870qke.13 for ; Tue, 09 Apr 2019 06:11:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OA5lgmXIgDdaEEfz9QWC1+cv9sIzB27paTVrACY6Pnk=; b=WXPtcMSNzAjkLyM0hsjLXq4slrGAlxJ8m9zqE2zlXuiuZUrB7KO1GXi5dhyKVdTurP m+pudiBuHgyaLgkcvvmanAicGOJRaECv3QImqHFMZrvx1HiryuTMhgkoJzB6XLB8YrtS 4u8WjeU2hz5pj3I52Ribsk+Jhg/w+O7/++y8BeZ72rrFYS6xP9dV7gLZBu3ZG7wKxKBJ mAAu8HdZN2xI51qPwry/jKx1W97TVoIcLrfpQcvw0jebRwQK3gAcKeKOVp+87sGfikGT 0933wgeMu88hnWeBRasb1xJyHJFIr+iANoy8cSyRKzRj2m6e4dVj/OTRn0zoAu3Ea8d+ y7+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OA5lgmXIgDdaEEfz9QWC1+cv9sIzB27paTVrACY6Pnk=; b=CjCfMwkpJ1Img61edXXlH5zj68AMP4wWQnbKLyp7PfBdlCdbdbr56petGjGNQlHT/u QI0hrGD+QUv0FVWmweU6AeDyNj7uAejlz7/aDnJqPiaF62PZF6+ArnBaCPexGJ/OFJMF ROfTDvZtJ8QAPVjZvAqQBSktR3BoK0mNrYxJylanqRFlmg/XAfDFNy557wbbQXP4TjD/ dp+5pmvTCLmjVSlIdhwS2byDk3Z+UblCUTXjBaysYk4o7zIQEQ9/KVbN9LFGc3HNFpxd Nh4tk07qPUyfetk+oxsOgjWdu+uUu2OlAMsnVmZb8J1zdOdQe04NJI53nyfCFw18IuSN n4XQ== X-Gm-Message-State: APjAAAVKmm9utVHm/hXwQkd6CFOWc6x/e0BXC3G2SFi3S2GumHrA/5N/ 3ujcheMgoayUHfZ1iMqj628rjRUcsis= X-Google-Smtp-Source: APXvYqxBj0VRLdsytM0crtV/a820xkQRQXuf3sxZu4RDsrs7kQX3OKxfCNN3DQPQj/ZajvHvHxTxhQ== X-Received: by 2002:a37:6546:: with SMTP id z67mr28571508qkb.254.1554815500270; Tue, 09 Apr 2019 06:11:40 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-49-251.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.49.251]) by smtp.gmail.com with ESMTPSA id d75sm19667074qkb.74.2019.04.09.06.11.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 06:11:37 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hDqXH-0004Ea-S8; Tue, 09 Apr 2019 10:11:35 -0300 From: Jason Gunthorpe To: linux-rdma@vger.kernel.org Cc: Jason Gunthorpe Subject: [PATCH ibdiags 08/16] ibdiags: Remove always true test Date: Tue, 9 Apr 2019 10:11:25 -0300 Message-Id: <20190409131133.16140-9-jgg@ziepe.ca> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190409131133.16140-1-jgg@ziepe.ca> References: <20190409131133.16140-1-jgg@ziepe.ca> MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jason Gunthorpe clang 7.0 says: ../ibdiags/src/iblinkinfo.c:287:19: warning: address of array 'node->info' will always evaluate to 'true' [-Wpointer-bool-conversion] else if (node->info) So drop the test. Signed-off-by: Jason Gunthorpe --- src/iblinkinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/iblinkinfo.c b/src/iblinkinfo.c index c838afebdaef3b..b7c67e6a5d83ad 100644 --- a/src/iblinkinfo.c +++ b/src/iblinkinfo.c @@ -288,7 +288,7 @@ static void print_node_header(ibnd_node_t *node, int *out_header_flag, if (node->type == IB_NODE_SWITCH) { if (node->ports[0]) guid = node->ports[0]->guid; - else if (node->info) + else guid = mad_get_field64(node->info, 0, IB_NODE_PORT_GUID_F); printf("%s%s: 0x%016" PRIx64 " %s:\n",