| Message ID | 20190503122839.GB29695@mwanda (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | net/mlx5: potential error pointer dereference in error handling | expand |
On Fri, May 03, 2019 at 03:28:39PM +0300, Dan Carpenter wrote: > The error handling was a bit flipped around. If the mlx5_create_flow_group() > function failed then it would have resulted in dereferencing "fg" when > it was an error pointer. > > Fixes: 80f09dfc237f ("net/mlx5: Eswitch, enable RoCE loopback traffic") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/rdma.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Sorry for the delay, applied to mlx5-next branch. 6cc070bdf07c net/mlx5: potential error pointer dereference in error handling Thanks
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/rdma.c b/drivers/net/ethernet/mellanox/mlx5/core/rdma.c index 86f77456f873..401441aefbcb 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/rdma.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/rdma.c @@ -106,10 +106,10 @@ static int mlx5_rdma_enable_roce_steering(struct mlx5_core_dev *dev) return 0; -destroy_flow_table: - mlx5_destroy_flow_table(ft); destroy_flow_group: mlx5_destroy_flow_group(fg); +destroy_flow_table: + mlx5_destroy_flow_table(ft); free: kvfree(spec); kvfree(flow_group_in);
The error handling was a bit flipped around. If the mlx5_create_flow_group() function failed then it would have resulted in dereferencing "fg" when it was an error pointer. Fixes: 80f09dfc237f ("net/mlx5: Eswitch, enable RoCE loopback traffic") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/ethernet/mellanox/mlx5/core/rdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)