| Message ID | 20200507151610.52636-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 52c81f47f0d2680f0b2e7b61c1fa4d8ad35f3020 |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [next] RDMA/mlx5: remove duplicated assignment to variable rcqe_sz | expand |
On Thu, May 07, 2020 at 04:16:10PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable rcqe_sz is being unnecessarily assigned twice, fix this > by removing one of the duplicates. > > Addresses-Coverity: ("Evaluation order violation") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/infiniband/hw/mlx5/qp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > Fixes: 8bde2c509e40 ("RDMA/mlx5: Update all DRIVER QP places to use QP subtype") Thanks, Acked-by: Leon Romanovsky <leonro@mellanox.com>
On Thu, May 07, 2020 at 04:16:10PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable rcqe_sz is being unnecessarily assigned twice, fix this > by removing one of the duplicates. > > Addresses-Coverity: ("Evaluation order violation") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > Acked-by: Leon Romanovsky <leonro@mellanox.com> > --- > drivers/infiniband/hw/mlx5/qp.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index e5891d3da945..0d292d93f5e7 100644 --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -2043,8 +2043,7 @@ static int create_user_qp(struct mlx5_ib_dev *dev, struct ib_pd *pd, if ((qp->flags_en & MLX5_QP_FLAG_SCATTER_CQE) && (init_attr->qp_type == IB_QPT_RC || init_attr->qp_type == IB_QPT_UC)) { - int rcqe_sz = rcqe_sz = - mlx5_ib_get_cqe_size(init_attr->recv_cq); + int rcqe_sz = mlx5_ib_get_cqe_size(init_attr->recv_cq); MLX5_SET(qpc, qpc, cs_res, rcqe_sz == 128 ? MLX5_RES_SCAT_DATA64_CQE :