Message ID | 20200522190715.29022-1-wu000273@umn.edu (mailing list archive) |
---|---|
State | Not Applicable |
Headers | show |
Series | [v2] net/mlx4_core: fix a memory leak bug. | expand |
From: wu000273@umn.edu Date: Fri, 22 May 2020 14:07:15 -0500 > From: Qiushi Wu <wu000273@umn.edu> > > In function mlx4_opreq_action(), pointer "mailbox" is not released, > when mlx4_cmd_box() return and error, causing a memory leak bug. > Fix this issue by going to "out" label, mlx4_free_cmd_mailbox() can > free this pointer. > > Fixes: fe6f700d6cbb ("net/mlx4_core: Respond to operation request by firmware") > Signed-off-by: Qiushi Wu <wu000273@umn.edu> Applied.
diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c index 6e501af0e532..f6ff9620a137 100644 --- a/drivers/net/ethernet/mellanox/mlx4/fw.c +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c @@ -2734,7 +2734,7 @@ void mlx4_opreq_action(struct work_struct *work) if (err) { mlx4_err(dev, "Failed to retrieve required operation: %d\n", err); - return; + goto out; } MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET); MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET);