diff mbox series

[for-next,v1,1/4] RDMA/rxe: Drop pointless checks in rxe_init_ports

Message ID 20200705104313.283034-2-kamalheib1@gmail.com (mailing list archive)
State Mainlined
Commit 6112ef62826e91afbae5446d5d47b38e25f47e3f
Delegated to: Jason Gunthorpe
Headers show
Series RDMA/rxe: Cleanups and improvements | expand

Commit Message

Kamal Heib July 5, 2020, 10:43 a.m. UTC 
Both pkey_tbl_len and gid_tbl_len are set in rxe_init_port_param() - so
no need to check if they aren't set.

Fixes: 8700e3e7c485 ("Soft RoCE driver")
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
 drivers/infiniband/sw/rxe/rxe.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Leon Romanovsky July 5, 2020, 1:20 p.m. UTC | #1 
On Sun, Jul 05, 2020 at 01:43:10PM +0300, Kamal Heib wrote:
> Both pkey_tbl_len and gid_tbl_len are set in rxe_init_port_param() - so
> no need to check if they aren't set.
>
> Fixes: 8700e3e7c485 ("Soft RoCE driver")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
>  drivers/infiniband/sw/rxe/rxe.c | 3 ---
>  1 file changed, 3 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
diff mbox series

Patch

diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c
index 5642eefb4ba1..c7191b5e04a5 100644
--- a/drivers/infiniband/sw/rxe/rxe.c
+++ b/drivers/infiniband/sw/rxe/rxe.c
@@ -147,9 +147,6 @@  static int rxe_init_ports(struct rxe_dev *rxe)
 
 	rxe_init_port_param(port);
 
-	if (!port->attr.pkey_tbl_len || !port->attr.gid_tbl_len)
-		return -EINVAL;
-
 	port->pkey_tbl = kcalloc(port->attr.pkey_tbl_len,
 			sizeof(*port->pkey_tbl), GFP_KERNEL);