| Message ID | 20201021114952.38876-1-kamalheib1@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jason Gunthorpe |
| Headers | show |
| Series | [for-rc] RDMA/bnxt_re: Set queue pair state when being queried | expand |
On Wed, Oct 21, 2020 at 5:20 PM Kamal Heib <kamalheib1@gmail.com> wrote: > > The API for ib_query_qp requires the driver to set cur_qp_state > on return, add the missing set. > > Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver") > Signed-off-by: Kamal Heib <kamalheib1@gmail.com> Acked-by: Selvin Xavier <selvin.xavier@broadcom.com> Thanks > --- > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c > index cf3db9628397..f9c999d5ba28 100644 > --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c > +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c > @@ -2078,6 +2078,7 @@ int bnxt_re_query_qp(struct ib_qp *ib_qp, struct ib_qp_attr *qp_attr, > goto out; > } > qp_attr->qp_state = __to_ib_qp_state(qplib_qp->state); > + qp_attr->cur_qp_state = __to_ib_qp_state(qplib_qp->cur_qp_state); > qp_attr->en_sqd_async_notify = qplib_qp->en_sqd_async_notify ? 1 : 0; > qp_attr->qp_access_flags = __to_ib_access_flags(qplib_qp->access); > qp_attr->pkey_index = qplib_qp->pkey_index; > -- > 2.26.2 >
On Wed, Oct 21, 2020 at 02:49:52PM +0300, Kamal Heib wrote: > The API for ib_query_qp requires the driver to set cur_qp_state > on return, add the missing set. > > Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver") > Signed-off-by: Kamal Heib <kamalheib1@gmail.com> > Acked-by: Selvin Xavier <selvin.xavier@broadcom.com> > --- > drivers/infiniband/hw/bnxt_re/ib_verbs.c | 1 + > 1 file changed, 1 insertion(+) Can't see why this would be for -rc since it has been broken forever Applied to for-next, thanks Jason
diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c index cf3db9628397..f9c999d5ba28 100644 --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c @@ -2078,6 +2078,7 @@ int bnxt_re_query_qp(struct ib_qp *ib_qp, struct ib_qp_attr *qp_attr, goto out; } qp_attr->qp_state = __to_ib_qp_state(qplib_qp->state); + qp_attr->cur_qp_state = __to_ib_qp_state(qplib_qp->cur_qp_state); qp_attr->en_sqd_async_notify = qplib_qp->en_sqd_async_notify ? 1 : 0; qp_attr->qp_access_flags = __to_ib_access_flags(qplib_qp->access); qp_attr->pkey_index = qplib_qp->pkey_index;
The API for ib_query_qp requires the driver to set cur_qp_state on return, add the missing set. Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver") Signed-off-by: Kamal Heib <kamalheib1@gmail.com> --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 1 + 1 file changed, 1 insertion(+)