diff mbox series

[for-rc] RDMA/cxgb4: Fix the reported max_recv_sge value

Message ID 20210114191423.423529-1-kamalheib1@gmail.com (mailing list archive)
State Accepted
Commit a372173bf314d374da4dd1155549d8ca7fc44709
Delegated to: Jason Gunthorpe
Headers show
Series [for-rc] RDMA/cxgb4: Fix the reported max_recv_sge value | expand

Commit Message

Kamal Heib Jan. 14, 2021, 7:14 p.m. UTC
The max_recv_sge value is wrongly reported when calling query_qp, This
is happening due to a typo when assigning the max_recv_sge value, the
value of sq_max_sges was assigned instead of rq_max_sges.

Fixes: 3e5c02c9ef9a ("iw_cxgb4: Support query_qp() verb")
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
 drivers/infiniband/hw/cxgb4/qp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Potnuri Bharat Teja Jan. 18, 2021, 5:01 p.m. UTC | #1
On Friday, January 01/15/21, 2021 at 00:44:23 +0530, Kamal Heib wrote:
> The max_recv_sge value is wrongly reported when calling query_qp, This
> is happening due to a typo when assigning the max_recv_sge value, the
> value of sq_max_sges was assigned instead of rq_max_sges.
> 
> Fixes: 3e5c02c9ef9a ("iw_cxgb4: Support query_qp() verb")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---

Thanks for the patch Kamal.
Reviewed-by: Potnuri Bharat Teja <bharat@chelsio.com>
>  drivers/infiniband/hw/cxgb4/qp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
> index a7401398cb34..d109bb3822a5 100644
> --- a/drivers/infiniband/hw/cxgb4/qp.c
> +++ b/drivers/infiniband/hw/cxgb4/qp.c
> @@ -2474,7 +2474,7 @@ int c4iw_ib_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
>  	init_attr->cap.max_send_wr = qhp->attr.sq_num_entries;
>  	init_attr->cap.max_recv_wr = qhp->attr.rq_num_entries;
>  	init_attr->cap.max_send_sge = qhp->attr.sq_max_sges;
> -	init_attr->cap.max_recv_sge = qhp->attr.sq_max_sges;
> +	init_attr->cap.max_recv_sge = qhp->attr.rq_max_sges;
>  	init_attr->cap.max_inline_data = T4_MAX_SEND_INLINE;
>  	init_attr->sq_sig_type = qhp->sq_sig_all ? IB_SIGNAL_ALL_WR : 0;
>  	return 0;
> -- 
> 2.26.2
>
Jason Gunthorpe Jan. 19, 2021, 12:17 a.m. UTC | #2
On Thu, Jan 14, 2021 at 09:14:23PM +0200, Kamal Heib wrote:
> The max_recv_sge value is wrongly reported when calling query_qp, This
> is happening due to a typo when assigning the max_recv_sge value, the
> value of sq_max_sges was assigned instead of rq_max_sges.
> 
> Fixes: 3e5c02c9ef9a ("iw_cxgb4: Support query_qp() verb")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> Reviewed-by: Potnuri Bharat Teja <bharat@chelsio.com>
> ---
>  drivers/infiniband/hw/cxgb4/qp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-rc, thanks

Jason
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
index a7401398cb34..d109bb3822a5 100644
--- a/drivers/infiniband/hw/cxgb4/qp.c
+++ b/drivers/infiniband/hw/cxgb4/qp.c
@@ -2474,7 +2474,7 @@  int c4iw_ib_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr,
 	init_attr->cap.max_send_wr = qhp->attr.sq_num_entries;
 	init_attr->cap.max_recv_wr = qhp->attr.rq_num_entries;
 	init_attr->cap.max_send_sge = qhp->attr.sq_max_sges;
-	init_attr->cap.max_recv_sge = qhp->attr.sq_max_sges;
+	init_attr->cap.max_recv_sge = qhp->attr.rq_max_sges;
 	init_attr->cap.max_inline_data = T4_MAX_SEND_INLINE;
 	init_attr->sq_sig_type = qhp->sq_sig_all ? IB_SIGNAL_ALL_WR : 0;
 	return 0;