From patchwork Mon Jan 18 22:39:14 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 12028425 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6273DC433E6 for ; Mon, 18 Jan 2021 22:47:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2066123103 for ; Mon, 18 Jan 2021 22:47:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389020AbhARWlT (ORCPT ); Mon, 18 Jan 2021 17:41:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388916AbhARWk5 (ORCPT ); Mon, 18 Jan 2021 17:40:57 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC819C061793 for ; Mon, 18 Jan 2021 14:39:39 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id 190so14914191wmz.0 for ; Mon, 18 Jan 2021 14:39:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0puy8o7LHNVbEzkyY59cGvZqMSuCg/PeXRGc8n18wAg=; b=ODEVOMHlxe7SGHsihCkX7hiljk7MVMMUM3rJ2TKfImIU8XsPRzldc0/1cjzc7x3j+G l8IpoJKX12cTxSaJDcvYyprVEgImw0m6ELitWfdQyAv/dN8ddK7DBhhYirKCtSjn5DDQ QjGO+3uSUwx/N9r3ewIaEBokfkPBu+0vuTkh12s2UzHTTWV0iLNaH5Egbv8kHJEB4Slf X5CeDUPHJLPxLrKgHTnrOrhVJ6Puj51aIKfDGNQG/Dx/lRXyoAiJ7BhHZIEGEChgKbQA XCUy1u2GLMTXgN4Fzz+eB74tuA4FcxLD2sgMMojpy7TASuUlDBQWQUu/YrvTiDUALDQS VGAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0puy8o7LHNVbEzkyY59cGvZqMSuCg/PeXRGc8n18wAg=; b=OPioOOR0p8ijvBSLrmOjZW97v5NvMCl8kFcUQthVfJPfJBG3K0o97Dw7tRa8O/5VnF lFyt0wO1Gl3CpUarWcwneZVySmdXRphtTt7R4oX9gXpLBqXk2wjpvk6KfRSW3AHEnFcb BTp9pahijarBwEWNYuMxuwF1E8EhvMPxBH+lTkIHdyGWfYVPdFTMfcjeHJP9BThjrgYz vHhgm9EkJRR6cVcVPSjU2r1OtqTNw08LWxZHHEXs9kLZDmOXgKLHDqmUcZZ187OtiQr4 MCONsMKtd5uINE9qc4Y6MBJPkJ++36HfZRyNW8YnuT5xpRO4Wfua2CaeX1vwVTc/fzX1 umzw== X-Gm-Message-State: AOAM530oPL/2UHyK4nwcl5pxgRei/4JXzw973keAtxmQjiM4gazmmt+c 6ArPClUlbLfxxt4LtiwY8lX4rQ== X-Google-Smtp-Source: ABdhPJzFeMmq2VFdzOVQqg0w8Xj/sR8Jb/x6la5bbSfxKnlZSshuvA/mtI0tmNuWHeQ1X2+c1XbAkg== X-Received: by 2002:a05:600c:4148:: with SMTP id h8mr1262579wmm.137.1611009578591; Mon, 18 Jan 2021 14:39:38 -0800 (PST) Received: from dell.default ([91.110.221.158]) by smtp.gmail.com with ESMTPSA id l1sm33255902wrq.64.2021.01.18.14.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jan 2021 14:39:38 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org Subject: [PATCH 05/20] RDMA/core/cache: Fix some misspellings, missing and superfluous param descriptions Date: Mon, 18 Jan 2021 22:39:14 +0000 Message-Id: <20210118223929.512175-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210118223929.512175-1-lee.jones@linaro.org> References: <20210118223929.512175-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/infiniband/core/cache.c:688: warning: Function parameter or member 'ib_dev' not described in 'rdma_find_gid_by_port' drivers/infiniband/core/cache.c:688: warning: Function parameter or member 'port' not described in 'rdma_find_gid_by_port' drivers/infiniband/core/cache.c:688: warning: Excess function parameter 'device' description in 'rdma_find_gid_by_port' drivers/infiniband/core/cache.c:688: warning: Excess function parameter 'port_num' description in 'rdma_find_gid_by_port' drivers/infiniband/core/cache.c:741: warning: Function parameter or member 'ib_dev' not described in 'rdma_find_gid_by_filter' drivers/infiniband/core/cache.c:741: warning: Function parameter or member 'context' not described in 'rdma_find_gid_by_filter' drivers/infiniband/core/cache.c:741: warning: Excess function parameter 'device' description in 'rdma_find_gid_by_filter' drivers/infiniband/core/cache.c:1263: warning: Excess function parameter 'num_entries' description in 'rdma_query_gid_table' Cc: Doug Ledford Cc: Jason Gunthorpe Cc: linux-rdma@vger.kernel.org Signed-off-by: Lee Jones --- drivers/infiniband/core/cache.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c index 7989b7e1d1c04..5c9fac7cf4203 100644 --- a/drivers/infiniband/core/cache.c +++ b/drivers/infiniband/core/cache.c @@ -669,11 +669,10 @@ int ib_cache_gid_del_all_netdev_gids(struct ib_device *ib_dev, u8 port, * rdma_find_gid_by_port - Returns the GID entry attributes when it finds * a valid GID entry for given search parameters. It searches for the specified * GID value in the local software cache. - * @device: The device to query. + * @ib_dev: The device to query. * @gid: The GID value to search for. * @gid_type: The GID type to search for. - * @port_num: The port number of the device where the GID value should be - * searched. + * @port: The port number of the device where the GID value should be searched. * @ndev: In RoCE, the net device of the device. NULL means ignore. * * Returns sgid attributes if the GID is found with valid reference or @@ -719,7 +718,7 @@ EXPORT_SYMBOL(rdma_find_gid_by_port); /** * rdma_find_gid_by_filter - Returns the GID table attribute where a * specified GID value occurs - * @device: The device to query. + * @ib_dev: The device to query. * @gid: The GID value to search for. * @port: The port number of the device where the GID value could be * searched. @@ -728,6 +727,7 @@ EXPORT_SYMBOL(rdma_find_gid_by_port); * otherwise, we continue searching the GID table. It's guaranteed that * while filter is executed, ndev field is valid and the structure won't * change. filter is executed in an atomic context. filter must not be NULL. + * @context: Private data to pass into the call-back. * * rdma_find_gid_by_filter() searches for the specified GID value * of which the filter function returns true in the port's GID table. @@ -1253,7 +1253,6 @@ EXPORT_SYMBOL(rdma_get_gid_attr); * @entries: Entries where GID entries are returned. * @max_entries: Maximum number of entries that can be returned. * Entries array must be allocated to hold max_entries number of entries. - * @num_entries: Updated to the number of entries that were successfully read. * * Returns number of entries on success or appropriate error code. */