From patchwork Mon Feb 8 19:33:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 12076377 X-Patchwork-Delegate: jgg@ziepe.ca Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7E47C433DB for ; Mon, 8 Feb 2021 19:36:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7558364EAA for ; Mon, 8 Feb 2021 19:36:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236370AbhBHTgD (ORCPT ); Mon, 8 Feb 2021 14:36:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236216AbhBHTfG (ORCPT ); Mon, 8 Feb 2021 14:35:06 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B303FC061793 for ; Mon, 8 Feb 2021 11:33:55 -0800 (PST) From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1612812834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=rRLwXlZ4AnJ/T3GTWKZ98C1bcfYfugQq7db90OjUgxA=; b=EqySSq4U1N7/YDYu1ajOjw8vAnsBzy/QHdq2jCkVcg6OILTBlQsUzwX9wE1P8SToEPjQiw CG8rNcYjAPUcjSC2TnNmlqpmbigBicaNgjBiBFohgh+tMpIpHRUnV0/SJsDadIUMW7uCF/ DtL/j7c3OSlrMsRWSRqk8uu0TOIEDhTkLgxY0rut8Gzl0dUzwlwG4Hd5HCBUxYXoyZG0Fk DJfPcz+IgDVoRCtOF6ao7iNcFK857dl4jJop3OJZVdjtlkImCkzF6iRwLH+yyVYlDFkKoV nLXooPLaZcd5oOiPiwO4T3nGeULuyn/rfPYDR3HDVqlKmYsmzf6c5uLLZU5Ncw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1612812834; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=rRLwXlZ4AnJ/T3GTWKZ98C1bcfYfugQq7db90OjUgxA=; b=KHE746pleyXcKjf7pXONPDr7LOkWTjmBk5YnHEKCC5yNAWaF3l5StcExqf3FL2J/TBQHPJ XKN5Rrm0Zj1UABCQ== To: linux-rdma@vger.kernel.org Cc: Michal Kalderon , Ariel Elior , Doug Ledford , Jason Gunthorpe , Thomas Gleixner , Sebastian Andrzej Siewior Subject: [PATCH] RDMA/qedr: Remove in_irq() usage from debug output. Date: Mon, 8 Feb 2021 20:33:47 +0100 Message-Id: <20210208193347.383254-1-bigeasy@linutronix.de> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org qedr_gsi_post_send() has a debug output which prints the return value of in_irq() and irqs_disabled(). The result of the in_irq(), even if invoked from an interrupt handler, is subject to change depending on the `threadirqs' command line switch. The result of irqs_disabled() is always be 1 because the function acquires spinlock_t with spin_lock_irqsave(). Remove in_irq() and irqs_disabled() from the debug output because it provides little value. Signed-off-by: Sebastian Andrzej Siewior --- drivers/infiniband/hw/qedr/qedr_roce_cm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/qedr/qedr_roce_cm.c b/drivers/infiniband/hw/qedr/qedr_roce_cm.c index f5542d703ef90..13e5e6bbec99c 100644 --- a/drivers/infiniband/hw/qedr/qedr_roce_cm.c +++ b/drivers/infiniband/hw/qedr/qedr_roce_cm.c @@ -586,8 +586,8 @@ int qedr_gsi_post_send(struct ib_qp *ibqp, const struct ib_send_wr *wr, qp->wqe_wr_id[qp->sq.prod].wr_id = wr->wr_id; qedr_inc_sw_prod(&qp->sq); DP_DEBUG(qp->dev, QEDR_MSG_GSI, - "gsi post send: opcode=%d, in_irq=%ld, irqs_disabled=%d, wr_id=%llx\n", - wr->opcode, in_irq(), irqs_disabled(), wr->wr_id); + "gsi post send: opcode=%d, wr_id=%llx\n", wr->opcode, + wr->wr_id); } else { DP_ERR(dev, "gsi post send: failed to transmit (rc=%d)\n", rc); rc = -EAGAIN;