diff mbox series

[V4,rdma-core,1/5] Update kernel headers

Message ID 20210610104910.1147756-2-devesh.sharma@broadcom.com (mailing list archive)
State New
Headers show
Series Broadcom's user library update | expand

Commit Message

Devesh Sharma June 10, 2021, 10:49 a.m. UTC
To commit ?? ("RDMA/bnxt_re: update ABI to pass wqe-mode to user space").

Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
---
 kernel-headers/rdma/bnxt_re-abi.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Haakon Bugge June 10, 2021, 12:43 p.m. UTC | #1
> On 10 Jun 2021, at 12:49, Devesh Sharma <devesh.sharma@broadcom.com> wrote:
> 
> To commit ?? ("RDMA/bnxt_re: update ABI to pass wqe-mode to user space").
> 
> Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
> ---
> kernel-headers/rdma/bnxt_re-abi.h | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel-headers/rdma/bnxt_re-abi.h b/kernel-headers/rdma/bnxt_re-abi.h
> index dc52e3cf..52205ed2 100644
> --- a/kernel-headers/rdma/bnxt_re-abi.h
> +++ b/kernel-headers/rdma/bnxt_re-abi.h
> @@ -49,7 +49,8 @@
> #define BNXT_RE_CHIP_ID0_CHIP_MET_SFT		0x18
> 
> enum {
> -	BNXT_RE_UCNTX_CMASK_HAVE_CCTX = 0x1ULL
> +	BNXT_RE_UCNTX_CMASK_HAVE_CCTX = 0x1ULL,
> +	BNXT_RE_UCNTX_CMASK_HAVE_MODE = 0x02ULL

Please use a comma for the last enum as well, to avoid this line to be unnecessary modified when you add another entry.


Thxs, Håkon

> };
> 
> struct bnxt_re_uctx_resp {
> @@ -62,6 +63,8 @@ struct bnxt_re_uctx_resp {
> 	__aligned_u64 comp_mask;
> 	__u32 chip_id0;
> 	__u32 chip_id1;
> +	__u32 mode;
> +	__u32 rsvd1; /* padding */
> };
> 
> /*
> -- 
> 2.25.1
>
Devesh Sharma June 10, 2021, 3:34 p.m. UTC | #2
On Thu, Jun 10, 2021 at 6:13 PM Haakon Bugge <haakon.bugge@oracle.com> wrote:
>
>
>
> > On 10 Jun 2021, at 12:49, Devesh Sharma <devesh.sharma@broadcom.com> wrote:
> >
> > To commit ?? ("RDMA/bnxt_re: update ABI to pass wqe-mode to user space").
> >
> > Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
> > ---
> > kernel-headers/rdma/bnxt_re-abi.h | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/kernel-headers/rdma/bnxt_re-abi.h b/kernel-headers/rdma/bnxt_re-abi.h
> > index dc52e3cf..52205ed2 100644
> > --- a/kernel-headers/rdma/bnxt_re-abi.h
> > +++ b/kernel-headers/rdma/bnxt_re-abi.h
> > @@ -49,7 +49,8 @@
> > #define BNXT_RE_CHIP_ID0_CHIP_MET_SFT         0x18
> >
> > enum {
> > -     BNXT_RE_UCNTX_CMASK_HAVE_CCTX = 0x1ULL
> > +     BNXT_RE_UCNTX_CMASK_HAVE_CCTX = 0x1ULL,
> > +     BNXT_RE_UCNTX_CMASK_HAVE_MODE = 0x02ULL
>
> Please use a comma for the last enum as well, to avoid this line to be unnecessary modified when you add another entry.
Good suggestion, since this patch is rather dependent on kernel patch.
I would let this patch be unchanged.
>
>
> Thxs, Håkon
>
> > };
> >
> > struct bnxt_re_uctx_resp {
> > @@ -62,6 +63,8 @@ struct bnxt_re_uctx_resp {
> >       __aligned_u64 comp_mask;
> >       __u32 chip_id0;
> >       __u32 chip_id1;
> > +     __u32 mode;
> > +     __u32 rsvd1; /* padding */
> > };
> >
> > /*
> > --
> > 2.25.1
> >
>
Haakon Bugge June 11, 2021, 7:01 a.m. UTC | #3
> On 10 Jun 2021, at 17:34, Devesh Sharma <devesh.sharma@broadcom.com> wrote:
> 
> On Thu, Jun 10, 2021 at 6:13 PM Haakon Bugge <haakon.bugge@oracle.com> wrote:
>> 
>> 
>> 
>>> On 10 Jun 2021, at 12:49, Devesh Sharma <devesh.sharma@broadcom.com> wrote:
>>> 
>>> To commit ?? ("RDMA/bnxt_re: update ABI to pass wqe-mode to user space").
>>> 
>>> Signed-off-by: Devesh Sharma <devesh.sharma@broadcom.com>
>>> ---
>>> kernel-headers/rdma/bnxt_re-abi.h | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>> 
>>> diff --git a/kernel-headers/rdma/bnxt_re-abi.h b/kernel-headers/rdma/bnxt_re-abi.h
>>> index dc52e3cf..52205ed2 100644
>>> --- a/kernel-headers/rdma/bnxt_re-abi.h
>>> +++ b/kernel-headers/rdma/bnxt_re-abi.h
>>> @@ -49,7 +49,8 @@
>>> #define BNXT_RE_CHIP_ID0_CHIP_MET_SFT         0x18
>>> 
>>> enum {
>>> -     BNXT_RE_UCNTX_CMASK_HAVE_CCTX = 0x1ULL
>>> +     BNXT_RE_UCNTX_CMASK_HAVE_CCTX = 0x1ULL,
>>> +     BNXT_RE_UCNTX_CMASK_HAVE_MODE = 0x02ULL
>> 
>> Please use a comma for the last enum as well, to avoid this line to be unnecessary modified when you add another entry.
> Good suggestion, since this patch is rather dependent on kernel patch.
> I would let this patch be unchanged.

I see. Remember this next time you add/modify enum in the kernel uapi then :-)


Håkon

>> 
>> 
>> Thxs, Håkon
>> 
>>> };
>>> 
>>> struct bnxt_re_uctx_resp {
>>> @@ -62,6 +63,8 @@ struct bnxt_re_uctx_resp {
>>>      __aligned_u64 comp_mask;
>>>      __u32 chip_id0;
>>>      __u32 chip_id1;
>>> +     __u32 mode;
>>> +     __u32 rsvd1; /* padding */
>>> };
>>> 
>>> /*
>>> --
>>> 2.25.1
>>> 
>> 
> 
> 
> -- 
> -Regards
> Devesh
diff mbox series

Patch

diff --git a/kernel-headers/rdma/bnxt_re-abi.h b/kernel-headers/rdma/bnxt_re-abi.h
index dc52e3cf..52205ed2 100644
--- a/kernel-headers/rdma/bnxt_re-abi.h
+++ b/kernel-headers/rdma/bnxt_re-abi.h
@@ -49,7 +49,8 @@ 
 #define BNXT_RE_CHIP_ID0_CHIP_MET_SFT		0x18
 
 enum {
-	BNXT_RE_UCNTX_CMASK_HAVE_CCTX = 0x1ULL
+	BNXT_RE_UCNTX_CMASK_HAVE_CCTX = 0x1ULL,
+	BNXT_RE_UCNTX_CMASK_HAVE_MODE = 0x02ULL
 };
 
 struct bnxt_re_uctx_resp {
@@ -62,6 +63,8 @@  struct bnxt_re_uctx_resp {
 	__aligned_u64 comp_mask;
 	__u32 chip_id0;
 	__u32 chip_id1;
+	__u32 mode;
+	__u32 rsvd1; /* padding */
 };
 
 /*