From patchwork Thu Sep 30 11:35:27 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Shunsuke Mie X-Patchwork-Id: 12528063 X-Patchwork-Delegate: leon@leon.nu Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BBBEC433EF for ; Thu, 30 Sep 2021 11:35:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 645D9615E2 for ; Thu, 30 Sep 2021 11:35:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350488AbhI3LhQ (ORCPT ); Thu, 30 Sep 2021 07:37:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350482AbhI3LhQ (ORCPT ); Thu, 30 Sep 2021 07:37:16 -0400 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFABDC06176A for ; Thu, 30 Sep 2021 04:35:33 -0700 (PDT) Received: by mail-oi1-x233.google.com with SMTP id y201so6847990oie.3 for ; Thu, 30 Sep 2021 04:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=B3Fs1aBIXktvYLGb2TVUnCvr2QaRY0CbNTHUGXHt+HU=; b=iQEIwj08+MJhPX4gMi8OYV39VoxE8yvKN7UeZCGVdoIOyTFhg7v1jKLTWhpxS/LGEa 7u8RbcSg8ITkenlIUFsQV9jR77J+T1yO0PD//7sixR9W5XttQlGf+eEjUpdVHnTeUT1X VW/JwX1qhJ8jLIdxu5P666VS8Jv0HmckvGOlyyve+dAlF0rL529sXKvj3FTkfwYI9klU 9KGNLPLSOA68dAFZI76dTdob39g9ZzyKxvJdUR62l7wAg85ZE0zZMggcpfTC9Z9bqV0B ysPpmLloPlLNzSVmKH/P2BZYrlA2Ez1NboIiGlITipDhm//ckb6JM/cK/o2Zi5ele1Yg AkgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=B3Fs1aBIXktvYLGb2TVUnCvr2QaRY0CbNTHUGXHt+HU=; b=DxGwO4CwZzCbW5uc3RX3OLpb6yqJDiNY9/Je6/TalGrKAftzRWnsp/+Yz+PVbA68OJ 1m2vqbeFEZ9o23OBfl9wd9kcuhEhZMQxqxkAJKIyTdwabUMxQaHRSueINhLuqw/Danh5 WaUfvQn9WoY0BY25DYEFzclmQvu8D5J1Sp8R7VgdJgOrVMS5eqvk9+fnxT0AjRsDOWoK UAYsenJPXNhgCo3bFwI0SXfG1yFpVsmZ0ThjPNtVcbnLcAqtC9pmkOGdL0OCdFTCnHij 8qPP8YDIGzRi8K0bZXN5r8eZZI32An1fWH/nHao1fJdd9wRRmrSCVesPAjBsO1MOLAM0 316A== X-Gm-Message-State: AOAM5331ioF96FOVJQNG2XJWSoCo4aRpaXqdV5sjcns+mnTGVC43HUrv gcVE943iP4oqokC7WrW+wUJyNg== X-Google-Smtp-Source: ABdhPJy5INDSJMlJcQdd5j2HBzFLTf88QFIAKmhJeAltP1c0EkyTOgER3wGh4aS89zWNpeSV1HyCQw== X-Received: by 2002:aca:32c2:: with SMTP id y185mr2335719oiy.47.1633001733390; Thu, 30 Sep 2021 04:35:33 -0700 (PDT) Received: from tyrell.hq.igel.co.jp (napt.igel.co.jp. [219.106.231.132]) by smtp.gmail.com with ESMTPSA id k4sm500053oic.48.2021.09.30.04.35.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Sep 2021 04:35:32 -0700 (PDT) From: Shunsuke Mie To: Zhu Yanjun Cc: Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, mie@igel.co.jp Subject: [PATCH] Provider/rxe: Allocate rxe/ib objs by calloc Date: Thu, 30 Sep 2021 20:35:27 +0900 Message-Id: <20210930113527.49659-1-mie@igel.co.jp> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Some rxe/ib objects are allocated by malloc() and initialize manually respectively. To prevent a bug caused by memory uninitialization, this patch change to use calloc(). Signed-off-by: Shunsuke Mie Reviewed-by: Håkon Bugge --- providers/rxe/rxe.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/providers/rxe/rxe.c b/providers/rxe/rxe.c index 3533a325..788a1bbd 100644 --- a/providers/rxe/rxe.c +++ b/providers/rxe/rxe.c @@ -104,7 +104,7 @@ static struct ibv_pd *rxe_alloc_pd(struct ibv_context *context) struct ib_uverbs_alloc_pd_resp resp; struct ibv_pd *pd; - pd = malloc(sizeof(*pd)); + pd = calloc(1, sizeof(*pd)); if (!pd) return NULL; @@ -225,7 +225,7 @@ static struct ibv_mr *rxe_reg_mr(struct ibv_pd *pd, void *addr, size_t length, struct ib_uverbs_reg_mr_resp resp; int ret; - vmr = malloc(sizeof(*vmr)); + vmr = calloc(1, sizeof(*vmr)); if (!vmr) return NULL; @@ -382,7 +382,7 @@ static struct ibv_cq *rxe_create_cq(struct ibv_context *context, int cqe, struct urxe_create_cq_resp resp = {}; int ret; - cq = malloc(sizeof(*cq)); + cq = calloc(1, sizeof(*cq)); if (!cq) return NULL; @@ -594,7 +594,7 @@ static struct ibv_srq *rxe_create_srq(struct ibv_pd *pd, struct urxe_create_srq_resp resp; int ret; - srq = malloc(sizeof(*srq)); + srq = calloc(1, sizeof(*srq)); if (srq == NULL) return NULL; @@ -1167,7 +1167,7 @@ static struct ibv_qp *rxe_create_qp(struct ibv_pd *ibpd, struct rxe_qp *qp; int ret; - qp = malloc(sizeof(*qp)); + qp = calloc(1, sizeof(*qp)); if (!qp) goto err; @@ -1659,7 +1659,7 @@ static struct ibv_ah *rxe_create_ah(struct ibv_pd *pd, struct ibv_ah_attr *attr) return NULL; } - ah = malloc(sizeof(*ah)); + ah = calloc(1, sizeof(*ah)); if (ah == NULL) return NULL;