diff mbox series

[for-rc] RDMA/hns: Validate the pkey index

Message ID 20211117111009.119268-1-kamalheib1@gmail.com (mailing list archive)
State Superseded
Headers show
Series [for-rc] RDMA/hns: Validate the pkey index | expand

Commit Message

Kamal Heib Nov. 17, 2021, 11:10 a.m. UTC 
Before query pkey, make sure that the quered index is valid.

Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver")
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
 drivers/infiniband/hw/hns/hns_roce_main.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Haakon Bugge Nov. 17, 2021, 11:45 a.m. UTC | #1 
> On 17 Nov 2021, at 12:10, Kamal Heib <kamalheib1@gmail.com> wrote:
> 
> Before query pkey, make sure that the quered index is valid.

queried index ?

Thxs, Håkon

> 
> Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_main.c | 3 +++
> 1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c
> index 4194b626f3c6..8233bec053ee 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_main.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_main.c
> @@ -270,6 +270,9 @@ static enum rdma_link_layer hns_roce_get_link_layer(struct ib_device *device,
> static int hns_roce_query_pkey(struct ib_device *ib_dev, u32 port, u16 index,
> 			       u16 *pkey)
> {
> +	if (index > 0)
> +		return -EINVAL;
> +
> 	*pkey = PKEY_ID;
> 
> 	return 0;
> -- 
> 2.31.1
>
Kamal Heib Nov. 17, 2021, 2:50 p.m. UTC | #2 
On Wed, Nov 17, 2021 at 11:45:49AM +0000, Haakon Bugge wrote:
> 
> 
> > On 17 Nov 2021, at 12:10, Kamal Heib <kamalheib1@gmail.com> wrote:
> > 
> > Before query pkey, make sure that the quered index is valid.
> 
> queried index ?
> 
> Thxs, Håkon
> 

My bad, I'll fix it in v2.

Thanks,
Kamal

> > 
> > Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver")
> > Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> > ---
> > drivers/infiniband/hw/hns/hns_roce_main.c | 3 +++
> > 1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c
> > index 4194b626f3c6..8233bec053ee 100644
> > --- a/drivers/infiniband/hw/hns/hns_roce_main.c
> > +++ b/drivers/infiniband/hw/hns/hns_roce_main.c
> > @@ -270,6 +270,9 @@ static enum rdma_link_layer hns_roce_get_link_layer(struct ib_device *device,
> > static int hns_roce_query_pkey(struct ib_device *ib_dev, u32 port, u16 index,
> > 			       u16 *pkey)
> > {
> > +	if (index > 0)
> > +		return -EINVAL;
> > +
> > 	*pkey = PKEY_ID;
> > 
> > 	return 0;
> > -- 
> > 2.31.1
> > 
>
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c
index 4194b626f3c6..8233bec053ee 100644
--- a/drivers/infiniband/hw/hns/hns_roce_main.c
+++ b/drivers/infiniband/hw/hns/hns_roce_main.c
@@ -270,6 +270,9 @@  static enum rdma_link_layer hns_roce_get_link_layer(struct ib_device *device,
 static int hns_roce_query_pkey(struct ib_device *ib_dev, u32 port, u16 index,
 			       u16 *pkey)
 {
+	if (index > 0)
+		return -EINVAL;
+
 	*pkey = PKEY_ID;
 
 	return 0;