diff mbox series

[v2,for-rc] RDMA/hns: Validate the pkey index

Message ID 20211117145954.123893-1-kamalheib1@gmail.com (mailing list archive)
State Accepted
Delegated to: Jason Gunthorpe
Headers show
Series [v2,for-rc] RDMA/hns: Validate the pkey index | expand

Commit Message

Kamal Heib Nov. 17, 2021, 2:59 p.m. UTC 
Before query pkey, make sure that the queried index is valid.

Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver")
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
v2: Fix commit message.
---
 drivers/infiniband/hw/hns/hns_roce_main.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Jason Gunthorpe Nov. 17, 2021, 8:54 p.m. UTC | #1 
On Wed, Nov 17, 2021 at 04:59:54PM +0200, Kamal Heib wrote:
> Before query pkey, make sure that the queried index is valid.
> 
> Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
> v2: Fix commit message.
> ---
>  drivers/infiniband/hw/hns/hns_roce_main.c | 3 +++
>  1 file changed, 3 insertions(+)

Applied to for-next, thanks

Jason
diff mbox series

Patch

diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c
index 4194b626f3c6..8233bec053ee 100644
--- a/drivers/infiniband/hw/hns/hns_roce_main.c
+++ b/drivers/infiniband/hw/hns/hns_roce_main.c
@@ -270,6 +270,9 @@  static enum rdma_link_layer hns_roce_get_link_layer(struct ib_device *device,
 static int hns_roce_query_pkey(struct ib_device *ib_dev, u32 port, u16 index,
 			       u16 *pkey)
 {
+	if (index > 0)
+		return -EINVAL;
+
 	*pkey = PKEY_ID;
 
 	return 0;