diff mbox series

[for-next,v2] RDMA/rxe: Remove unused mask parameter

Message ID 20220715035340.1900168-1-lizhijian@fujitsu.com (mailing list archive)
State Accepted
Headers show
Series [for-next,v2] RDMA/rxe: Remove unused mask parameter | expand

Commit Message

Li Zhijian July 15, 2022, 3:46 a.m. UTC
This parameter had beed deprecated since below commit:
1a7085b34291 ("RDMA/rxe: Skip adjusting remote addr for write in retry operation")

Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
---
Feel free to add above commit to fixes tag if needed.
V2: add commit log.
---
 drivers/infiniband/sw/rxe/rxe_req.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Bob Pearson July 15, 2022, 5:21 p.m. UTC | #1
On 7/14/22 22:46, lizhijian@fujitsu.com wrote:
> This parameter had beed deprecated since below commit:
> 1a7085b34291 ("RDMA/rxe: Skip adjusting remote addr for write in retry operation")
> 
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> Feel free to add above commit to fixes tag if needed.
> V2: add commit log.
> ---
>  drivers/infiniband/sw/rxe/rxe_req.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
> index 69fc35485e60..35a249727435 100644
> --- a/drivers/infiniband/sw/rxe/rxe_req.c
> +++ b/drivers/infiniband/sw/rxe/rxe_req.c
> @@ -15,8 +15,7 @@ static int next_opcode(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
>  		       u32 opcode);
>  
>  static inline void retry_first_write_send(struct rxe_qp *qp,
> -					  struct rxe_send_wqe *wqe,
> -					  unsigned int mask, int npsn)
> +					  struct rxe_send_wqe *wqe, int npsn)
>  {
>  	int i;
>  
> @@ -83,7 +82,7 @@ static void req_retry(struct rxe_qp *qp)
>  			if (mask & WR_WRITE_OR_SEND_MASK) {
>  				npsn = (qp->comp.psn - wqe->first_psn) &
>  					BTH_PSN_MASK;
> -				retry_first_write_send(qp, wqe, mask, npsn);
> +				retry_first_write_send(qp, wqe, npsn);
>  			}
>  
>  			if (mask & WR_READ_MASK) {

Reviewed-by: Bob Pearson <rpearsonhpe@gmail.com>
Leon Romanovsky July 18, 2022, 11:52 a.m. UTC | #2
On Fri, Jul 15, 2022 at 03:46:36AM +0000, lizhijian@fujitsu.com wrote:
> This parameter had beed deprecated since below commit:
> 1a7085b34291 ("RDMA/rxe: Skip adjusting remote addr for write in retry operation")
> 
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
> Feel free to add above commit to fixes tag if needed.
> V2: add commit log.
> ---
>  drivers/infiniband/sw/rxe/rxe_req.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 

Thanks, applied.
diff mbox series

Patch

diff --git a/drivers/infiniband/sw/rxe/rxe_req.c b/drivers/infiniband/sw/rxe/rxe_req.c
index 69fc35485e60..35a249727435 100644
--- a/drivers/infiniband/sw/rxe/rxe_req.c
+++ b/drivers/infiniband/sw/rxe/rxe_req.c
@@ -15,8 +15,7 @@  static int next_opcode(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
 		       u32 opcode);
 
 static inline void retry_first_write_send(struct rxe_qp *qp,
-					  struct rxe_send_wqe *wqe,
-					  unsigned int mask, int npsn)
+					  struct rxe_send_wqe *wqe, int npsn)
 {
 	int i;
 
@@ -83,7 +82,7 @@  static void req_retry(struct rxe_qp *qp)
 			if (mask & WR_WRITE_OR_SEND_MASK) {
 				npsn = (qp->comp.psn - wqe->first_psn) &
 					BTH_PSN_MASK;
-				retry_first_write_send(qp, wqe, mask, npsn);
+				retry_first_write_send(qp, wqe, npsn);
 			}
 
 			if (mask & WR_READ_MASK) {