diff mbox series

[rdma-core] tests/test_mr.py: make cases description unique

Message ID 20220715095117.1902874-1-lizhijian@fujitsu.com (mailing list archive)
State Accepted
Headers show
Series [rdma-core] tests/test_mr.py: make cases description unique | expand

Commit Message

Li Zhijian July 15, 2022, 9:44 a.m. UTC
[root@rdma-server rdma-core]# git grep 'Verify that illegal flags combination fails as expected'
tests/test_mr.py:        Verify that illegal flags combination fails as expected
tests/test_mr.py:        Verify that illegal flags combination fails as expected

This description will be printed if verbose is on.

I'm going to add pyverbs tests to the LKP CI, unique description can help
LKP to distinguish the case.

Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
---
 tests/test_mr.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Li Zhijian July 15, 2022, 11:06 a.m. UTC | #1
I submit a PR to enable pytests in LKP, hope the LKP robot can help us to prevent obvious regressions.
https://github.com/intel/lkp-tests/pull/146
NOTE: only RXE driver is adapted to LKP so far.


On 15/07/2022 17:44, Li, Zhijian/李 智坚 wrote:
> [root@rdma-server rdma-core]# git grep 'Verify that illegal flags combination fails as expected'
> tests/test_mr.py:        Verify that illegal flags combination fails as expected
> tests/test_mr.py:        Verify that illegal flags combination fails as expected
>
> This description will be printed if verbose is on.
>
> I'm going to add pyverbs tests to the LKP CI, unique description can help
> LKP to distinguish the case.
>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
>   tests/test_mr.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/test_mr.py b/tests/test_mr.py
> index 3ec1fb3f32e8..b8159e4ca504 100644
> --- a/tests/test_mr.py
> +++ b/tests/test_mr.py
> @@ -529,7 +529,7 @@ class DmaBufMRTest(PyverbsAPITestCase):
>   
>       def test_dmabuf_reg_mr_bad_flags(self):
>           """
> -        Verify that illegal flags combination fails as expected
> +        Verify that DmaBufMR with illegal flags combination fails as expected
>           """
>           check_dmabuf_support(self.gpu)
>           with PD(self.ctx) as pd:
Li Zhijian July 22, 2022, 2:10 a.m. UTC | #2
Since format of this patch is mangled,  submit a PR instead
https://github.com/linux-rdma/rdma-core/pull/1200

On 15/07/2022 17:44, Li, Zhijian/李 智坚 wrote:
> [root@rdma-server rdma-core]# git grep 'Verify that illegal flags combination fails as expected'
> tests/test_mr.py:        Verify that illegal flags combination fails as expected
> tests/test_mr.py:        Verify that illegal flags combination fails as expected
>
> This description will be printed if verbose is on.
>
> I'm going to add pyverbs tests to the LKP CI, unique description can help
> LKP to distinguish the case.
>
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
> ---
>   tests/test_mr.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/test_mr.py b/tests/test_mr.py
> index 3ec1fb3f32e8..b8159e4ca504 100644
> --- a/tests/test_mr.py
> +++ b/tests/test_mr.py
> @@ -529,7 +529,7 @@ class DmaBufMRTest(PyverbsAPITestCase):
>   
>       def test_dmabuf_reg_mr_bad_flags(self):
>           """
> -        Verify that illegal flags combination fails as expected
> +        Verify that DmaBufMR with illegal flags combination fails as expected
>           """
>           check_dmabuf_support(self.gpu)
>           with PD(self.ctx) as pd:
diff mbox series

Patch

diff --git a/tests/test_mr.py b/tests/test_mr.py
index 3ec1fb3f32e8..b8159e4ca504 100644
--- a/tests/test_mr.py
+++ b/tests/test_mr.py
@@ -529,7 +529,7 @@  class DmaBufMRTest(PyverbsAPITestCase):
 
     def test_dmabuf_reg_mr_bad_flags(self):
         """
-        Verify that illegal flags combination fails as expected
+        Verify that DmaBufMR with illegal flags combination fails as expected
         """
         check_dmabuf_support(self.gpu)
         with PD(self.ctx) as pd: