| Message ID | 20220829071218.1639065-1-matsuda-daisuke@fujitsu.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2] RDMA/rxe: Delete error messages triggered by incoming Read requests | expand |
On Mon, Aug 29, 2022 at 04:12:18PM +0900, Daisuke Matsuda wrote: > An incoming Read request causes multiple Read responses. If a user MR to > copy data from is unavailable or responder cannot send a reply, then the > error messages can be printed for each response attempt, resulting in > message overflow. > > Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com> > --- > v2 > Stop passing unused value to 'err', as commented by Cheng Xu > > drivers/infiniband/sw/rxe/rxe_resp.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > Thanks, applied.
diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c index b36ec5c4d5e0..7c336db5cb54 100644 --- a/drivers/infiniband/sw/rxe/rxe_resp.c +++ b/drivers/infiniband/sw/rxe/rxe_resp.c @@ -809,10 +809,8 @@ static enum resp_states read_reply(struct rxe_qp *qp, if (!skb) return RESPST_ERR_RNR; - err = rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt), - payload, RXE_FROM_MR_OBJ); - if (err) - pr_err("Failed copying memory\n"); + rxe_mr_copy(mr, res->read.va, payload_addr(&ack_pkt), + payload, RXE_FROM_MR_OBJ); if (mr) rxe_put(mr); @@ -823,10 +821,8 @@ static enum resp_states read_reply(struct rxe_qp *qp, } err = rxe_xmit_packet(qp, &ack_pkt, skb); - if (err) { - pr_err("Failed sending RDMA reply.\n"); + if (err) return RESPST_ERR_RNR; - } res->read.va += payload; res->read.resid -= payload;
An incoming Read request causes multiple Read responses. If a user MR to copy data from is unavailable or responder cannot send a reply, then the error messages can be printed for each response attempt, resulting in message overflow. Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com> --- v2 Stop passing unused value to 'err', as commented by Cheng Xu drivers/infiniband/sw/rxe/rxe_resp.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)