From patchwork Wed Mar 15 18:18:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Fernandes X-Patchwork-Id: 13176505 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D744C61DA4 for ; Wed, 15 Mar 2023 18:19:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232603AbjCOSTn (ORCPT ); Wed, 15 Mar 2023 14:19:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232495AbjCOSTe (ORCPT ); Wed, 15 Mar 2023 14:19:34 -0400 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6164B77E22 for ; Wed, 15 Mar 2023 11:19:32 -0700 (PDT) Received: by mail-qt1-x82f.google.com with SMTP id i24so1066556qtm.6 for ; Wed, 15 Mar 2023 11:19:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1678904371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y6P3avYFLfmZWtirttMewFieZIFd8qLJc55Dm6AWaNQ=; b=AfJO3WF6GZ+yRdTZNjn5moqlE0pcfcwzJyR8ecGuewfHyPT8CvRJVgvhX9FiypD/QW 4t/r8YuGdxUFqFX4s51NsQEsnlk7EzA/hmPFQFKgHtdisgnd9MzLrJ6+3B7j282f7ItC f4V0U1tDhWGzVLkggiaSkFqTi3L4T7gF+mFrc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678904371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y6P3avYFLfmZWtirttMewFieZIFd8qLJc55Dm6AWaNQ=; b=URV1He8ADQd8os3YjZCo7YefnhqoZsSWKJ6agDdIncTDsTe+30wYb85cR0xLqMkPBv NWNnGykMHPbUClJcApdSDM/c43rMz+C7CUSIu2UqoTnl+6miwpOtfzbcgwwVf+qEL0/3 qcDItITUrPvsoIAT8gp4p11NpxXfiqQTxAnp6ZktOlEZopmaGXdVPTB/sY0Jk17Xio5D ZiYq5bisoNzyWq2etfwQKIMwub6/Zqow6HkfHgcVFE0sZGMTvMhctIfj26M15XBkfBDH BCZ1C+De7BArS/gDCV8dre0ZYyzNeir1oMrtEcGXTsyLspHzR7WjJoempJ6/n6+rqrDM KU5g== X-Gm-Message-State: AO0yUKVitMx29ZKtPYtz0wqpqdcAJtQ3ONr5Fiv3OXGnM5GpwWCiMgbr wW4HTuqr+cc2pC1SCXfTGOcEbA== X-Google-Smtp-Source: AK7set/KQrtDeKLTF6TrIljAt+eNWc5kdtu2hQ8C4MazFU3GCyoPdEgAjOM7vonPV/MkIpsla8vYNg== X-Received: by 2002:ac8:5e0c:0:b0:3b8:6a20:675e with SMTP id h12-20020ac85e0c000000b003b86a20675emr1472979qtx.29.1678904370959; Wed, 15 Mar 2023 11:19:30 -0700 (PDT) Received: from joelboxx.c.googlers.com.com (129.239.188.35.bc.googleusercontent.com. [35.188.239.129]) by smtp.gmail.com with ESMTPSA id v125-20020a379383000000b007458ae32290sm4113974qkd.128.2023.03.15.11.19.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Mar 2023 11:19:30 -0700 (PDT) From: "Joel Fernandes (Google)" To: Saeed Mahameed , Leon Romanovsky , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Boris Pismenny Cc: "Uladzislau Rezki (Sony)" , Ariel Levkovich , Vlad Buslov , "Paul E . McKenney" , Joel Fernandes , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 06/14] net/mlx5: Rename kfree_rcu() to kfree_rcu_mightsleep() Date: Wed, 15 Mar 2023 18:18:53 +0000 Message-Id: <20230315181902.4177819-6-joel@joelfernandes.org> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog In-Reply-To: <20230315181902.4177819-1-joel@joelfernandes.org> References: <20230315181902.4177819-1-joel@joelfernandes.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: "Uladzislau Rezki (Sony)" The kfree_rcu() and kvfree_rcu() macros' single-argument forms are deprecated. Therefore switch to the new kfree_rcu_mightsleep() and kvfree_rcu_mightsleep() variants. The goal is to avoid accidental use of the single-argument forms, which can introduce functionality bugs in atomic contexts and latency bugs in non-atomic contexts. Cc: Ariel Levkovich Cc: Saeed Mahameed Cc: Vlad Buslov Signed-off-by: Uladzislau Rezki (Sony) Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes (Google) Reviewed-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c index ca834bbcb44f..8afcec0c5d3c 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/int_port.c @@ -242,7 +242,7 @@ mlx5e_int_port_remove(struct mlx5e_tc_int_port_priv *priv, mlx5_del_flow_rules(int_port->rx_rule); mapping_remove(ctx, int_port->mapping); mlx5e_int_port_metadata_free(priv, int_port->match_metadata); - kfree_rcu(int_port); + kfree_rcu_mightsleep(int_port); priv->num_ports--; } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c index 08d0929e8260..b811dad7370a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c @@ -670,7 +670,7 @@ static int mlx5e_macsec_del_txsa(struct macsec_context *ctx) mlx5e_macsec_cleanup_sa(macsec, tx_sa, true); mlx5_destroy_encryption_key(macsec->mdev, tx_sa->enc_key_id); - kfree_rcu(tx_sa); + kfree_rcu_mightsleep(tx_sa); macsec_device->tx_sa[assoc_num] = NULL; out: @@ -849,7 +849,7 @@ static void macsec_del_rxsc_ctx(struct mlx5e_macsec *macsec, struct mlx5e_macsec xa_erase(&macsec->sc_xarray, rx_sc->sc_xarray_element->fs_id); metadata_dst_free(rx_sc->md_dst); kfree(rx_sc->sc_xarray_element); - kfree_rcu(rx_sc); + kfree_rcu_mightsleep(rx_sc); } static int mlx5e_macsec_del_rxsc(struct macsec_context *ctx)