From patchwork Mon Jun 17 15:07:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Dragos Tatulea X-Patchwork-Id: 13700905 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2080.outbound.protection.outlook.com [40.107.93.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFA9C13D2BB; Mon, 17 Jun 2024 15:08:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.93.80 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718636904; cv=fail; b=End7bky1m2/Me+hgBNkISTYzlG/i9oZnyyPx+se0yBZjSCwKhr/VtoLaO8n63KvJSOOIlBaH1Tbvyb2Z3Bs4AqZidGrwxNVsSiVPwbZ1+sMYa9+xhCg4V9Q76MA1sx3+c8JcsB/gOXvG83RXAY9fHWScofmVFTG5z8Ea0dlzb4M= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718636904; c=relaxed/simple; bh=TRGc0/41x7iSPk6HeNlCOk/vubauiYx27vgStcTBSfg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=hfi5R0o/sZXz47LOTT7FpBKxsx4SAWKsZih7kl+tkjFw2y9uEWukYRnC2Sa0Aq+hcpjd8YGTO0akcJM6S18vDl8++LJiXLtJfv9z29LRBP0Y4Ust384q4db8B0rRU0osF944kc8MKiByFEhrDAeNIA5FvQ7WfHhVUiRKV9z5Bjg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=i3o11VyN; arc=fail smtp.client-ip=40.107.93.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="i3o11VyN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZIiWFlnS+TqDB1MRevRv2X8eC2WLpIbdfKlAtMj6HflMLgn/SCCz6TxT1nUpI87rrIIFTS8EbCGlo7fpUx1AfrWSlNNrJQo99PoB7Yl8VIOyJFIdJ/VdmJw9fuim8TC1g8RV12V90vQCdlYkpzbZRbvUXYvoPYv11Yg50A5et1Ua4Ki9mqGiT/bbW35NHd5EvV51HdgkekLib2NMbGb7GO5M7qX7+BukY3eCxCsPSQNzc4dO0yUA/WfkWhS+R87v4dprqVt4wTl0+qVzRS41JgAI3DfP2EpwCBZ1eXRo7KzzHwEAch/Xi0+pUYYAzXTmQ/0aguZzuxw9Lvw+SI03dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N/E6q/KcQcL4M6hpZbGaFa5c0cidw5SEefNg8HKLmz8=; b=HGfUwraVuvCeJmSg3lz7Gc9lBlZpyzbf8wazJOruQyVQw3TxOomopWT7FwDlAl/syisYqNNYGjgsHh0ON6DO3TQDYBW2P7jXfCAp8pjNpJ+eRqe3qpdTtFis3XJ8iRRK1YomXPhh59Abjy5vdqlHyq94Gq0OsgFRC1lesZ5cjAjw42YEz3rUSlUiGZkB0B8e+yTY7KncGMPO7Ppzij9Q/Sq+KpGYdFFu0K/6qZ3vjjQnKqjkNt9y3/OCNXxFTpF0uOiwgoyj8MWu0wyvKUizZAXgWm/b3CbdZqhozLgRlXewaTaVFR6lBpyka9ERK14rIlUSDwl0gGWafrggRWoQrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N/E6q/KcQcL4M6hpZbGaFa5c0cidw5SEefNg8HKLmz8=; b=i3o11VyN49/kaqAX4YbmcOJFzCgfSKDuOPMfDer0JSj8idCsbMkeo7qXHdUlDSd5TplLfbxyKAIXHpBF9ftPCX6LVDv6zGA8XrJnuANjws881Hx8tDCTF96bVxZevG9wdlSAqSpUHPDIy7aQ0L/48sPfJsb7t6yQaiNnCmj3Ucy38QIyrgHGkCFE6HBB8+xjs1Ng2AzkUsGFCdHg3ISB4t2aWZv/qwdxCZJeTfngo151OCWs8M6h5OJz8FfYh5Q1Zw5hnup4TsGpDZEAJfwo+OFjGa8eCv8msA9vGcDOUw6CMlEBSbr48c62h/J9HWPoWwfVnejLnwvDTKW2EEEJmQ== Received: from SN7PR04CA0079.namprd04.prod.outlook.com (2603:10b6:806:121::24) by DS7PR12MB6024.namprd12.prod.outlook.com (2603:10b6:8:84::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30; Mon, 17 Jun 2024 15:08:19 +0000 Received: from SA2PEPF00003AE9.namprd02.prod.outlook.com (2603:10b6:806:121:cafe::2f) by SN7PR04CA0079.outlook.office365.com (2603:10b6:806:121::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.31 via Frontend Transport; Mon, 17 Jun 2024 15:08:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by SA2PEPF00003AE9.mail.protection.outlook.com (10.167.248.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.15 via Frontend Transport; Mon, 17 Jun 2024 15:08:18 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 08:08:04 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 17 Jun 2024 08:08:03 -0700 Received: from dev-l-177.mtl.labs.mlnx (10.127.8.11) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Mon, 17 Jun 2024 08:08:00 -0700 From: Dragos Tatulea Date: Mon, 17 Jun 2024 18:07:38 +0300 Subject: [PATCH vhost 04/23] vdpa/mlx5: Drop redundant check in teardown_virtqueues() Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <20240617-stage-vdpa-vq-precreate-v1-4-8c0483f0ca2a@nvidia.com> References: <20240617-stage-vdpa-vq-precreate-v1-0-8c0483f0ca2a@nvidia.com> In-Reply-To: <20240617-stage-vdpa-vq-precreate-v1-0-8c0483f0ca2a@nvidia.com> To: "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?utf-8?q?Eugenio_P=C3=A9rez?= , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Si-Wei Liu CC: , , , , Dragos Tatulea , Cosmin Ratiu X-Mailer: b4 0.13.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PEPF00003AE9:EE_|DS7PR12MB6024:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f0e43a6-c2f8-4626-a1c8-08dc8edf5222 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|7416011|376011|1800799021|82310400023|36860700010; X-Microsoft-Antispam-Message-Info: =?utf-8?q?gHP1LmXpv1AwvbaUHYbLloZ7PYh1bA7?= =?utf-8?q?tqPxpOwrr8qaVKCBAMOKu+dPpnaBMeNrIsJdbPxiEUqxUSdf9hgzdQAGOuLDc8Nti?= =?utf-8?q?RYoc8p7+11eEkWQjO4//ItAHo/mxqeqjFUSQUFgFeo+IW5Jni08hfrPb37+R0+dN+?= =?utf-8?q?fH66eMXTPmeenbEnN8wVFsnSoyup/gYSi7ETcl+TD0sPZJFWRt4S0BQxXN+wDEtet?= =?utf-8?q?518+zckDTnmgWIUsBmEd65IWvDn0i6N5NuPT/lmoAl2ShFksOsRNclOFJwPjZOv51?= =?utf-8?q?4yAw1EwI1K1mNw59IL/dqGHf4Ce5FLHp5VLNcaN9vbZ+9fW/5Uf72Op/FVA8Ki84m?= =?utf-8?q?MYx+MGxWlx17aKXmqhkEEgqPI2DpBTjvRn7XGKfY/v9nxczHwSyPVnWFA+/rhTWPs?= =?utf-8?q?/ntG7jnd8G6ftm0kvNjQ9D1wgaeoaKLfROu38JBBLImAbZ2z1FtS/cvFOI4s8ebZX?= =?utf-8?q?qtU9qTNJd9aYcPzDTbeGm2wmC0my3HF4nhOHb8pm1MKwCN4clZAxxCt+yA06XyLJz?= =?utf-8?q?Hs+z7wdYxGQArmJWYrMQhDd6y3FUYe4YNibulw6r1Pm58awwGYnFqNPZ27Jr5Ub3P?= =?utf-8?q?yvROGAnyluhu8SHA3Rtfoovgvpwl+63H1/qBbVJqPWD1YzFickn3nmjI3mObIt2yY?= =?utf-8?q?eOgf2vBfics9wuEyp4J9c71J1GQBmUgFBJ5AK2TyL1KiMl2s8KRD8JhaZXo/G8VJ0?= =?utf-8?q?vUv5robQYRAOM1unxkxHdnu6bkducHv346BieVbs2o4wAwddtAWsYn8Tm/djJ4UB2?= =?utf-8?q?5zP0M/WiIR+QHosjxygWbXJxdVYPDwV1MepGyaffHNKv2NTqNRXxUBIbTBIKbmXgS?= =?utf-8?q?1dwc4MfGEn/5+qcEpXAipgdKJBMyw4wHDsTd+j/3YLDhjTPeXApY1OFOxcWPn22Ik?= =?utf-8?q?Vv3UVYvIsStw4d02a8l/1bdRjyl704SE2DyWnnjvsIut+puxnjSJe6hgcf4e1WVaw?= =?utf-8?q?SknAKoOjZF4mrcCyW4epChpyThgKuYmwEpZKEl+rrQmgzWvwxSIOvT4BWigl7bkJQ?= =?utf-8?q?aX7A2XtxzpBfDWa92LTQVvxrb2d9ig8Gx6zDxLenNGl/DmJrdFHo9cTSGwht3xyqf?= =?utf-8?q?8kn9+zSKFnb6U22SXpnOcgU5kOLLmAn3rS7cjs7bjAfo34H9rgBEqdKLSsaWwoNzi?= =?utf-8?q?oCUy5JSDuqQHORb4M90gofCwfLYIQvBUJ4s8JOWitL9WWFOQWWoCBkfo9FeuT8N0M?= =?utf-8?q?WNr8BQg4iXceD9VVWB4Y3n6zZ+D9p82Z9irMBzm0wj6G0DEr5m/68wC13dznwO/8o?= =?utf-8?q?dJxvgwLh+CQU5zUVIM1Po9y9qF7Zp0ES/ZcI5oLgNaDADY6/nXN7vkdN8v4Bwew++?= =?utf-8?q?4awCssJb4FxXehjzHA3fzb3GEIJ73aNC+A=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.118.232;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc7edge1.nvidia.com;CAT:NONE;SFS:(13230037)(7416011)(376011)(1800799021)(82310400023)(36860700010);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2024 15:08:18.5370 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f0e43a6-c2f8-4626-a1c8-08dc8edf5222 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.118.232];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SA2PEPF00003AE9.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6024 The check is done inside teardown_vq(). Signed-off-by: Dragos Tatulea Reviewed-by: Cosmin Ratiu Reviewed-by: Eugenio Pérez --- drivers/vdpa/mlx5/net/mlx5_vnet.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c index b4d9ef4f66c8..96782b34e2b2 100644 --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c @@ -2559,16 +2559,10 @@ static int setup_virtqueues(struct mlx5_vdpa_dev *mvdev) static void teardown_virtqueues(struct mlx5_vdpa_net *ndev) { - struct mlx5_vdpa_virtqueue *mvq; int i; - for (i = ndev->mvdev.max_vqs - 1; i >= 0; i--) { - mvq = &ndev->vqs[i]; - if (!mvq->initialized) - continue; - - teardown_vq(ndev, mvq); - } + for (i = ndev->mvdev.max_vqs - 1; i >= 0; i--) + teardown_vq(ndev, &ndev->vqs[i]); } static void update_cvq_info(struct mlx5_vdpa_dev *mvdev)