From patchwork Thu Mar 6 23:01:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nikolay Aleksandrov X-Patchwork-Id: 14005487 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0A3B27D791 for ; Thu, 6 Mar 2025 23:04:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741302246; cv=none; b=YN31jQlJnvSdGTbwkb6BzsWlSqZ+N/YStuSqT9dqSlQH6VjNSzr8muuWeb53G6pICZ3ou2AZ2jAzdsAjs/xJZ1ga8REM+T0N/32D8xQGsNn656cwXdAGE5bwTSkuMXSyBB4PV91Ekmc3Ks6Sp+pEU5kErp1SEOkH65bsfJeeJDQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741302246; c=relaxed/simple; bh=9t+BWyeKo3lXUFD7OKztQ3S+oioUT+EA4xokMzKS89o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=onTe0my18Yf//L2xr6AMOTxJrRyZljKBdHCqERzab/56jHWd9GQXJ32XjPUA2yMDvMuuWoOea1eD7QjZA+e8BB+Q0IieKPRjYLRLvra2aD8ntNy6s/spGMmiS45oJR8+kDn7l7CHoMq+GltBD6H9CJRmdDX3WOLW9qyecMyIsI8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=enfabrica.net; spf=pass smtp.mailfrom=enfabrica.net; dkim=pass (2048-bit key) header.d=enfabrica.net header.i=@enfabrica.net header.b=XCcg56bW; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=enfabrica.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=enfabrica.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=enfabrica.net header.i=@enfabrica.net header.b="XCcg56bW" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-7c3d1664ed5so145626085a.2 for ; Thu, 06 Mar 2025 15:04:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enfabrica.net; s=google; t=1741302243; x=1741907043; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tI+QptX8aFaKo9m7kn+rX3JmnFQXDEQcbJWxJ5w+bWw=; b=XCcg56bWKC6CfmsWUU6oxSXDVohNRQlgqwOoFOwOW3Yhqcl/XXmJr6r4X6xgSce+yM j0i785+r+ohA9d5FDMiyJ1SjGJtJH3uHd7oBINhMt3T00mt4POBSmu9b9K3QJ3vOyFRU 7FV4FXIwfh7qIjY5xPUPgnAMUa5zmJf+FgmMjYrh3l09ckcKs4hWVPxriYsQRfuSomYJ g9xN8lzHWlv3uf1ZVGctQEyP91CF5QE9teXsahWEiVpTQH4m5XA1okEZUp+CwH4IJOhJ YmX922QmpIz8KWWzMRxoO+mAGOWxC3U/64nRz0DjXuf6+s+WhQURiQG1W7XB3h9PoWCl 4yRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741302243; x=1741907043; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tI+QptX8aFaKo9m7kn+rX3JmnFQXDEQcbJWxJ5w+bWw=; b=IzFhDPYP3l1IcoU6zbMq/jOiDZ7VxS7qlKbGTIPHCDsIGb02qeokJDzl+9pV1Lj2Yp CRQWzxeQU0XrasvTaVezsZxKs6l9DXFl/uftMg18f6+zRJ9pLGrLWRGTGOkakhDNPy8E 7Jo4ld9gRxPuf5hgu0zQL9d1U7JGALgvSXGWbPmdjfSK2YUYyKdbosAFE4Sd+LunyfQA 5WlOl786IIU0RJC8iX0LVQkdWci19soqGLH6XroMHda5nAupwdvegEFCgQJxcly+R57e uBQr4887UK5z1Pvw8QHyP/agaTV0sxtA5jYv7ynegIonZ4iHSeqzmm776h5BmW8hjSXy 6AIQ== X-Forwarded-Encrypted: i=1; AJvYcCU1LO4ZTaGUmKuTNpyyFQDW1NtOvnHPN53MGbt+reborHnn7DXAeuS04SNXn0zU3v/UjOdEXs69+Lyy@vger.kernel.org X-Gm-Message-State: AOJu0Ywm5WlaSl/edlpzUbDfNTTrB35KIIX99o3aGYKkWBo0I+mPJQC3 1oNlMVFFxNrlgDrwwJrF12uxGQuTwp+fdugcLriTdH7tAhpLNO00WFf8w9fKqQk= X-Gm-Gg: ASbGncsZNnnIviv1SLaQ/IzayJs4/xk4HM3DjaSszS88e/kIwoV7cv2hu2rK8vsdDGx 7K5jwkfMO5N0CkpISLIWCa6Pu22hP4cqVQQnb0ftzBEnD7chvBkUb6gWAKbWXN1M9GEY4Coj5Ua iHxzmIdfduLZ0hotYW5Ejd/T8IGyYrJ41dHG4qeiYJwIyLBiRDQFAhgD1n+ORMkZlz15bKhOBj1 Ii9jSqD/pd2zPUFPzx5WWIapWk7NhgOBeI1pPUjvRFiksxLSa829grv9YylOin9NzonQSqSqYRE g/qMAj08bD6OWWOdCMgyVIWYV+miACjbVaka5pJg6jRy90Klr0lNGBCy3TTtjgm1jH0i X-Google-Smtp-Source: AGHT+IHYhgnp81nqwMBCWbPMWFBfzmSZkACfQ2sKTr2EMOGmU8XQOZdZtUBPiAChJ7TPftti0v9yCg== X-Received: by 2002:a05:620a:2608:b0:7c0:b0b7:493f with SMTP id af79cd13be357-7c4e617614bmr171776485a.37.1741302243486; Thu, 06 Mar 2025 15:04:03 -0800 (PST) Received: from debil.. (78-154-15-142.ip.btc-net.bg. [78.154.15.142]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac256654fa6sm14971966b.93.2025.03.06.15.04.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Mar 2025 15:04:03 -0800 (PST) From: Nikolay Aleksandrov To: netdev@vger.kernel.org Cc: shrijeet@enfabrica.net, alex.badea@keysight.com, eric.davis@broadcom.com, rip.sohan@amd.com, dsahern@kernel.org, bmt@zurich.ibm.com, roland@enfabrica.net, nikolay@enfabrica.net, winston.liu@keysight.com, dan.mihailescu@keysight.com, kheib@redhat.com, parth.v.parikh@keysight.com, davem@redhat.com, ian.ziemba@hpe.com, andrew.tauferner@cornelisnetworks.com, welch@hpe.com, rakhahari.bhunia@keysight.com, kingshuk.mandal@keysight.com, linux-rdma@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com Subject: [RFC PATCH 03/13] drivers: ultraeth: add new genl family Date: Fri, 7 Mar 2025 01:01:53 +0200 Message-ID: <20250306230203.1550314-4-nikolay@enfabrica.net> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250306230203.1550314-1-nikolay@enfabrica.net> References: <20250306230203.1550314-1-nikolay@enfabrica.net> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 The UE genl family is described by ynl spec in Documentation/netlink/specs/ultraeth.yaml. It supports context list, create and delete. The corresponding files are auto-generated by ynl: drivers/ultraeth/uet_netlink.c drivers/ultraeth/uet_netlink.h include/uapi/linux/ultraeth_nl.h Signed-off-by: Nikolay Aleksandrov Signed-off-by: Alex Badea --- Documentation/netlink/specs/ultraeth.yaml | 56 ++++++++++++++++++ drivers/ultraeth/Makefile | 2 +- drivers/ultraeth/uet_context.c | 72 +++++++++++++++++++++++ drivers/ultraeth/uet_main.c | 5 +- drivers/ultraeth/uet_netlink.c | 54 +++++++++++++++++ drivers/ultraeth/uet_netlink.h | 21 +++++++ include/uapi/linux/ultraeth_nl.h | 35 +++++++++++ 7 files changed, 243 insertions(+), 2 deletions(-) create mode 100644 Documentation/netlink/specs/ultraeth.yaml create mode 100644 drivers/ultraeth/uet_netlink.c create mode 100644 drivers/ultraeth/uet_netlink.h create mode 100644 include/uapi/linux/ultraeth_nl.h diff --git a/Documentation/netlink/specs/ultraeth.yaml b/Documentation/netlink/specs/ultraeth.yaml new file mode 100644 index 000000000000..55ab4d9b82a9 --- /dev/null +++ b/Documentation/netlink/specs/ultraeth.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) + +name: ultraeth +protocol: genetlink +uapi-header: linux/ultraeth_nl.h + +doc: Ultra Ethernet driver genetlink operations + +attribute-sets: + - + name: context + attributes: + - + name: id + type: s32 + checks: + min: 0 + max: 255 + - + name: contexts + attributes: + - + name: context + type: nest + nested-attributes: context + multi-attr: true + +operations: + name-prefix: ultraeth-cmd- + list: + - + name: context-get + doc: dump ultraeth context information + attribute-set: context + dump: + reply: + attributes: &all-context-attrs + - id + - + name: context-new + doc: add new ultraeth context + attribute-set: context + flags: [ admin-perm ] + do: + request: + attributes: + - id + - + name: context-del + doc: delete ultraeth context + attribute-set: context + flags: [ admin-perm ] + do: + request: + attributes: + - id diff --git a/drivers/ultraeth/Makefile b/drivers/ultraeth/Makefile index dc0c07eeef65..599d91d205c1 100644 --- a/drivers/ultraeth/Makefile +++ b/drivers/ultraeth/Makefile @@ -1,3 +1,3 @@ obj-$(CONFIG_ULTRAETH) += ultraeth.o -ultraeth-objs := uet_main.o uet_context.o +ultraeth-objs := uet_main.o uet_context.o uet_netlink.o diff --git a/drivers/ultraeth/uet_context.c b/drivers/ultraeth/uet_context.c index 1c74cd8bbd56..2444fa3f35cd 100644 --- a/drivers/ultraeth/uet_context.c +++ b/drivers/ultraeth/uet_context.c @@ -1,6 +1,7 @@ // SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) #include +#include "uet_netlink.h" #define MAX_CONTEXT_ID 256 static DECLARE_BITMAP(uet_context_ids, MAX_CONTEXT_ID); @@ -147,3 +148,74 @@ void uet_context_destroy_all(void) WARN_ON(!list_empty(&uet_context_list)); mutex_unlock(&uet_context_lock); } + +static int __nl_ctx_fill_one(struct sk_buff *skb, + const struct uet_context *ctx, + int cmd, u32 flags, u32 seq, u32 portid) +{ + void *hdr; + + hdr = genlmsg_put(skb, portid, seq, &ultraeth_nl_family, flags, cmd); + if (!hdr) + return -EMSGSIZE; + + if (nla_put_s32(skb, ULTRAETH_A_CONTEXT_ID, ctx->id)) + goto out_err; + + genlmsg_end(skb, hdr); + return 0; + +out_err: + genlmsg_cancel(skb, hdr); + return -EMSGSIZE; +} + +int ultraeth_nl_context_get_dumpit(struct sk_buff *skb, struct netlink_callback *cb) +{ + int idx = 0, s_idx = cb->args[0], err; + struct uet_context *ctx; + + mutex_lock(&uet_context_lock); + list_for_each_entry(ctx, &uet_context_list, list) { + if (idx < s_idx) { + idx++; + continue; + } + err = __nl_ctx_fill_one(skb, ctx, ULTRAETH_CMD_CONTEXT_GET, + NLM_F_MULTI, cb->nlh->nlmsg_seq, + NETLINK_CB(cb->skb).portid); + if (err) + break; + idx++; + } + cb->args[0] = idx; + mutex_unlock(&uet_context_lock); + + return err ? err : skb->len; +} + +int ultraeth_nl_context_new_doit(struct sk_buff *skb, struct genl_info *info) +{ + int id = -1; + + if (info->attrs[ULTRAETH_A_CONTEXT_ID]) + id = nla_get_s32(info->attrs[ULTRAETH_A_CONTEXT_ID]); + + return uet_context_create(id); +} + +int ultraeth_nl_context_del_doit(struct sk_buff *skb, struct genl_info *info) +{ + bool destroyed = false; + int id; + + if (!info->attrs[ULTRAETH_A_CONTEXT_ID]) { + NL_SET_ERR_MSG(info->extack, "UET context id must be specified"); + return -EINVAL; + } + + id = nla_get_s32(info->attrs[ULTRAETH_A_CONTEXT_ID]); + destroyed = uet_context_destroy(id); + + return destroyed ? 0 : -ENOENT; +} diff --git a/drivers/ultraeth/uet_main.c b/drivers/ultraeth/uet_main.c index 0f8383c6aba0..0ec1dc74abbb 100644 --- a/drivers/ultraeth/uet_main.c +++ b/drivers/ultraeth/uet_main.c @@ -5,13 +5,16 @@ #include #include +#include "uet_netlink.h" + static int __init uet_init(void) { - return 0; + return genl_register_family(&ultraeth_nl_family); } static void __exit uet_exit(void) { + genl_unregister_family(&ultraeth_nl_family); uet_context_destroy_all(); } diff --git a/drivers/ultraeth/uet_netlink.c b/drivers/ultraeth/uet_netlink.c new file mode 100644 index 000000000000..39e4aa6092a9 --- /dev/null +++ b/drivers/ultraeth/uet_netlink.c @@ -0,0 +1,54 @@ +// SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) +/* Do not edit directly, auto-generated from: */ +/* Documentation/netlink/specs/ultraeth.yaml */ +/* YNL-GEN kernel source */ + +#include +#include + +#include "uet_netlink.h" + +#include + +/* ULTRAETH_CMD_CONTEXT_NEW - do */ +static const struct nla_policy ultraeth_context_new_nl_policy[ULTRAETH_A_CONTEXT_ID + 1] = { + [ULTRAETH_A_CONTEXT_ID] = NLA_POLICY_RANGE(NLA_S32, 0, 255), +}; + +/* ULTRAETH_CMD_CONTEXT_DEL - do */ +static const struct nla_policy ultraeth_context_del_nl_policy[ULTRAETH_A_CONTEXT_ID + 1] = { + [ULTRAETH_A_CONTEXT_ID] = NLA_POLICY_RANGE(NLA_S32, 0, 255), +}; + +/* Ops table for ultraeth */ +static const struct genl_split_ops ultraeth_nl_ops[] = { + { + .cmd = ULTRAETH_CMD_CONTEXT_GET, + .dumpit = ultraeth_nl_context_get_dumpit, + .flags = GENL_CMD_CAP_DUMP, + }, + { + .cmd = ULTRAETH_CMD_CONTEXT_NEW, + .doit = ultraeth_nl_context_new_doit, + .policy = ultraeth_context_new_nl_policy, + .maxattr = ULTRAETH_A_CONTEXT_ID, + .flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO, + }, + { + .cmd = ULTRAETH_CMD_CONTEXT_DEL, + .doit = ultraeth_nl_context_del_doit, + .policy = ultraeth_context_del_nl_policy, + .maxattr = ULTRAETH_A_CONTEXT_ID, + .flags = GENL_ADMIN_PERM | GENL_CMD_CAP_DO, + }, +}; + +struct genl_family ultraeth_nl_family __ro_after_init = { + .name = ULTRAETH_FAMILY_NAME, + .version = ULTRAETH_FAMILY_VERSION, + .netnsok = true, + .parallel_ops = true, + .module = THIS_MODULE, + .split_ops = ultraeth_nl_ops, + .n_split_ops = ARRAY_SIZE(ultraeth_nl_ops), +}; diff --git a/drivers/ultraeth/uet_netlink.h b/drivers/ultraeth/uet_netlink.h new file mode 100644 index 000000000000..9dd9df24513a --- /dev/null +++ b/drivers/ultraeth/uet_netlink.h @@ -0,0 +1,21 @@ +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */ +/* Do not edit directly, auto-generated from: */ +/* Documentation/netlink/specs/ultraeth.yaml */ +/* YNL-GEN kernel header */ + +#ifndef _LINUX_ULTRAETH_GEN_H +#define _LINUX_ULTRAETH_GEN_H + +#include +#include + +#include + +int ultraeth_nl_context_get_dumpit(struct sk_buff *skb, + struct netlink_callback *cb); +int ultraeth_nl_context_new_doit(struct sk_buff *skb, struct genl_info *info); +int ultraeth_nl_context_del_doit(struct sk_buff *skb, struct genl_info *info); + +extern struct genl_family ultraeth_nl_family; + +#endif /* _LINUX_ULTRAETH_GEN_H */ diff --git a/include/uapi/linux/ultraeth_nl.h b/include/uapi/linux/ultraeth_nl.h new file mode 100644 index 000000000000..f3bdf8111623 --- /dev/null +++ b/include/uapi/linux/ultraeth_nl.h @@ -0,0 +1,35 @@ +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */ +/* Do not edit directly, auto-generated from: */ +/* Documentation/netlink/specs/ultraeth.yaml */ +/* YNL-GEN uapi header */ + +#ifndef _UAPI_LINUX_ULTRAETH_NL_H +#define _UAPI_LINUX_ULTRAETH_NL_H + +#define ULTRAETH_FAMILY_NAME "ultraeth" +#define ULTRAETH_FAMILY_VERSION 1 + +enum { + ULTRAETH_A_CONTEXT_ID = 1, + + __ULTRAETH_A_CONTEXT_MAX, + ULTRAETH_A_CONTEXT_MAX = (__ULTRAETH_A_CONTEXT_MAX - 1) +}; + +enum { + ULTRAETH_A_CONTEXTS_CONTEXT = 1, + + __ULTRAETH_A_CONTEXTS_MAX, + ULTRAETH_A_CONTEXTS_MAX = (__ULTRAETH_A_CONTEXTS_MAX - 1) +}; + +enum { + ULTRAETH_CMD_CONTEXT_GET = 1, + ULTRAETH_CMD_CONTEXT_NEW, + ULTRAETH_CMD_CONTEXT_DEL, + + __ULTRAETH_CMD_MAX, + ULTRAETH_CMD_MAX = (__ULTRAETH_CMD_MAX - 1) +}; + +#endif /* _UAPI_LINUX_ULTRAETH_NL_H */