From patchwork Thu Sep 24 18:12:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ira Weiny X-Patchwork-Id: 7259811 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A16EEBEEC1 for ; Thu, 24 Sep 2015 18:12:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C0C752095A for ; Thu, 24 Sep 2015 18:12:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0AD020887 for ; Thu, 24 Sep 2015 18:12:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755436AbbIXSMO (ORCPT ); Thu, 24 Sep 2015 14:12:14 -0400 Received: from mga01.intel.com ([192.55.52.88]:17628 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755361AbbIXSMO convert rfc822-to-8bit (ORCPT ); Thu, 24 Sep 2015 14:12:14 -0400 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP; 24 Sep 2015 11:12:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,582,1437462000"; d="scan'208";a="812530212" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 24 Sep 2015 11:12:13 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 24 Sep 2015 11:12:13 -0700 Received: from crsmsx104.amr.corp.intel.com (172.18.63.32) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 24 Sep 2015 11:12:13 -0700 Received: from crsmsx101.amr.corp.intel.com ([169.254.1.79]) by CRSMSX104.amr.corp.intel.com ([172.18.63.32]) with mapi id 14.03.0248.002; Thu, 24 Sep 2015 12:12:10 -0600 From: "Weiny, Ira" To: Doug Ledford , "Marciniszyn, Mike" CC: "linux-rdma@vger.kernel.org" , "kbuild-all@01.org" , Jim Davis Subject: RE: 0-day build issues Thread-Topic: 0-day build issues Thread-Index: AdD28HvjOUxezbNIQO+lpWEpal6kmzcVgORINxUT+HA= Date: Thu, 24 Sep 2015 18:12:09 +0000 Message-ID: <2807E5FD2F6FDA4886F6618EAC48510E1CB9D4D4@CRSMSX101.amr.corp.intel.com> References: <32E1700B9017364D9B60AED9960492BC257D3D76@fmsmsx120.amr.corp.intel.com> <42EC4987-428D-4988-BDDD-6B80915AA44C@redhat.com> In-Reply-To: <42EC4987-428D-4988-BDDD-6B80915AA44C@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.18.205.10] MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP > > What is being done in the parent directory has a bug, you're right that far, but > this is the wrong fix. If you check the 0day failures, it isn't because the > InfiniBand core isn't enabled, it's because the current menuconfig setup allows > the IB core to be a module and the staging drivers to be compiled into the > kernel. That obviously is an invalid condition and it applies to all of the drivers > in staging right now. The correct fix is to resolve that issue. That is our conclusion as well. But how do we do that globally in staging/rdma? The module setting of INFINIBAND does not seem to carry to the subdirs while the following does work. It seems like this is the easiest fix since this is a temp home for these drivers. Ira 13:54:05 > git di --- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/staging/rdma/amso1100/Kconfig b/drivers/staging/rdma/amso1100/Kconfig index e6ce5f209e47..809cb14ac6de 100644 --- a/drivers/staging/rdma/amso1100/Kconfig +++ b/drivers/staging/rdma/amso1100/Kconfig @@ -1,6 +1,6 @@ config INFINIBAND_AMSO1100 tristate "Ammasso 1100 HCA support" - depends on PCI && INET + depends on PCI && INET && INFINIBAND ---help--- This is a low-level driver for the Ammasso 1100 host channel adapter (HCA). diff --git a/drivers/staging/rdma/hfi1/Kconfig b/drivers/staging/rdma/hfi1/Kconfig index fd25078ee923..97372103e947 100644 --- a/drivers/staging/rdma/hfi1/Kconfig +++ b/drivers/staging/rdma/hfi1/Kconfig @@ -1,6 +1,6 @@ config INFINIBAND_HFI1 tristate "Intel OPA Gen1 support" - depends on X86_64 + depends on X86_64 && INFINIBAND default m ---help--- This is a low-level driver for Intel OPA Gen1 adapter. diff --git a/drivers/staging/rdma/ipath/Kconfig b/drivers/staging/rdma/ipath/Kconfig index 041ce0634968..12dcd4010a18 100644 --- a/drivers/staging/rdma/ipath/Kconfig +++ b/drivers/staging/rdma/ipath/Kconfig @@ -1,6 +1,6 @@ config INFINIBAND_IPATH tristate "QLogic HTX HCA support" - depends on 64BIT && NET && HT_IRQ + depends on 64BIT && NET && HT_IRQ && INFINIBAND ---help--- This is a driver for the deprecated QLogic Hyper-Transport IB host channel adapter (model QHT7140),