diff mbox

[librdmacm,3/8] autogen.sh: Use autoreconf in autogen.sh

Message ID 317ae98daf0eec49ffb297a5fc59b3738366af6d.1374011243.git.ydroneaud@opteya.com (mailing list archive)
State Rejected
Headers show

Commit Message

Yann Droneaud July 16, 2013, 9:59 p.m. UTC 
From: Jeff Squyres <jsquyres@cisco.com>

The old sequence of Autotools commands listed in autogen.sh is no
longer correct.  Instead, just use the single "autoreconf" command,
which will invoke all the Right Autotools commands in the correct
order.

Signed-off-by: Jeff Squyres <jsquyres@cisco.com>
Signed-off-by: Yann Droneaud <ydroneaud@opteya.com>
---
 autogen.sh | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Hefty, Sean July 17, 2013, 4:22 a.m. UTC | #1 
Thanks - I pulled in these patches, but see below:

> diff --git a/autogen.sh b/autogen.sh
> index f433312..6c9233e 100755
> --- a/autogen.sh
> +++ b/autogen.sh
> @@ -1,9 +1,4 @@
>  #! /bin/sh
> 
>  set -x
> -test -d ./config || mkdir ./config

Without the above line, the build fails.  I added it back in.  If there's some other way of ensuring that this directory exists, please let me know.

- Sean

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yann Droneaud July 17, 2013, 6:21 a.m. UTC | #2 
Hi,

Le 17.07.2013 06:22, Hefty, Sean a écrit :
> Thanks - I pulled in these patches, but see below:
> 

Thanks.

>> diff --git a/autogen.sh b/autogen.sh
>> index f433312..6c9233e 100755
>> --- a/autogen.sh
>> +++ b/autogen.sh
>> @@ -1,9 +1,4 @@
>>  #! /bin/sh
>> 
>>  set -x
>> -test -d ./config || mkdir ./config
> 
> Without the above line, the build fails.  I added it back in.  If
> there's some other way of ensuring that this directory exists, please
> let me know.
> 

Sorry for the inconvenience.

I've checked libibverbs: it has a .gitignore in ./config so that git 
kept the empty directory.

It's a different solution for the same problem, I'm not able to say if 
it's a better one.

Regards.
Or Gerlitz July 17, 2013, 6:58 a.m. UTC | #3 
On 17/07/2013 07:22, Hefty, Sean wrote:
> Thanks - I pulled in these patches, but see below:

Hi Sean,

If you do this house cleanup, could you also address the below build 
warnings. I can see them
when I build rpm from the 1.0.17 tar ball, but not when doing plain make 
on the latest git, probably
b/c the build through the spec uses some more build/warnings flags.

Or.


configure: creating ./config.status
config.status: creating Makefile
config.status: creating librdmacm.spec
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing libtool commands
+ make -j2
make  all-am
make[1]: Entering directory `/usr/src/redhat/BUILD/librdmacm-1.0.17'
   CC     src_librdmacm_la-cma.lo
   CC     src_librdmacm_la-addrinfo.lo
src/addrinfo.c: In function 'ucma_convert_to_rai':
src/addrinfo.c:193: warning: dereferencing type-punned pointer will 
break strict-aliasing rules
src/addrinfo.c:210: warning: dereferencing type-punned pointer will 
break strict-aliasing rules
   CC     src_librdmacm_la-acm.lo
   CC     src_librdmacm_la-rsocket.lo
src/rsocket.c: In function 'rs_modify_svcs':
src/rsocket.c:403: warning: ignoring return value of 'write', declared 
with attribute warn_unused_result
src/rsocket.c:404: warning: ignoring return value of 'read', declared 
with attribute warn_unused_result
src/rsocket.c: In function 'rs_configure':
src/rsocket.c:460: warning: ignoring return value of 'fscanf', declared 
with attribute warn_unused_result
src/rsocket.c:465: warning: ignoring return value of 'fscanf', declared 
with attribute warn_unused_result
src/rsocket.c:473: warning: ignoring return value of 'fscanf', declared 
with attribute warn_unused_result
src/rsocket.c:478: warning: ignoring return value of 'fscanf', declared 
with attribute warn_unused_result
src/rsocket.c:483: warning: ignoring return value of 'fscanf', declared 
with attribute warn_unused_result
src/rsocket.c:491: warning: ignoring return value of 'fscanf', declared 
with attribute warn_unused_result
src/rsocket.c:498: warning: ignoring return value of 'fscanf', declared 
with attribute warn_unused_result
src/rsocket.c: In function 'rs_svc_process_sock':
src/rsocket.c:3623: warning: ignoring return value of 'read', declared 
with attribute warn_unused_result
src/rsocket.c:3632: warning: ignoring return value of 'write', declared 
with attribute warn_unused_result
src/rsocket.c: In function 'rs_svc_run':
src/rsocket.c:3805: warning: ignoring return value of 'write', declared 
with attribute warn_unused_result
src/rsocket.c: In function 'ds_get_dest':
src/rsocket.c:1451: warning: 'qp' may be used uninitialized in this function
src/rsocket.c: In function 'rs_send_iomaps':
src/rsocket.c:2305: warning: 'ret' may be used uninitialized in this 
function
   CC     src_librdmacm_la-indexer.lo
   CC     src_librspreload_la-preload.lo
src/preload.c: In function 'dup2':
src/preload.c:1020: warning: value computed is not used
   CC     src_librspreload_la-indexer.lo
   CC     cmatose.o
   CC     common.o
   CC     rping.o
   CC     udaddy.o
   CC     mckey.o
   CC     rdma_client.o
   CC     rdma_server.o
   CC     rdma_xclient.o
   CC     rdma_xserver.o
   CC     rstream.o
   CC     rcopy.o
   CC     riostream.o
   CC     udpong.o
   CCLD   src/librdmacm.la
   CCLD   src/librspreload.la
   CCLD   examples/ucmatose
   CCLD   examples/rping
   CCLD   examples/udaddy
   CCLD   examples/mckey
   CCLD   examples/rdma_client
   CCLD   examples/rdma_server
   CCLD   examples/rdma_xclient
   CCLD   examples/rdma_xserver
   CCLD   examples/rstream
   CCLD   examples/rcopy
   CCLD   examples/riostream
   CCLD   examples/udpong
make[1]: Leaving directory `/usr/src/redhat/BUILD/librdmacm-1.0.17'
+ exit 0
Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.10929

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Or Gerlitz July 31, 2013, 6:58 a.m. UTC | #4 
On 17/07/2013 09:58, Or Gerlitz wrote:
> On 17/07/2013 07:22, Hefty, Sean wrote:
>> Thanks - I pulled in these patches, but see below:
>
> Hi Sean,
>
> If you do this house cleanup, could you also address the below build 
> warnings. I can see them
> when I build rpm from the 1.0.17 tar ball, but not when doing plain 
> make on the latest git, probably
> b/c the build through the spec uses some more build/warnings flags.
>
>

Hi Sean,

Did you had the chance to look on cleaning these warnings too? I don't 
think its the one Bart was fixing, correct?

Or.

>
> configure: creating ./config.status
> config.status: creating Makefile
> config.status: creating librdmacm.spec
> config.status: creating config.h
> config.status: executing depfiles commands
> config.status: executing libtool commands
> + make -j2
> make  all-am
> make[1]: Entering directory `/usr/src/redhat/BUILD/librdmacm-1.0.17'
>   CC     src_librdmacm_la-cma.lo
>   CC     src_librdmacm_la-addrinfo.lo
> src/addrinfo.c: In function 'ucma_convert_to_rai':
> src/addrinfo.c:193: warning: dereferencing type-punned pointer will 
> break strict-aliasing rules
> src/addrinfo.c:210: warning: dereferencing type-punned pointer will 
> break strict-aliasing rules
>   CC     src_librdmacm_la-acm.lo
>   CC     src_librdmacm_la-rsocket.lo
> src/rsocket.c: In function 'rs_modify_svcs':
> src/rsocket.c:403: warning: ignoring return value of 'write', declared 
> with attribute warn_unused_result
> src/rsocket.c:404: warning: ignoring return value of 'read', declared 
> with attribute warn_unused_result
> src/rsocket.c: In function 'rs_configure':
> src/rsocket.c:460: warning: ignoring return value of 'fscanf', 
> declared with attribute warn_unused_result
> src/rsocket.c:465: warning: ignoring return value of 'fscanf', 
> declared with attribute warn_unused_result
> src/rsocket.c:473: warning: ignoring return value of 'fscanf', 
> declared with attribute warn_unused_result
> src/rsocket.c:478: warning: ignoring return value of 'fscanf', 
> declared with attribute warn_unused_result
> src/rsocket.c:483: warning: ignoring return value of 'fscanf', 
> declared with attribute warn_unused_result
> src/rsocket.c:491: warning: ignoring return value of 'fscanf', 
> declared with attribute warn_unused_result
> src/rsocket.c:498: warning: ignoring return value of 'fscanf', 
> declared with attribute warn_unused_result
> src/rsocket.c: In function 'rs_svc_process_sock':
> src/rsocket.c:3623: warning: ignoring return value of 'read', declared 
> with attribute warn_unused_result
> src/rsocket.c:3632: warning: ignoring return value of 'write', 
> declared with attribute warn_unused_result
> src/rsocket.c: In function 'rs_svc_run':
> src/rsocket.c:3805: warning: ignoring return value of 'write', 
> declared with attribute warn_unused_result
> src/rsocket.c: In function 'ds_get_dest':
> src/rsocket.c:1451: warning: 'qp' may be used uninitialized in this 
> function
> src/rsocket.c: In function 'rs_send_iomaps':
> src/rsocket.c:2305: warning: 'ret' may be used uninitialized in this 
> function
>   CC     src_librdmacm_la-indexer.lo
>   CC     src_librspreload_la-preload.lo
> src/preload.c: In function 'dup2':
> src/preload.c:1020: warning: value computed is not used
>   CC     src_librspreload_la-indexer.lo
>   CC     cmatose.o
>   CC     common.o
>   CC     rping.o
>   CC     udaddy.o
>   CC     mckey.o
>   CC     rdma_client.o
>   CC     rdma_server.o
>   CC     rdma_xclient.o
>   CC     rdma_xserver.o
>   CC     rstream.o
>   CC     rcopy.o
>   CC     riostream.o
>   CC     udpong.o
>   CCLD   src/librdmacm.la
>   CCLD   src/librspreload.la
>   CCLD   examples/ucmatose
>   CCLD   examples/rping
>   CCLD   examples/udaddy
>   CCLD   examples/mckey
>   CCLD   examples/rdma_client
>   CCLD   examples/rdma_server
>   CCLD   examples/rdma_xclient
>   CCLD   examples/rdma_xserver
>   CCLD   examples/rstream
>   CCLD   examples/rcopy
>   CCLD   examples/riostream
>   CCLD   examples/udpong
> make[1]: Leaving directory `/usr/src/redhat/BUILD/librdmacm-1.0.17'
> + exit 0
> Executing(%install): /bin/sh -e /var/tmp/rpm-tmp.10929
>
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Hefty, Sean July 31, 2013, 8:20 p.m. UTC | #5 
> Did you had the chance to look on cleaning these warnings too? I don't
> think its the one Bart was fixing, correct?

I have not.  I saved your email, but have not had time to try fixing the warnings.

- Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/autogen.sh b/autogen.sh
index f433312..6c9233e 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -1,9 +1,4 @@ 
 #! /bin/sh
 
 set -x
-test -d ./config || mkdir ./config
-aclocal -I config
-libtoolize --force --copy
-autoheader
-automake --foreign --add-missing --copy
-autoconf
+autoreconf -ifv -I config