From patchwork Mon May 9 19:39:56 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Marciniszyn X-Patchwork-Id: 770522 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p49Je4nv004089 for ; Mon, 9 May 2011 19:40:04 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754310Ab1EITkD (ORCPT ); Mon, 9 May 2011 15:40:03 -0400 Received: from ch1outboundpool.messaging.microsoft.com ([216.32.181.183]:35126 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754250Ab1EITkB convert rfc822-to-8bit (ORCPT ); Mon, 9 May 2011 15:40:01 -0400 Received: from mail8-ch1-R.bigfish.com (216.32.181.168) by CH1EHSOBE002.bigfish.com (10.43.70.52) with Microsoft SMTP Server id 14.1.225.8; Mon, 9 May 2011 19:39:59 +0000 Received: from mail8-ch1 (localhost.localdomain [127.0.0.1]) by mail8-ch1-R.bigfish.com (Postfix) with ESMTP id A7EF7890250; Mon, 9 May 2011 19:39:59 +0000 (UTC) X-SpamScore: -21 X-BigFish: VPS-21(zz9371O1447R542Mzz1202hzz8275bh8275dhz2ei2a8h668h839h61h) X-Spam-TCS-SCL: 0:0 X-Forefront-Antispam-Report: KIP:(null); UIP:(null); IPVD:NLI; H:avexcashub1.qlogic.com; RD:avexcashub2.qlogic.com; EFVD:NLI Received: from mail8-ch1 (localhost.localdomain [127.0.0.1]) by mail8-ch1 (MessageSwitch) id 1304969999302315_13502; Mon, 9 May 2011 19:39:59 +0000 (UTC) Received: from CH1EHSMHS026.bigfish.com (snatpool1.int.messaging.microsoft.com [10.43.68.245]) by mail8-ch1.bigfish.com (Postfix) with ESMTP id 37CEC1620055; Mon, 9 May 2011 19:39:59 +0000 (UTC) Received: from avexcashub1.qlogic.com (198.70.193.64) by CH1EHSMHS026.bigfish.com (10.43.70.26) with Microsoft SMTP Server (TLS) id 14.1.225.8; Mon, 9 May 2011 19:39:58 +0000 Received: from avexmb1.qlogic.org ([fe80::9545:3a4f:c131:467d]) by avexcashub2.qlogic.org ([::1]) with mapi; Mon, 9 May 2011 12:39:58 -0700 From: Mike Marciniszyn To: Sergei Shtylyov , "linux-rdma@vger.kernel.org" CC: "roland@kernel.org" , "sean.hefty@intel.com" , "hal.rosenstock@gmail.com" , linux-kernel Date: Mon, 9 May 2011 12:39:56 -0700 Subject: RE: [PATCH 2/2] qib: use pci_dev->revision Thread-Topic: [PATCH 2/2] qib: use pci_dev->revision Thread-Index: AcwM3ldJO66u96weRye5Qauir6A2CABolo8A Message-ID: <35AAF1E4A771E142979F27B51793A4888838BCBDB9@AVEXMB1.qlogic.org> References: <201105072141.56328.sshtylyov@ru.mvista.com> In-Reply-To: <201105072141.56328.sshtylyov@ru.mvista.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-OriginatorOrg: qlogic.com Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Mon, 09 May 2011 19:40:04 +0000 (UTC) > The driver reads PCI revision ID from the PCI configuration register while it's > already stored by PCI subsystem in the 'revision' field of 'struct pci_dev'... Thanks for the patch. qib: use pci_dev->revision Acked-by: Mike Marciniszyn -----Original Message----- From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma-owner@vger.kernel.org] On Behalf Of Sergei Shtylyov Sent: Saturday, May 07, 2011 1:42 PM To: linux-rdma@vger.kernel.org Cc: roland@kernel.org; sean.hefty@intel.com; hal.rosenstock@gmail.com; linux-kernel Subject: [PATCH 2/2] qib: use pci_dev->revision The driver reads PCI revision ID from the PCI configuration register while it's already stored by PCI subsystem in the 'revision' field of 'struct pci_dev'... Signed-off-by: Sergei Shtylyov --- The patch is against the recent Linus' tree. drivers/infiniband/hw/qib/qib_pcie.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-2.6/drivers/infiniband/hw/qib/qib_pcie.c =================================================================== --- linux-2.6.orig/drivers/infiniband/hw/qib/qib_pcie.c +++ linux-2.6/drivers/infiniband/hw/qib/qib_pcie.c @@ -526,11 +526,8 @@ static int qib_tune_pcie_coalesce(struct */ devid = parent->device; if (devid >= 0x25e2 && devid <= 0x25fa) { - u8 rev; - /* 5000 P/V/X/Z */ - pci_read_config_byte(parent, PCI_REVISION_ID, &rev); - if (rev <= 0xb2) + if (parent->revision <= 0xb2) bits = 1U << 10; else bits = 7U << 10;